73d4c3135b
When disabling a regulator fails while the device goes away, there is little we can do and the machine is probably in enough trouble that any action we'd want to take fails anyhow. The return value used to be passed on in cs42l51_i2c_remove() (i.e. the i2c device remove callback). But the i2c core ignores the error code (apart from emitting a generic warning) and removes the device anyhow. So return 0 unconditionally in cs42l51_i2c_remove(), and instead of returning the error code to the upper layer emit a more helpful warning message. After that nobody is interested any more in the actual error code, so let cs42l51_remove() return void. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20220110071832.306185-1-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
59 lines
1.2 KiB
C
59 lines
1.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* cs42l56.c -- CS42L51 ALSA SoC I2C audio driver
|
|
*
|
|
* Copyright 2014 CirrusLogic, Inc.
|
|
*
|
|
* Author: Brian Austin <brian.austin@cirrus.com>
|
|
*/
|
|
|
|
#include <linux/i2c.h>
|
|
#include <linux/module.h>
|
|
#include <sound/soc.h>
|
|
|
|
#include "cs42l51.h"
|
|
|
|
static struct i2c_device_id cs42l51_i2c_id[] = {
|
|
{"cs42l51", 0},
|
|
{}
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, cs42l51_i2c_id);
|
|
|
|
static int cs42l51_i2c_probe(struct i2c_client *i2c,
|
|
const struct i2c_device_id *id)
|
|
{
|
|
struct regmap_config config;
|
|
|
|
config = cs42l51_regmap;
|
|
|
|
return cs42l51_probe(&i2c->dev, devm_regmap_init_i2c(i2c, &config));
|
|
}
|
|
|
|
static int cs42l51_i2c_remove(struct i2c_client *i2c)
|
|
{
|
|
cs42l51_remove(&i2c->dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct dev_pm_ops cs42l51_pm_ops = {
|
|
SET_SYSTEM_SLEEP_PM_OPS(cs42l51_suspend, cs42l51_resume)
|
|
};
|
|
|
|
static struct i2c_driver cs42l51_i2c_driver = {
|
|
.driver = {
|
|
.name = "cs42l51",
|
|
.of_match_table = cs42l51_of_match,
|
|
.pm = &cs42l51_pm_ops,
|
|
},
|
|
.probe = cs42l51_i2c_probe,
|
|
.remove = cs42l51_i2c_remove,
|
|
.id_table = cs42l51_i2c_id,
|
|
};
|
|
|
|
module_i2c_driver(cs42l51_i2c_driver);
|
|
|
|
MODULE_DESCRIPTION("ASoC CS42L51 I2C Driver");
|
|
MODULE_AUTHOR("Brian Austin, Cirrus Logic Inc, <brian.austin@cirrus.com>");
|
|
MODULE_LICENSE("GPL");
|