Robin Murphy 01657bc14a iommu: Avoid races around device probe
We currently have 3 different ways that __iommu_probe_device() may be
called, but no real guarantee that multiple callers can't tread on each
other, especially once asynchronous driver probe gets involved. It would
likely have taken a fair bit of luck to hit this previously, but commit
57365a04c921 ("iommu: Move bus setup to IOMMU device registration") ups
the odds since now it's not just omap-iommu that may trigger multiple
bus_iommu_probe() calls in parallel if probing asynchronously.

Add a lock to ensure we can't try to double-probe a device, and also
close some possible race windows to make sure we're truly robust against
trying to double-initialise a group via two different member devices.

Reported-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Tested-by: Brian Norris <briannorris@chromium.org>
Fixes: 57365a04c921 ("iommu: Move bus setup to IOMMU device registration")
Link: https://lore.kernel.org/r/1946ef9f774851732eed78760a78ec40dbc6d178.1667591503.git.robin.murphy@arm.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
2022-11-19 10:17:42 +01:00
..
2022-09-09 09:26:22 +02:00
2022-09-09 09:26:22 +02:00
2022-11-03 15:47:54 +01:00
2022-11-03 15:47:54 +01:00
2022-11-03 15:47:54 +01:00
2022-11-19 10:17:42 +01:00
2022-11-03 15:47:54 +01:00
2022-09-07 14:26:17 +02:00
2022-09-07 14:26:17 +02:00
2022-09-07 14:26:17 +02:00