Geert Uytterhoeven 01bb96ad38 of: overlay: Call of_changeset_init() early ...

[ Upstream commit a9515ff4fb142b690a0d2b58782b15903b990dba ]

When of_overlay_fdt_apply() fails, the changeset may be partially
applied, and the caller is still expected to call of_overlay_remove() to
clean up this partial state.

However, of_overlay_apply() calls of_resolve_phandles() before
init_overlay_changeset().  Hence if the overlay fails to apply due to an
unresolved symbol, the overlay_changeset.cset.entries list is still
uninitialized, and cleanup will crash with a NULL-pointer dereference in
overlay_removal_is_ok().

Fix this by moving the call to of_changeset_init() from
init_overlay_changeset() to of_overlay_fdt_apply(), where all other
early initialization is done.

Fixes: f948d6d8b792bb90 ("of: overlay: avoid race condition between applying multiple overlays")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/4f1d6d74b61cba2599026adb6d1948ae559ce91f.1690533838.git.geert+renesas@glider.be
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2023-09-19 12:22:40 +02:00

..

unittest-data

of: unittest: Statically apply overlays using fdtoverlay

2021-03-23 15:27:51 -06:00

address.c

of/address: Return an error when no valid dma-ranges are found

2023-02-14 19:17:57 +01:00

base.c

of: base: Improve argument length mismatch error

2022-01-27 11:05:19 +01:00

device.c

of: Fix modalias string generation

2023-05-11 23:00:32 +09:00

dynamic.c

of: dynamic: Refactor action prints to not use "%pOF" inside devtree_lock

2023-08-30 16:18:18 +02:00

fdt_address.c

…

fdt.c

of: fdt: fix off-by-one error in unflatten_dt_nodes()

2022-09-23 14:15:46 +02:00

irq.c

of: Add missing 'Return' section in kerneldoc comments

2021-03-27 12:59:03 -06:00

Kconfig

of: net: move of_net under net/

2022-03-08 19:12:41 +01:00

kexec.c

of: kexec: Mark ima_{free,stable}_kexec_buffer() as __init

2023-09-19 12:22:30 +02:00

kobj.c

of: Don't allow __of_attached_node_sysfs() without CONFIG_SYSFS

2021-08-23 13:52:09 -05:00

Makefile

of: net: move of_net under net/

2022-03-08 19:12:41 +01:00

of_numa.c

…

of_private.h

of: Move of_dma_set_restricted_buffer() into device.c

2021-08-23 06:32:02 -04:00

of_reserved_mem.c

of: reserved_mem: Have kmemleak ignore dynamically allocated reserved mem

2023-02-22 12:57:07 +01:00

overlay.c

of: overlay: Call of_changeset_init() early

2023-09-19 12:22:40 +02:00

pdt.c

…

platform.c

iommu: Drop unnecessary of_iommu.h includes

2021-06-08 14:15:46 +02:00

property.c

of: property: decrement node refcount in of_fwnode_get_reference_args()

2022-12-08 11:28:39 +01:00

resolver.c

…

unittest.c

of: unittest: fix null pointer dereferencing in of_unittest_find_node_by_name()

2023-09-19 12:22:38 +02:00