iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/cifs
History
Paulo Alcantara 01f2ee7e32 cifs: fix memory leaks in session setup 
We were only zeroing out the ntlmssp blob but forgot to free the
allocated buffer in the end of SMB2_sess_auth_rawntlmssp_negotiate()
and SMB2_sess_auth_rawntlmssp_authenticate() functions.

This fixes below kmemleak reports:

unreferenced object 0xffff88800ddcfc60 (size 96):
  comm "mount.cifs", pid 758, jiffies 4294696066 (age 42.967s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<00000000d0beeb29>] __kmalloc+0x39/0xa0
    [<00000000e3834047>] build_ntlmssp_smb3_negotiate_blob+0x2c/0x110 [cifs]
    [<00000000e85f5ab2>] SMB2_sess_auth_rawntlmssp_negotiate+0xd3/0x230 [cifs]
    [<0000000080fdb897>] SMB2_sess_setup+0x16c/0x2a0 [cifs]
    [<000000009af320a8>] cifs_setup_session+0x13b/0x370 [cifs]
    [<00000000f15d5982>] cifs_get_smb_ses+0x643/0xb90 [cifs]
    [<00000000fe15eb90>] mount_get_conns+0x63/0x3e0 [cifs]
    [<00000000768aba03>] mount_get_dfs_conns+0x16/0xa0 [cifs]
    [<00000000cf1cf146>] cifs_mount+0x1c2/0x9a0 [cifs]
    [<000000000d66b51e>] cifs_smb3_do_mount+0x10e/0x710 [cifs]
    [<0000000077a996c5>] smb3_get_tree+0xf4/0x200 [cifs]
    [<0000000094dbd041>] vfs_get_tree+0x23/0xc0
    [<000000003a8561de>] path_mount+0x2d3/0xb50
    [<00000000ed5c86d6>] __x64_sys_mount+0x102/0x140
    [<00000000142142f3>] do_syscall_64+0x3b/0x90
    [<00000000e2b89731>] entry_SYSCALL_64_after_hwframe+0x63/0xcd
unreferenced object 0xffff88801437f000 (size 512):
  comm "mount.cifs", pid 758, jiffies 4294696067 (age 42.970s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<00000000d0beeb29>] __kmalloc+0x39/0xa0
    [<00000000004f53d2>] build_ntlmssp_auth_blob+0x4f/0x340 [cifs]
    [<000000005f333084>] SMB2_sess_auth_rawntlmssp_authenticate+0xd4/0x250 [cifs]
    [<0000000080fdb897>] SMB2_sess_setup+0x16c/0x2a0 [cifs]
    [<000000009af320a8>] cifs_setup_session+0x13b/0x370 [cifs]
    [<00000000f15d5982>] cifs_get_smb_ses+0x643/0xb90 [cifs]
    [<00000000fe15eb90>] mount_get_conns+0x63/0x3e0 [cifs]
    [<00000000768aba03>] mount_get_dfs_conns+0x16/0xa0 [cifs]
    [<00000000cf1cf146>] cifs_mount+0x1c2/0x9a0 [cifs]
    [<000000000d66b51e>] cifs_smb3_do_mount+0x10e/0x710 [cifs]
    [<0000000077a996c5>] smb3_get_tree+0xf4/0x200 [cifs]
    [<0000000094dbd041>] vfs_get_tree+0x23/0xc0
    [<000000003a8561de>] path_mount+0x2d3/0xb50
    [<00000000ed5c86d6>] __x64_sys_mount+0x102/0x140
    [<00000000142142f3>] do_syscall_64+0x3b/0x90
    [<00000000e2b89731>] entry_SYSCALL_64_after_hwframe+0x63/0xcd

Fixes: a4e430c8c8ba ("cifs: replace kfree() with kfree_sensitive() for sensitive data")
Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
2022-10-19 17:57:51 -05:00
..
asn1.c
cifs: decoding negTokenInit with generic ASN1 decoder
2021-06-20 21:28:17 -05:00
cached_dir.c
cifs: drop the lease for cached directories on rmdir or rename
2022-10-19 17:57:41 -05:00
cached_dir.h
cifs: drop the lease for cached directories on rmdir or rename
2022-10-19 17:57:41 -05:00
cifs_debug.c
smb3: add dynamic trace points for tree disconnect
2022-10-05 01:31:18 -05:00
cifs_debug.h
smb3: add dynamic trace points for tree disconnect
2022-10-05 01:31:18 -05:00
cifs_dfs_ref.c
cifs: support nested dfs links over reconnect
2021-11-10 16:30:13 -06:00
cifs_fs_sb.h
cifs: support nested dfs links over reconnect
2021-11-10 16:30:13 -06:00
cifs_ioctl.h
smb3: improve SMB3 change notification support
2022-10-15 10:05:53 -05:00
cifs_spnego_negtokeninit.asn1
cifs: decoding negTokenInit with generic ASN1 decoder
2021-06-20 21:28:17 -05:00
cifs_spnego.c
cifs: use the chans_need_reconnect bitmap for reconnect status
2022-01-02 20:38:46 -06:00
cifs_spnego.h
cifs: use the chans_need_reconnect bitmap for reconnect status
2022-01-02 20:38:46 -06:00
cifs_swn.c
smb3: add dynamic trace points for tree disconnect
2022-10-05 01:31:18 -05:00
cifs_swn.h
cifs: simplify SWN code with dummy funcs instead of ifdefs
2021-04-25 16:28:22 -05:00
cifs_unicode.c
cifs: remove pathname for file from SPDX header
2021-09-13 14:51:10 -05:00
cifs_unicode.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
cifs_uniupr.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
cifsacl.c
cifs: when insecure legacy is disabled shrink amount of SMB1 code
2022-08-05 11:24:03 -05:00
cifsacl.h
cifs: remove pathname for file from SPDX header
2021-09-13 14:51:10 -05:00
cifsencrypt.c
cifs: secmech: use shash_desc directly, remove sdesc
2022-10-07 23:08:39 -05:00
cifsfs.c
cifs: Fix xid leak in cifs_copy_file_range()
2022-10-18 11:33:43 -05:00
cifsfs.h
cifs: update internal module number
2022-09-14 04:00:06 -05:00
cifsglob.h
smb3: improve SMB3 change notification support
2022-10-15 10:05:53 -05:00
cifspdu.h
cifs: Replace a couple of one-element arrays with flexible-array members
2022-10-05 17:42:38 -05:00
cifsproto.h
cifs: improve symlink handling for smb2+
2022-10-13 09:36:04 -05:00
cifsroot.c
cifs: move from strlcpy with unused retval to strscpy
2022-08-19 11:02:26 -05:00
cifssmb.c
cifs: use ALIGN() and round_up() macros
2022-10-13 09:36:39 -05:00
connect.c
cifs: use ALIGN() and round_up() macros
2022-10-13 09:36:39 -05:00
dfs_cache.c
smb3: add dynamic trace points for tree disconnect
2022-10-05 01:31:18 -05:00
dfs_cache.h
cifs: support share failover when remounting
2021-07-22 11:43:23 -05:00
dir.c
cifs: Fix xid leak in cifs_create()
2022-10-18 11:33:43 -05:00
dns_resolve.c
cifs: remove pathname for file from SPDX header
2021-09-13 14:51:10 -05:00
dns_resolve.h
cifs: remove pathname for file from SPDX header
2021-09-13 14:51:10 -05:00
export.c
cifs: remove pathname for file from SPDX header
2021-09-13 14:51:10 -05:00
file.c
cifs: Fix xid leak in cifs_flock()
2022-10-18 11:33:43 -05:00
fs_context.c
cifs: replace kfree() with kfree_sensitive() for sensitive data
2022-10-07 23:06:48 -05:00
fs_context.h
smb3: allow deferred close timeout to be configurable
2022-08-11 20:03:04 -05:00
fscache.c
smb3: add dynamic trace points for tree disconnect
2022-10-05 01:31:18 -05:00
fscache.h
cifs: Remove {cifs,nfs}_fscache_release_page()
2022-08-10 21:26:08 -05:00
inode.c
cifs: Fix xid leak in cifs_get_file_info_unix()
2022-10-18 11:33:43 -05:00
ioctl.c
smb3: improve SMB3 change notification support
2022-10-15 10:05:53 -05:00
Kconfig
cifs: Support fscache indexing rewrite
2022-01-19 11:21:08 -06:00
link.c
cifs: improve symlink handling for smb2+
2022-10-13 09:36:04 -05:00
Makefile
cifs: Move cached-dir functions into a separate file
2022-08-11 10:33:18 -05:00
misc.c
cifs: secmech: use shash_desc directly, remove sdesc
2022-10-07 23:08:39 -05:00
netlink.c
genetlink: start to validate reserved header bytes
2022-08-29 12:47:15 +01:00
netlink.h
cifs: Register generic netlink family
2020-12-14 09:16:22 -06:00
netmisc.c
cifs: remove unused server parameter from calc_smb_size()
2022-08-17 18:07:13 -05:00
nterr.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61
2019-05-24 17:36:45 +02:00
nterr.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61
2019-05-24 17:36:45 +02:00
ntlmssp.h
treewide: Replace zero-length arrays with flexible-array members
2022-02-17 07:00:39 -06:00
readdir.c
cifs: improve symlink handling for smb2+
2022-10-13 09:36:04 -05:00
rfc1002pdu.h
cifs: remove pathname for file from SPDX header
2021-09-13 14:51:10 -05:00
sess.c
cifs: Fix xid leak in cifs_ses_add_channel()
2022-10-18 11:33:43 -05:00
smb1ops.c
cifs: improve symlink handling for smb2+
2022-10-13 09:36:04 -05:00
smb2file.c
cifs: fix static checker warning
2022-10-14 12:35:25 -05:00
smb2glob.h
smb3: move defines for ioctl protocol header and SMB2 sizes to smbfs_common
2022-03-26 23:09:20 -05:00
smb2inode.c
cifs: drop the lease for cached directories on rmdir or rename
2022-10-19 17:57:41 -05:00
smb2maperror.c
cifs: Create a new shared file holding smb2 pdu definitions
2021-11-05 09:50:57 -05:00
smb2misc.c
cifs: use ALIGN() and round_up() macros
2022-10-13 09:36:39 -05:00
smb2ops.c
smb3: interface count displayed incorrectly
2022-10-19 10:06:23 -05:00
smb2pdu.c
cifs: fix memory leaks in session setup
2022-10-19 17:57:51 -05:00
smb2pdu.h
cifs: improve symlink handling for smb2+
2022-10-13 09:36:04 -05:00
smb2proto.h
smb3: improve SMB3 change notification support
2022-10-15 10:05:53 -05:00
smb2status.h
cifs: remove pathname for file from SPDX header
2021-09-13 14:51:10 -05:00
smb2transport.c
smb3: fix oops in calculating shash_setkey
2022-10-07 23:08:41 -05:00
smbdirect.c
Fix formatting of client smbdirect RDMA logging
2022-10-05 01:31:04 -05:00
smbdirect.h
Decrease the number of SMB3 smbdirect client SGEs
2022-10-05 01:29:21 -05:00
smbencrypt.c
cifs: rename cifs_common to smbfs_common
2021-09-08 23:59:26 -05:00
smberr.h
cifs: remove pathname for file from SPDX header
2021-09-13 14:51:10 -05:00
trace.c
smb3: Cleanup license mess
2019-01-24 09:37:33 -06:00
trace.h
smb3: add dynamic trace points for tree disconnect
2022-10-05 01:31:18 -05:00
transport.c
Scheduler changes for v6.1:
2022-10-10 09:10:28 -07:00
unc.c
cifs: don't cargo-cult strndup()
2021-04-25 16:28:23 -05:00
winucase.c
cifs: remove pathname for file from SPDX header
2021-09-13 14:51:10 -05:00
xattr.c
cifs: when insecure legacy is disabled shrink amount of SMB1 code
2022-08-05 11:24:03 -05:00