linux

iv/linux

Files

Finn Thain f8a85be02f mac8390: Fix mmio access size probe

[ Upstream commit bb9e5c5bcd ]

The bug that Stan reported is as follows. After a restart, a 16-bit NIC
may be incorrectly identified as a 32-bit NIC and stop working.

mac8390 slot.E: Memory length resource not found, probing
mac8390 slot.E: Farallon EtherMac II-C (type farallon)
mac8390 slot.E: MAC 00:00:c5:30:c2:99, IRQ 61, 32 KB shared memory at 0xfeed0000, 32-bit access.

The bug never arises after a cold start and only intermittently after a
warm start. (I didn't investigate why the bug is intermittent.)

It turns out that memcpy_toio() is deprecated and memcmp_withio() also
has issues. Replacing these calls with mmio accessors fixes the problem.

Reported-and-tested-by: Stan Johnson <userm57@yahoo.com>
Fixes: 2964db0f59 ("m68k: Mac DP8390 update")
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2019-04-03 06:25:11 +02:00

8390.c

net: deprecate eth_change_mtu, remove usage

2016-10-13 09:36:57 -04:00

8390.h

…

8390p.c

net: deprecate eth_change_mtu, remove usage

2016-10-13 09:36:57 -04:00

apne.c

net/apne: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

2014-04-12 01:59:38 -04:00