Dennis Zhou 0273ac349f blkcg: handle dying request_queue when associating a blkg
Between v3 [1] and v4 [2] of the blkg association series, the
association point moved from generic_make_request_checks(), which is
called after the request enters the queue, to bio_set_dev(), which is when
the bio is formed before submit_bio(). When the request_queue goes away,
the blkgs supporting the request_queue are destroyed and then the
q->root_blkg is set to %NULL.

This patch adds a %NULL check to blkg_tryget_closest() to prevent the
NPE caused by the above. It also adds a guard to see if the
request_queue is dying when creating a blkg to prevent creating a blkg
for a dead request_queue.

[1] https://lore.kernel.org/lkml/20180911184137.35897-1-dennisszhou@gmail.com/
[2] https://lore.kernel.org/lkml/20181126211946.77067-1-dennis@kernel.org/

Fixes: 5cdf2e3fea5e ("blkcg: associate blkg when associating a device")
Reported-and-tested-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Dennis Zhou <dennis@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2018-12-12 17:43:33 -07:00
..
2018-12-09 17:45:40 -07:00
2018-11-07 13:42:32 -07:00
2018-11-16 08:34:06 -07:00
2018-11-07 13:44:59 -07:00
2018-11-19 19:03:44 -07:00
2018-11-30 14:48:04 -07:00
2018-12-07 22:26:38 -07:00
2018-12-07 22:26:38 -07:00
2018-11-15 12:13:25 -07:00
2018-11-16 08:34:06 -07:00
2018-11-16 08:34:06 -07:00
2018-11-16 08:34:06 -07:00
2018-10-25 11:17:40 -06:00
2018-05-31 10:50:54 -04:00
2018-11-07 13:42:32 -07:00