iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/ipv6
History
Alexander Potapenko c23fb2c822 ipv6: addrlabel: fix infoleak when sending struct ifaddrlblmsg to network 
When copying a `struct ifaddrlblmsg` to the network, __ifal_reserved
remained uninitialized, resulting in a 1-byte infoleak:

  BUG: KMSAN: kernel-network-infoleak in __netdev_start_xmit ./include/linux/netdevice.h:4841
   __netdev_start_xmit ./include/linux/netdevice.h:4841
   netdev_start_xmit ./include/linux/netdevice.h:4857
   xmit_one net/core/dev.c:3590
   dev_hard_start_xmit+0x1dc/0x800 net/core/dev.c:3606
   __dev_queue_xmit+0x17e8/0x4350 net/core/dev.c:4256
   dev_queue_xmit ./include/linux/netdevice.h:3009
   __netlink_deliver_tap_skb net/netlink/af_netlink.c:307
   __netlink_deliver_tap+0x728/0xad0 net/netlink/af_netlink.c:325
   netlink_deliver_tap net/netlink/af_netlink.c:338
   __netlink_sendskb net/netlink/af_netlink.c:1263
   netlink_sendskb+0x1d9/0x200 net/netlink/af_netlink.c:1272
   netlink_unicast+0x56d/0xf50 net/netlink/af_netlink.c:1360
   nlmsg_unicast ./include/net/netlink.h:1061
   rtnl_unicast+0x5a/0x80 net/core/rtnetlink.c:758
   ip6addrlbl_get+0xfad/0x10f0 net/ipv6/addrlabel.c:628
   rtnetlink_rcv_msg+0xb33/0x1570 net/core/rtnetlink.c:6082
  ...
  Uninit was created at:
   slab_post_alloc_hook+0x118/0xb00 mm/slab.h:742
   slab_alloc_node mm/slub.c:3398
   __kmem_cache_alloc_node+0x4f2/0x930 mm/slub.c:3437
   __do_kmalloc_node mm/slab_common.c:954
   __kmalloc_node_track_caller+0x117/0x3d0 mm/slab_common.c:975
   kmalloc_reserve net/core/skbuff.c:437
   __alloc_skb+0x27a/0xab0 net/core/skbuff.c:509
   alloc_skb ./include/linux/skbuff.h:1267
   nlmsg_new ./include/net/netlink.h:964
   ip6addrlbl_get+0x490/0x10f0 net/ipv6/addrlabel.c:608
   rtnetlink_rcv_msg+0xb33/0x1570 net/core/rtnetlink.c:6082
   netlink_rcv_skb+0x299/0x550 net/netlink/af_netlink.c:2540
   rtnetlink_rcv+0x26/0x30 net/core/rtnetlink.c:6109
   netlink_unicast_kernel net/netlink/af_netlink.c:1319
   netlink_unicast+0x9ab/0xf50 net/netlink/af_netlink.c:1345
   netlink_sendmsg+0xebc/0x10f0 net/netlink/af_netlink.c:1921
  ...

This patch ensures that the reserved field is always initialized.

Reported-by: syzbot+3553517af6020c4f2813f1003fe76ef3cbffe98d@syzkaller.appspotmail.com
Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.")
Signed-off-by: Alexander Potapenko <glider@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2022-11-07 12:26:15 +00:00
..
ila
genetlink: start to validate reserved header bytes
2022-08-29 12:47:15 +01:00
netfilter
netfilter: rpfilter/fib: Set ->flowic_uid correctly for user namespaces.
2022-10-19 08:46:48 +02:00
addrconf_core.c
net: rename reference+tracking helpers
2022-06-09 21:52:55 -07:00
addrconf.c
Networking fixes for 6.1-rc2, including fixes from netfilter
2022-10-20 17:24:59 -07:00
addrlabel.c
ipv6: addrlabel: fix infoleak when sending struct ifaddrlblmsg to network
2022-11-07 12:26:15 +00:00
af_inet6.c
tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
2022-10-12 17:50:37 -07:00
ah6.c
xfrm: ah: add extack to ah_init_state, ah6_init_state
2022-09-29 07:17:59 +02:00
anycast.c
ipv6: fix memory leaks on IPV6_ADDRFORM path
2020-07-30 16:30:55 -07:00
calipso.c
cipso,calipso: resolve a number of problems with the DOI refcounts
2021-03-04 15:26:57 -08:00
datagram.c
udp: Update reuse->has_conns under reuseport_lock.
2022-10-18 10:17:18 +02:00
esp6_offload.c
esp: choose the correct inner protocol for GSO on inter address family tunnels
2022-08-29 10:20:58 +02:00
esp6.c
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next
2022-10-03 07:52:13 +01:00
exthdrs_core.c
…
exthdrs_offload.c
…
exthdrs.c
net: ipv6: add skb drop reasons to TLV parse
2022-04-13 13:09:57 +01:00
fib6_notifier.c
…
fib6_rules.c
ipv6: change fib6_rules_net_exit() to batch mode
2022-02-08 20:41:34 -08:00
fou6.c
net: Add MODULE_DESCRIPTION entries to network modules
2020-06-20 21:33:57 -07:00
icmp.c
icmp: Fix data-races around sysctl_icmp_echo_enable_probe.
2022-07-13 12:56:49 +01:00
inet6_connection_sock.c
lsm,selinux: pass flowi_common instead of flowi to the LSM hooks
2020-11-23 18:36:21 -05:00
inet6_hashtables.c
tcp: Access &tcp_hashinfo via net.
2022-09-20 10:21:49 -07:00
ioam6_iptunnel.c
ipv6: ioam: Insertion frequency in lwtunnel output
2022-02-04 20:24:45 -08:00
ioam6.c
genetlink: start to validate reserved header bytes
2022-08-29 12:47:15 +01:00
ip6_checksum.c
…
ip6_fib.c
ipv6: annotate accesses to fn->fn_sernum
2022-01-20 20:18:37 -08:00
ip6_flowlabel.c
treewide: use get_random_u32() when possible
2022-10-11 17:42:58 -06:00
ip6_gre.c
ipv6: ensure sane device mtu in tunnels
2022-10-25 16:04:22 -07:00
ip6_icmp.c
net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending
2021-02-23 11:29:52 -08:00
ip6_input.c
tcp/udp: Make early_demux back namespacified.
2022-07-15 18:50:35 -07:00
ip6_offload.c
net-next: skbuff: refactor pskb_pull
2022-09-30 12:31:46 +01:00
ip6_offload.h
…
ip6_output.c
net: shrink struct ubuf_info
2022-09-28 18:51:25 -07:00
ip6_tunnel.c
ipv6: ensure sane device mtu in tunnels
2022-10-25 16:04:22 -07:00
ip6_udp_tunnel.c
net: Make locking in sock_bindtoindex optional
2020-06-01 14:57:14 -07:00
ip6_vti.c
ip6_vti:Remove the space before the comma
2022-09-30 13:10:44 +01:00
ip6mr.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-09-22 13:02:10 -07:00
ipcomp6.c
xfrm: ipcomp: add extack to ipcomp{4,6}_init_state
2022-09-29 07:18:00 +02:00
ipv6_sockglue.c
tcp: Fix data races around icsk->icsk_af_ops.
2022-10-12 17:50:37 -07:00
Kconfig
crypto: lib - make the sha1 library optional
2022-07-15 16:43:59 +08:00
Makefile
net: ipv6: use ipv6-y directly instead of ipv6-objs
2021-09-28 13:13:40 +01:00
mcast_snoop.c
net: bridge: mcast: fix broken length + header check for MRDv6 Adv.
2021-04-27 14:02:06 -07:00
mcast.c
treewide: use prandom_u32_max() when possible, part 1
2022-10-11 17:42:55 -06:00
mip6.c
xfrm: mip6: add extack to mip6_destopt_init_state, mip6_rthdr_init_state
2022-09-29 07:18:01 +02:00
ndisc.c
net: fix potential refcount leak in ndisc_router_discovery()
2022-08-15 11:40:28 +01:00
netfilter.c
netfilter: Use l3mdev flow key when re-routing mangled packets
2022-05-16 13:03:29 +02:00
output_core.c
treewide: use get_random_u32() when possible
2022-10-11 17:42:58 -06:00
ping.c
inet: ping: fix recent breakage
2022-10-12 09:10:02 +01:00
proc.c
net: udp: introduce UDP_MIB_MEMERRORS for udp_mem
2020-11-09 15:34:44 -08:00
protocol.c
…
raw.c
raw: remove unused variables from raw6_icmp_error()
2022-06-22 18:48:08 -07:00
reassembly.c
net: ipv6: Handle delivery_time in ipv6 defrag
2022-03-03 14:38:48 +00:00
route.c
ipv6: fix WARNING in ip6_route_net_exit_late()
2022-11-02 20:47:14 -07:00
rpl_iptunnel.c
net: ipv6: rpl_iptunnel: simplify the return expression of rpl_do_srh()
2020-12-08 16:22:54 -08:00
rpl.c
net: ipv6: rpl*: Fix strange kerneldoc warnings due to bad header
2020-10-30 12:12:52 -07:00
seg6_hmac.c
net: ipv6: unexport __init-annotated seg6_hmac_net_init()
2022-06-28 21:23:30 -07:00
seg6_iptunnel.c
seg6: add support for SRv6 H.L2Encaps.Red behavior
2022-07-29 12:14:03 +01:00
seg6_local.c
seg6: add NEXT-C-SID support for SRv6 End behavior
2022-09-20 12:33:22 +02:00
seg6.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-09-08 18:38:30 +02:00
sit.c
ipv6: ensure sane device mtu in tunnels
2022-10-25 16:04:22 -07:00
syncookies.c
tcp: Fix data-races around sysctl_tcp_syncookies.
2022-07-18 12:21:54 +01:00
sysctl_net_ipv6.c
net: sysctl: introduce sysctl SYSCTL_THREE
2022-05-03 10:15:06 +02:00
tcp_ipv6.c
tcp: Fix data races around icsk->icsk_af_ops.
2022-10-12 17:50:37 -07:00
tcpv6_offload.c
net: move gro definitions to include/net/gro.h
2021-11-16 13:16:54 +00:00
tunnel6.c
tunnel6: add tunnel6_input_afinfo for ipip and ipv6 tunnels
2020-07-09 12:52:37 +02:00
udp_impl.h
tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
2022-10-12 17:50:37 -07:00
udp_offload.c
gro: remove rcu_read_lock/rcu_read_unlock from gro_receive handlers
2021-11-24 17:21:42 -08:00
udp.c
udp: advertise ipv6 udp support for msghdr::ubuf_info
2022-10-28 20:21:25 -07:00
udplite.c
tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
2022-10-12 17:50:37 -07:00
xfrm6_input.c
…
xfrm6_output.c
xfrm: fix tunnel model fragmentation behavior
2022-03-01 12:08:40 +01:00
xfrm6_policy.c
net: rename reference+tracking helpers
2022-06-09 21:52:55 -07:00
xfrm6_protocol.c
…
xfrm6_state.c
…
xfrm6_tunnel.c
xfrm: tunnel: add extack to ipip_init_state, xfrm6_tunnel_init_state
2022-09-29 07:18:00 +02:00