iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Chao Yu b2f423fda6 f2fs: fix to avoid use-after-free for cached IPU bio 
[ Upstream commit 5cdb422c839134273866208dad5360835ddb9794 ]

xfstest generic/019 reports a bug:

kernel BUG at mm/filemap.c:1619!
RIP: 0010:folio_end_writeback+0x8a/0x90
Call Trace:
 end_page_writeback+0x1c/0x60
 f2fs_write_end_io+0x199/0x420
 bio_endio+0x104/0x180
 submit_bio_noacct+0xa5/0x510
 submit_bio+0x48/0x80
 f2fs_submit_write_bio+0x35/0x300
 f2fs_submit_merged_ipu_write+0x2a0/0x2b0
 f2fs_write_single_data_page+0x838/0x8b0
 f2fs_write_cache_pages+0x379/0xa30
 f2fs_write_data_pages+0x30c/0x340
 do_writepages+0xd8/0x1b0
 __writeback_single_inode+0x44/0x370
 writeback_sb_inodes+0x233/0x4d0
 __writeback_inodes_wb+0x56/0xf0
 wb_writeback+0x1dd/0x2d0
 wb_workfn+0x367/0x4a0
 process_one_work+0x21d/0x430
 worker_thread+0x4e/0x3c0
 kthread+0x103/0x130
 ret_from_fork+0x2c/0x50

The root cause is: after cp_error is set, f2fs_submit_merged_ipu_write()
in f2fs_write_single_data_page() tries to flush IPU bio in cache, however
f2fs_submit_merged_ipu_write() missed to check validity of @bio parameter,
result in submitting random cached bio which belong to other IO context,
then it will cause use-after-free issue, fix it by adding additional
validity check.

Fixes: 0b20fcec8651 ("f2fs: cache global IPU bio")
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-05-17 11:47:51 +02:00
..
9p
9p: missing chunk of "fs/9p: Don't update file type when updating file attributes"
2022-06-22 14:13:12 +02:00
adfs
Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-10-24 12:26:05 -07:00
affs
affs: initialize fsdata in affs_truncate()
2023-02-01 08:23:11 +01:00
afs
afs: Fix lost servers_outstanding count
2023-01-14 10:16:22 +01:00
autofs
…
befs
…
bfs
bfs: don't use WARNING: string when it's just info.
2021-01-06 14:56:52 +01:00
btrfs
btrfs: fix fast csum implementation detection
2023-04-20 12:10:25 +02:00
cachefiles
fs/cachefiles: Remove wait_bit_key layout dependency
2021-03-30 14:32:07 +02:00
ceph
ceph: flush cap releases when the session is flushed
2023-02-15 17:22:26 +01:00
cifs
cifs: fix DFS traversal oops without CONFIG_CIFS_DFS_UPCALL
2023-04-05 11:23:49 +02:00
coda
coda: Avoid partial allocation of sig_inputArgs
2023-03-11 16:39:51 +01:00
configfs
configfs: fix possible memory leak in configfs_create_dir()
2023-01-14 10:15:37 +01:00
cramfs
…
crypto
fscrypt: fix keyring memory leak on mount failure
2022-11-10 18:14:25 +01:00
debugfs
debugfs: fix error when writing negative value to atomic_t debugfs file
2023-01-14 10:15:19 +01:00
devpts
fsnotify: fix fsnotify hooks in pseudo filesystems
2022-02-01 17:25:39 +01:00
dlm
fs: dlm: handle -EBUSY first in lock arg validation
2022-10-26 13:25:08 +02:00
ecryptfs
Revert "ecryptfs: replace BUG_ON with error handling code"
2021-05-26 12:06:55 +02:00
efivarfs
efivarfs: revert "fix memory leak in efivarfs_create()"
2020-11-25 16:55:02 +01:00
efs
…
erofs
erofs: fix potential overflow calculating xattr_isize
2023-05-17 11:47:38 +02:00
exfat
exfat: fix inode->i_blocks for non-512 byte sector size device
2023-03-11 16:39:56 +01:00
exportfs
…
ext2
ext2: Add more validity checks for inode counts
2022-08-21 15:15:28 +02:00
ext4
ext4: use ext4_journal_start/stop for fast commit transactions
2023-05-17 11:47:32 +02:00
f2fs
f2fs: fix to avoid use-after-free for cached IPU bio
2023-05-17 11:47:51 +02:00
fat
fat: add ratelimit to fat*_ent_bread()
2022-06-09 10:20:58 +02:00
freevxfs
…
fscache
fscache: Fix cookie key hashing
2021-09-18 13:40:15 +02:00
fuse
fuse: fix deadlock between atomic O_TRUNC and page invalidation
2023-04-26 11:27:41 +02:00
gfs2
gfs2: Always check inode size of inline inodes
2023-04-05 11:23:52 +02:00
hfs
hfs: fix missing hfs_bnode_get() in __hfs_bnode_create
2023-03-11 16:39:55 +01:00
hfsplus
fs: hfsplus: fix UAF issue in hfsplus_put_super
2023-03-11 16:39:56 +01:00
hostfs
hostfs: fix memory handling in follow_link()
2021-04-14 08:42:06 +02:00
hpfs
…
hugetlbfs
hugetlbfs: fix null-ptr-deref in hugetlbfs_parse_param()
2023-01-14 10:16:20 +01:00
iomap
xfs: use current->journal_info for detecting transaction recursion
2022-07-07 17:52:19 +02:00
isofs
isofs: Fix out of bound access for corrupted isofs image
2021-11-12 14:58:33 +01:00
jbd2
ext4: use ext4_journal_start/stop for fast commit transactions
2023-05-17 11:47:32 +02:00
jffs2
jffs2: correct logic when creating a hole in jffs2_write_begin
2023-03-22 13:30:01 +01:00
jfs
fs/jfs: fix shift exponent db_agl2size negative
2023-03-11 16:40:08 +01:00
kernfs
kernfs: fix use-after-free in __kernfs_remove
2022-11-03 23:57:50 +09:00
lockd
lockd: lockd server-side shouldn't set fl_ops
2021-09-18 13:40:30 +02:00
minix
minix: fix bug when opening a file with O_DIRECT
2022-04-13 21:01:01 +02:00
nfs
NFSv4: Fix hangs when recovering open state after a server reboot
2023-04-05 11:23:50 +02:00
nfs_common
nfs_common: need lock during iterate through the list
2020-12-30 11:53:45 +01:00
nfsd
NFSD: callback request does not use correct credential for AUTH_SYS
2023-04-20 12:10:22 +02:00
nilfs2
nilfs2: fix infinite loop in nilfs_mdt_get_block()
2023-05-17 11:47:36 +02:00
nls
…
notify
fsnotify: fix wrong lockdep annotations
2022-06-09 10:21:03 +02:00
ntfs
ntfs: check overflow when iterating ATTR_RECORDs
2022-11-25 17:45:57 +01:00
ocfs2
ocfs2: fix freeing uninitialized resource on ocfs2_dlm_shutdown
2023-04-20 12:10:24 +02:00
omfs
…
openpromfs
…
orangefs
orangefs: Fix kmemleak in orangefs_{kernel,client}_debug_init()
2023-01-14 10:16:20 +01:00
overlayfs
ovl: remove privs in ovl_fallocate()
2023-02-22 12:55:55 +01:00
proc
sysctl: add proc_dou8vec_minmax()
2023-04-20 12:10:26 +02:00
pstore
pstore/zone: Use GFP_ATOMIC to allocate zone buffer
2023-01-14 10:16:26 +01:00
qnx4
qnx4: work around gcc false positive warning bug
2021-09-30 10:11:08 +02:00
qnx6
…
quota
ext4: fix bug_on in __es_tree_search caused by bad quota inode
2023-01-14 10:16:38 +01:00
ramfs
…
reiserfs
reiserfs: Add security prefix to xattr name in reiserfs_security_write()
2023-05-17 11:47:34 +02:00
romfs
Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-10-24 12:26:05 -07:00
squashfs
revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"
2023-02-22 12:55:56 +01:00
sysfs
…
sysv
fs: sysv: Fix sysv_nblocks() returns wrong value
2023-01-14 10:15:22 +01:00
tracefs
tracefs: Only clobber mode/uid/gid on remount if asked
2022-09-20 12:38:31 +02:00
ubifs
ubifs: Free memory for tmpfile name
2023-05-17 11:47:35 +02:00
udf
udf: Fix off-by-one error when discarding preallocation
2023-03-17 08:45:07 +01:00
ufs
Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-10-24 12:26:05 -07:00
unicode
…
vboxsf
vboxfs: fix broken legacy mount signature checking
2021-10-17 10:43:33 +02:00
verity
fsverity: don't drop pagecache at end of FS_IOC_ENABLE_VERITY
2023-04-05 11:23:44 +02:00
xfs
xfs: drop submit side trans alloc for append ioends
2023-04-26 11:27:37 +02:00
zonefs
zonefs: Fix error message in zonefs_file_dio_append()
2023-04-05 11:23:51 +02:00
aio.c
aio: fix mremap after fork null-deref
2023-02-22 12:55:54 +01:00
anon_inodes.c
…
attr.c
attr: use consistent sgid stripping checks
2023-03-22 13:30:08 +01:00
bad_inode.c
…
binfmt_aout.c
…
binfmt_elf_fdpic.c
binfmt: Fix error return code in load_elf_fdpic_binary()
2023-01-14 10:16:26 +01:00
binfmt_elf.c
fs/binfmt_elf: Fix memory leak in load_elf_binary()
2022-11-03 23:57:49 +09:00
binfmt_em86.c
…
binfmt_flat.c
binfmt_flat: do not stop relocating GOT entries prematurely on riscv
2022-06-09 10:20:47 +02:00
binfmt_misc.c
binfmt_misc: fix shift-out-of-bounds in check_special_flags
2023-01-14 10:16:13 +01:00
binfmt_script.c
…
block_dev.c
block: fix a race between del_gendisk and BLKRRPART
2021-06-03 09:00:45 +02:00
buffer.c
mm: fs: initialize fsdata passed to write_begin/write_end interface
2022-11-25 17:45:56 +01:00
char_dev.c
chardev: fix error handling in cdev_device_add()
2023-01-14 10:15:59 +01:00
compat_binfmt_elf.c
…
coredump.c
coredump: Limit what can interrupt coredumps
2023-01-04 11:39:22 +01:00
d_path.c
…
dax.c
dax: fix cache flush on PMD-mapped pages
2022-06-09 10:21:16 +02:00
dcache.c
…
dcookies.c
…
direct-io.c
fs: direct-io: fix missing sdio->boundary
2021-04-14 08:41:58 +02:00
drop_caches.c
…
eventfd.c
eventfd: provide a eventfd_signal_mask() helper
2023-01-04 11:39:24 +01:00
eventpoll.c
eventpoll: add EPOLL_URING_WAKE poll wakeup flag
2023-01-04 11:39:24 +01:00
exec.c
exec: Copy oldsighand->action under spin-lock
2022-11-03 23:57:49 +09:00
fcntl.c
fcntl: fix potential deadlocks for &fown_struct.lock
2022-10-30 09:41:18 +01:00
fhandle.c
…
file_table.c
SUNRPC: Ensure we flush any closed sockets before xs_xprt_free()
2022-05-18 10:23:48 +02:00
file.c
fs: prevent out-of-bounds array speculation when closing a file descriptor
2023-03-17 08:45:05 +01:00
filesystems.c
…
fs_context.c
memcg: charge fs_context and legacy_fs_context
2022-02-08 18:30:36 +01:00
fs_parser.c
…
fs_pin.c
…
fs_struct.c
…
fs_types.c
…
fs-writeback.c
writeback, cgroup: fix null-ptr-deref write in bdi_split_work_to_wbs
2023-05-17 11:47:34 +02:00
fsopen.c
…
init.c
…
inode.c
attr: use consistent sgid stripping checks
2023-03-22 13:30:08 +01:00
internal.h
attr: add setattr_should_drop_sgid()
2023-03-22 13:30:07 +01:00
ioctl.c
fs: fix an infinite loop in iomap_fiemap
2022-05-25 09:17:54 +02:00
Kconfig
tmpfs: disallow CONFIG_TMPFS_INODE64 on alpha
2021-02-17 11:02:21 +01:00
Kconfig.binfmt
…
kernel_read_file.c
vfs: check fd has read access in kernel_read_file_from_fd()
2021-10-27 09:56:51 +02:00
libfs.c
libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value
2023-01-14 10:15:19 +01:00
locks.c
filelock: new helper: vfs_inode_has_locks
2023-01-14 10:16:47 +01:00
Makefile
io_uring: import 5.15-stable io_uring
2023-01-04 11:39:23 +01:00
mbcache.c
mbcache: Avoid nesting of cache->c_list_lock under bit locks
2023-01-14 10:16:50 +01:00
mount.h
…
mpage.c
…
namei.c
fs: move S_ISGID stripping into the vfs_*() helpers
2023-03-22 13:30:07 +01:00
namespace.c
fs: warn about impending deprecation of mandatory locks
2021-08-26 08:35:57 -04:00
no-block.c
…
nsfs.c
…
open.c
attr: use consistent sgid stripping checks
2023-03-22 13:30:08 +01:00
pipe.c
pipe: Fix missing lock in pipe_resize_ring()
2022-06-06 08:42:41 +02:00
pnode.c
pnode: terminate at peers of source
2023-01-14 10:16:27 +01:00
pnode.h
mount: fix mounting of detached mounts onto targets that reside on shared mounts
2021-03-17 17:06:13 +01:00
posix_acl.c
…
proc_namespace.c
proc mountinfo: make splice available again
2020-12-30 11:54:02 +01:00
read_write.c
vfs: fix copy_file_range() averts filesystem freeze protection
2022-12-19 12:27:30 +01:00
readdir.c
readdir: make sure to verify directory entry for legacy interfaces too
2021-04-21 13:00:54 +02:00
remap_range.c
fs/remap: constrain dedupe of EOF blocks
2022-07-21 21:20:01 +02:00
select.c
select: Fix indefinitely sleeping task in poll_schedule_timeout()
2022-01-29 10:26:11 +01:00
seq_file.c
seq_file: disallow extremely large seq buffer allocations
2021-07-20 16:05:59 +02:00
signalfd.c
io_uring: disable polling pollfree files
2022-09-05 10:28:58 +02:00
splice.c
Revert "fs: check FMODE_LSEEK to control internal pipe splicing"
2022-10-17 17:26:07 +02:00
stack.c
…
stat.c
stat: fix inconsistency between struct stat and struct compat_stat
2022-04-27 13:53:54 +02:00
statfs.c
…
super.c
fscrypt: fix keyring memory leak on mount failure
2022-11-10 18:14:25 +01:00
sync.c
vfs: make sync_filesystem return errors from ->sync_fs
2022-08-31 17:15:14 +02:00
timerfd.c
…
userfaultfd.c
userfaultfd: open userfaultfds with O_RDONLY
2022-10-26 13:25:17 +02:00
utimes.c
…
xattr.c
fs: don't audit the capability check in simple_xattr_list()
2023-01-14 10:15:16 +01:00