Dominique Martinet 491fc097e3 9p locks: fix glock.client_id leak in do_lock ...

[ Upstream commit b4dc44b3cac9e8327e0655f530ed0c46f2e6214c ]

the 9p client code overwrites our glock.client_id pointing to a static
buffer by an allocated string holding the network provided value which
we do not care about; free and reset the value as appropriate.

This is almost identical to the leak in v9fs_file_getlock() fixed by
Al Viro in commit ce85dd58ad5a6 ("9p: we are leaking glock.client_id
in v9fs_file_getlock()"), which was returned as an error by a coverity
false positive -- while we are here attempt to make the code slightly
more robust to future change of the net/9p/client code and hopefully
more clear to coverity that there is no problem.

Link: http://lkml.kernel.org/r/1536339057-21974-5-git-send-email-asmadeus@codewreck.org
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-11-21 09:24:04 +01:00

..

acl.c

9p: fix a potential acl leak

2017-02-22 16:41:27 -08:00

acl.h

9p: switch v9fs_set_create_acl() to inode+fid, do it before d_instantiate()

2013-02-26 02:46:07 -05:00

cache.c

fscache: remove unused ->now_uncached callback

2017-09-06 17:27:26 -07:00

cache.h

fs: 9p: cache.h: Add #define of include guard

2015-11-11 02:19:50 -05:00

fid.c

9p: constify ->d_name handling

2017-01-12 04:01:17 -05:00

fid.h

9p: use clone_fid()

2016-08-03 11:12:12 -04:00

Kconfig

fs/9p: xattr: add trusted and security namespaces

2013-07-07 22:02:18 -05:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

v9fs_vfs.h

9p: switch p9_client_read() to passing struct iov_iter *

2015-04-11 22:28:27 -04:00

v9fs.c

9p: Implement show_options

2017-07-11 06:08:58 -04:00

v9fs.h

9p: Implement show_options

2017-07-11 06:08:58 -04:00

vfs_addr.c

9p: set page uptodate when required in write_end()

2017-10-11 09:30:08 -07:00

vfs_dentry.c

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15 15:06:57 -04:00

vfs_dir.c

9p: switch to ->iterate_shared()

2016-05-09 11:41:16 -04:00

vfs_file.c

9p locks: fix glock.client_id leak in do_lock

2018-11-21 09:24:04 +01:00

vfs_inode_dotl.c

fs/9p: Compare qid.path in v9fs_test_inode

2017-11-30 08:40:49 +00:00

vfs_inode.c

fs/9p: Compare qid.path in v9fs_test_inode

2017-11-30 08:40:49 +00:00

vfs_super.c

9p: Implement show_options

2017-07-11 06:08:58 -04:00

xattr.c

fs/9p/xattr.c: catch the error of p9_client_clunk when setting xattr failed

2018-09-09 19:55:55 +02:00

xattr.h

9p: xattr simplifications

2015-11-13 20:34:33 -05:00