8210f496c3
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. meson_card_remove() returned zero unconditionally. Make it return void instead and convert all users to struct platform_device::remove_new(). Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com> Link: https://lore.kernel.org/r/20231013221945.1489203-14-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
144 lines
3.6 KiB
C
144 lines
3.6 KiB
C
// SPDX-License-Identifier: (GPL-2.0 OR MIT)
|
|
//
|
|
// Copyright (c) 2020 BayLibre, SAS.
|
|
// Author: Jerome Brunet <jbrunet@baylibre.com>
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/of_platform.h>
|
|
#include <sound/soc.h>
|
|
#include <sound/soc-dai.h>
|
|
|
|
#include "meson-card.h"
|
|
|
|
struct gx_dai_link_i2s_data {
|
|
unsigned int mclk_fs;
|
|
};
|
|
|
|
/*
|
|
* Base params for the codec to codec links
|
|
* Those will be over-written by the CPU side of the link
|
|
*/
|
|
static const struct snd_soc_pcm_stream codec_params = {
|
|
.formats = SNDRV_PCM_FMTBIT_S24_LE,
|
|
.rate_min = 5525,
|
|
.rate_max = 192000,
|
|
.channels_min = 1,
|
|
.channels_max = 8,
|
|
};
|
|
|
|
static int gx_card_i2s_be_hw_params(struct snd_pcm_substream *substream,
|
|
struct snd_pcm_hw_params *params)
|
|
{
|
|
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
|
|
struct meson_card *priv = snd_soc_card_get_drvdata(rtd->card);
|
|
struct gx_dai_link_i2s_data *be =
|
|
(struct gx_dai_link_i2s_data *)priv->link_data[rtd->num];
|
|
|
|
return meson_card_i2s_set_sysclk(substream, params, be->mclk_fs);
|
|
}
|
|
|
|
static const struct snd_soc_ops gx_card_i2s_be_ops = {
|
|
.hw_params = gx_card_i2s_be_hw_params,
|
|
};
|
|
|
|
static int gx_card_parse_i2s(struct snd_soc_card *card,
|
|
struct device_node *node,
|
|
int *index)
|
|
{
|
|
struct meson_card *priv = snd_soc_card_get_drvdata(card);
|
|
struct snd_soc_dai_link *link = &card->dai_link[*index];
|
|
struct gx_dai_link_i2s_data *be;
|
|
|
|
/* Allocate i2s link parameters */
|
|
be = devm_kzalloc(card->dev, sizeof(*be), GFP_KERNEL);
|
|
if (!be)
|
|
return -ENOMEM;
|
|
priv->link_data[*index] = be;
|
|
|
|
/* Setup i2s link */
|
|
link->ops = &gx_card_i2s_be_ops;
|
|
link->dai_fmt = meson_card_parse_daifmt(node, link->cpus->of_node);
|
|
|
|
of_property_read_u32(node, "mclk-fs", &be->mclk_fs);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int gx_card_cpu_identify(struct snd_soc_dai_link_component *c,
|
|
char *match)
|
|
{
|
|
if (of_device_is_compatible(c->of_node, DT_PREFIX "aiu")) {
|
|
if (strstr(c->dai_name, match))
|
|
return 1;
|
|
}
|
|
|
|
/* dai not matched */
|
|
return 0;
|
|
}
|
|
|
|
static int gx_card_add_link(struct snd_soc_card *card, struct device_node *np,
|
|
int *index)
|
|
{
|
|
struct snd_soc_dai_link *dai_link = &card->dai_link[*index];
|
|
struct snd_soc_dai_link_component *cpu;
|
|
int ret;
|
|
|
|
cpu = devm_kzalloc(card->dev, sizeof(*cpu), GFP_KERNEL);
|
|
if (!cpu)
|
|
return -ENOMEM;
|
|
|
|
dai_link->cpus = cpu;
|
|
dai_link->num_cpus = 1;
|
|
|
|
ret = meson_card_parse_dai(card, np, dai_link->cpus);
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (gx_card_cpu_identify(dai_link->cpus, "FIFO"))
|
|
return meson_card_set_fe_link(card, dai_link, np, true);
|
|
|
|
ret = meson_card_set_be_link(card, dai_link, np);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* Or apply codec to codec params if necessary */
|
|
if (gx_card_cpu_identify(dai_link->cpus, "CODEC CTRL")) {
|
|
dai_link->c2c_params = &codec_params;
|
|
dai_link->num_c2c_params = 1;
|
|
} else {
|
|
dai_link->no_pcm = 1;
|
|
snd_soc_dai_link_set_capabilities(dai_link);
|
|
/* Check if the cpu is the i2s encoder and parse i2s data */
|
|
if (gx_card_cpu_identify(dai_link->cpus, "I2S Encoder"))
|
|
ret = gx_card_parse_i2s(card, np, index);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static const struct meson_card_match_data gx_card_match_data = {
|
|
.add_link = gx_card_add_link,
|
|
};
|
|
|
|
static const struct of_device_id gx_card_of_match[] = {
|
|
{
|
|
.compatible = "amlogic,gx-sound-card",
|
|
.data = &gx_card_match_data,
|
|
}, {}
|
|
};
|
|
MODULE_DEVICE_TABLE(of, gx_card_of_match);
|
|
|
|
static struct platform_driver gx_card_pdrv = {
|
|
.probe = meson_card_probe,
|
|
.remove_new = meson_card_remove,
|
|
.driver = {
|
|
.name = "gx-sound-card",
|
|
.of_match_table = gx_card_of_match,
|
|
},
|
|
};
|
|
module_platform_driver(gx_card_pdrv);
|
|
|
|
MODULE_DESCRIPTION("Amlogic GX ALSA machine driver");
|
|
MODULE_AUTHOR("Jerome Brunet <jbrunet@baylibre.com>");
|
|
MODULE_LICENSE("GPL v2");
|