linux/drivers/staging/rtl8723bs
Hans de Goede 05cbcc415c staging: rtl8723bs: Fix key-store index handling
There are 2 issues with the key-store index handling

1. The non WEP key stores can store keys with indexes 0 - BIP_MAX_KEYID,
   this means that they should be an array with BIP_MAX_KEYID + 1
   entries. But some of the arrays where just BIP_MAX_KEYID entries
   big. While one other array was hardcoded to a size of 6 entries,
   instead of using the BIP_MAX_KEYID define.

2. The rtw_cfg80211_set_encryption() and wpa_set_encryption() functions
   index check where checking that the passed in key-index would fit
   inside both the WEP key store (which only has 4 entries) as well as
   in the non WEP key stores. This breaks any attempts to set non WEP
   keys with index 4 or 5.

Issue 2. specifically breaks wifi connection with some access points
which advertise PMF support. Without this fix connecting to these
access points fails with the following wpa_supplicant messages:

 nl80211: kernel reports: key addition failed
 wlan0: WPA: Failed to configure IGTK to the driver
 wlan0: RSN: Failed to configure IGTK
 wlan0: CTRL-EVENT-DISCONNECTED bssid=... reason=1 locally_generated=1

Fix 1. by using the right size for the key-stores. After this 2. can
safely be fixed by checking the right max-index value depending on the
used algorithm, fixing wifi not working with some PMF capable APs.

Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20230306153512.162104-1-hdegoede@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-03-08 17:58:44 +01:00
..
core staging: rtl8723bs: Use min/max macros for variable comparison 2022-11-08 16:26:10 +01:00
hal staging: rtl8723bs: hal: Fix codespell-reported spelling mistakes 2023-01-17 19:27:14 +01:00
include staging: rtl8723bs: Fix key-store index handling 2023-03-08 17:58:44 +01:00
os_dep staging: rtl8723bs: Fix key-store index handling 2023-03-08 17:58:44 +01:00
Kconfig staging: rtl8723bs: fix unmet dependency on CRYPTO for CRYPTO_LIB_ARC4 2021-10-30 11:12:50 +02:00
Makefile staging: rtl8723bs: delete rtw_odm.c and rtw_odm.h 2022-09-09 09:49:47 +02:00
TODO staging: rtl8723bs: remove item from TODO list 2021-06-24 14:43:46 +02:00