Chen Zhongjin
74ac7c9ee2
configfs: fix possible memory leak in configfs_create_dir() ...
[ Upstream commit c65234b283a65cfbfc94619655e820a5e55199eb ]
kmemleak reported memory leaks in configfs_create_dir():
unreferenced object 0xffff888009f6af00 (size 192):
comm "modprobe", pid 3777, jiffies 4295537735 (age 233.784s)
backtrace:
kmem_cache_alloc (mm/slub.c:3250 mm/slub.c:3256 mm/slub.c:3263 mm/slub.c:3273)
new_fragment (./include/linux/slab.h:600 fs/configfs/dir.c:163)
configfs_register_subsystem (fs/configfs/dir.c:1857)
basic_write (drivers/hwtracing/stm/p_basic.c:14) stm_p_basic
do_one_initcall (init/main.c:1296)
do_init_module (kernel/module/main.c:2455)
...
unreferenced object 0xffff888003ba7180 (size 96):
comm "modprobe", pid 3777, jiffies 4295537735 (age 233.784s)
backtrace:
kmem_cache_alloc (mm/slub.c:3250 mm/slub.c:3256 mm/slub.c:3263 mm/slub.c:3273)
configfs_new_dirent (./include/linux/slab.h:723 fs/configfs/dir.c:194)
configfs_make_dirent (fs/configfs/dir.c:248)
configfs_create_dir (fs/configfs/dir.c:296)
configfs_attach_group.isra.28 (fs/configfs/dir.c:816 fs/configfs/dir.c:852)
configfs_register_subsystem (fs/configfs/dir.c:1881)
basic_write (drivers/hwtracing/stm/p_basic.c:14) stm_p_basic
do_one_initcall (init/main.c:1296)
do_init_module (kernel/module/main.c:2455)
...
This is because the refcount is not correct in configfs_make_dirent().
For normal stage, the refcount is changing as:
configfs_register_subsystem()
configfs_create_dir()
configfs_make_dirent()
configfs_new_dirent() # set s_count = 1
dentry->d_fsdata = configfs_get(sd); # s_count = 2
...
configfs_unregister_subsystem()
configfs_remove_dir()
remove_dir()
configfs_remove_dirent() # s_count = 1
dput() ...
*dentry_unlink_inode()*
configfs_d_iput() # s_count = 0, release
However, if we failed in configfs_create():
configfs_register_subsystem()
configfs_create_dir()
configfs_make_dirent() # s_count = 2
...
configfs_create() # fail
->out_remove:
configfs_remove_dirent(dentry)
configfs_put(sd) # s_count = 1
return PTR_ERR(inode);
There is no inode in the error path, so the configfs_d_iput() is lost
and makes sd and fragment memory leaked.
To fix this, when we failed in configfs_create(), manually call
configfs_put(sd) to keep the refcount correct.
Fixes: 7063fbf22611 ("[PATCH] configfs: User-driven configuration filesystem")
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-01-14 10:15:37 +01:00
2022-06-22 14:13:12 +02:00
2020-10-24 12:26:05 -07:00
2021-03-04 11:38:37 +01:00
2022-12-08 11:23:56 +01:00
2020-10-16 11:11:22 -07:00
2020-09-18 16:45:50 -04:00
2021-01-06 14:56:52 +01:00
2022-12-14 11:31:53 +01:00
2021-03-30 14:32:07 +02:00
2022-12-02 17:40:03 +01:00
2022-11-25 17:45:48 +01:00
2023-01-14 10:15:37 +01:00
2020-09-18 16:45:50 -04:00
2022-11-10 18:14:25 +01:00
2023-01-14 10:15:19 +01:00
2022-02-01 17:25:39 +01:00
2022-10-26 13:25:08 +02:00
2021-05-26 12:06:55 +02:00
2020-11-25 16:55:02 +01:00
2020-09-18 16:45:50 -04:00
2022-08-21 15:15:35 +02:00
2022-06-06 08:42:42 +02:00
2022-08-21 15:15:28 +02:00
2022-12-02 17:40:02 +01:00
2022-11-10 18:14:29 +01:00
2022-06-09 10:20:58 +02:00
2021-09-18 13:40:15 +02:00
2022-12-19 12:27:31 +01:00
2022-11-25 17:45:56 +01:00
2023-01-14 10:15:22 +01:00
2021-05-19 10:13:10 +02:00
2021-04-14 08:42:06 +02:00
2020-09-18 16:45:50 -04:00
2022-04-27 13:53:54 +02:00
2022-07-07 17:52:19 +02:00
2021-11-12 14:58:33 +01:00
2022-10-26 13:25:13 +02:00
2022-06-14 18:32:35 +02:00
2022-06-09 10:20:57 +02:00
2022-11-03 23:57:50 +09:00
2021-09-18 13:40:30 +02:00
2022-04-13 21:01:01 +02:00
2023-01-14 10:15:34 +01:00
2020-12-30 11:53:45 +01:00
2023-01-14 10:15:18 +01:00
2022-12-08 11:23:57 +01:00
2022-06-09 10:21:03 +02:00
2022-11-25 17:45:57 +01:00
2023-01-14 10:15:19 +01:00
2020-09-22 23:39:45 -04:00
2022-01-20 09:17:50 +01:00
2022-08-21 15:15:23 +02:00
2023-01-04 11:39:24 +01:00
2023-01-14 10:15:14 +01:00
2021-09-30 10:11:08 +02:00
2020-09-18 16:45:50 -04:00
2022-10-26 13:25:09 +02:00
2020-10-16 11:11:22 -07:00
2021-08-12 13:22:19 +02:00
2020-10-24 12:26:05 -07:00
2021-05-19 10:13:10 +02:00
2020-10-02 12:02:30 +02:00
2023-01-14 10:15:22 +01:00
2022-09-20 12:38:31 +02:00
2022-04-13 21:00:53 +02:00
2022-12-21 17:32:06 +01:00
2020-10-24 12:26:05 -07:00
2021-10-17 10:43:33 +02:00
2021-10-06 15:55:46 +02:00
2022-09-28 11:10:29 +02:00
2022-12-02 17:40:05 +01:00
2021-12-14 11:32:40 +01:00
2022-08-21 15:15:22 +02:00
2022-04-08 14:40:44 +02:00
2022-11-03 23:57:49 +09:00
2022-06-09 10:20:47 +02:00
2021-03-17 17:06:35 +01:00
2021-06-03 09:00:45 +02:00
2022-11-25 17:45:56 +01:00
2023-01-04 11:39:22 +01:00
2020-10-14 14:54:45 -07:00
2022-06-09 10:21:16 +02:00
2021-04-14 08:41:58 +02:00
2023-01-04 11:39:24 +01:00
2023-01-04 11:39:24 +01:00
2022-11-03 23:57:49 +09:00
2022-10-30 09:41:18 +01:00
2022-05-18 10:23:48 +02:00
2023-01-04 11:39:18 +01:00
2022-02-08 18:30:36 +01:00
2020-10-13 18:38:27 -07:00
2022-06-09 10:21:22 +02:00
2022-10-15 07:55:51 +02:00
2023-01-04 11:39:18 +01:00
2022-05-25 09:17:54 +02:00
2021-02-17 11:02:21 +01:00
2021-10-27 09:56:51 +02:00
2023-01-14 10:15:19 +01:00
2021-03-20 10:43:44 +01:00
2023-01-04 11:39:23 +01:00
2023-01-04 11:39:18 +01:00
2021-08-26 08:35:57 -04:00
2023-01-04 11:39:17 +01:00
2022-06-06 08:42:41 +02:00
2021-03-17 17:06:13 +01:00
2020-12-30 11:54:02 +01:00
2022-12-19 12:27:30 +01:00
2021-04-21 13:00:54 +02:00
2022-07-21 21:20:01 +02:00
2022-01-29 10:26:11 +01:00
2021-07-20 16:05:59 +02:00
2022-09-05 10:28:58 +02:00
2022-10-17 17:26:07 +02:00
2022-04-27 13:53:54 +02:00
2022-11-10 18:14:25 +01:00
2022-08-31 17:15:14 +02:00
2022-10-26 13:25:17 +02:00
2023-01-14 10:15:16 +01:00
74ac7c9ee2