linux/include/asm-generic
Arnd Bergmann 0652035a57 asm-generic: unaligned: remove byteshift helpers
In theory, compilers should be able to work this out themselves so we
can use a simpler version based on the swab() helpers.

I have verified that this works on all supported compiler versions
(gcc-4.9 and up, clang-10 and up). Looking at the object code produced by
gcc-11, I found that the impact is mostly a change in inlining decisions
that lead to slightly larger code.

In other cases, this version produces explicit byte swaps in place of
separate byte access, or comparing against pre-swapped constants.

While the source code is clearly simpler, I have not seen an indication
of the new version actually producing better code on Arm, so maybe
we want to skip this after all. From what I can tell, gcc recognizes
the byteswap pattern in the byteshift.h header and can turn it into
explicit instructions, but it does not turn a __builtin_bswap32() back
into individual bytes when that would result in better output, e.g.
when storing a byte-reversed constant.

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
2021-05-10 17:50:47 +02:00
..
2017-11-15 13:28:48 -08:00
2021-04-08 16:04:20 -07:00
2021-05-07 00:26:34 -07:00
2021-02-24 16:32:23 -08:00
2020-01-23 10:41:16 -08:00
2021-01-20 09:30:45 +01:00
2018-03-09 23:19:56 +01:00
2018-05-07 07:15:41 +02:00
2021-04-08 16:04:20 -07:00