Ming Lei 06582bc86d block: loop:use kstatfs.f_bsize of backing file to set discard granularity
If backing file's filesystem has implemented ->fallocate(), we think the
loop device can support discard, then pass sb->s_blocksize as
discard_granularity. However, some underlying FS, such as overlayfs,
doesn't set sb->s_blocksize, and causes discard_granularity to be set as
zero, then the warning in __blkdev_issue_discard() is triggered.

Christoph suggested to pass kstatfs.f_bsize as discard granularity, and
this way is fine because kstatfs.f_bsize means 'Optimal transfer block
size', which still matches with definition of discard granularity.

So fix the issue by setting discard_granularity as kstatfs.f_bsize if it
is available, otherwise claims discard isn't supported.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Vivek Goyal <vgoyal@redhat.com>
Reported-by: Pei Zhang <pezhang@redhat.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20220126035830.296465-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-02-11 15:10:49 -07:00
..
2022-01-23 06:20:44 +02:00
2021-11-29 06:35:21 -07:00
2022-01-17 07:19:40 -07:00
2021-12-16 10:57:04 -07:00
2021-12-16 10:57:04 -07:00
2021-11-09 11:24:08 -08:00
2021-11-29 06:38:35 -07:00
2021-11-29 06:38:35 -07:00
2021-11-29 06:38:35 -07:00
2022-01-12 10:26:52 -08:00
2021-11-29 06:38:35 -07:00