linux/drivers/usb
Julia Lawall 06e182911d USB: xhci-mem.c: introduce missing kfree
Error handling code following a kzalloc should free the allocated data.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 11:55:26 -08:00
..
atm tree-wide: fix assorted typos all over the place 2009-12-04 15:39:55 +01:00
c67x00 usb/c67x00 endianness annotations 2008-06-04 08:06:01 -07:00
class USB: usbtmc: repeat usb_bulk_msg until whole message is transfered 2009-12-11 11:55:25 -08:00
core USB: add remove_id sysfs attr for usb drivers 2009-12-11 11:55:26 -08:00
early USB: ehci-dbgp: errata for EHCI debug/host controller synchronization 2009-09-23 06:46:38 -07:00
gadget USB: g_multi kconfig: fix depends and help text 2009-12-11 11:55:26 -08:00
host USB: xhci-mem.c: introduce missing kfree 2009-12-11 11:55:26 -08:00
image USB: remove unneeded printks from microtek driver 2009-09-23 06:46:34 -07:00
misc usbtest: make module param pattern writeable 2009-12-11 11:55:22 -08:00
mon USB: add scatter-gather support to usbmon 2009-12-11 11:55:20 -08:00
musb USB: musb_gadget: remove pointless loop 2009-12-11 11:55:25 -08:00
otg USB: twl4030: Enable USB regulators before enabling USB charging 2009-12-11 11:55:25 -08:00
serial USB: option: add pid for ZTE 2009-12-11 11:55:26 -08:00
storage USB: usb-storage: fix bug in fill_inquiry 2009-12-11 11:55:26 -08:00
wusbcore USB: wusb: correctly check size of security descriptor. 2009-12-11 11:55:26 -08:00
Kconfig USB: ehci: Allow EHCI to be built on OMAP3 2009-12-11 11:55:20 -08:00
Makefile USB OTG: Add generic driver for ULPI OTG transceiver 2009-12-11 11:55:16 -08:00
README
usb-skeleton.c USB: skeleton: Correct use of ! and & 2009-12-11 11:55:14 -08:00

To understand all the Linux-USB framework, you'll use these resources:

    * This source code.  This is necessarily an evolving work, and
      includes kerneldoc that should help you get a current overview.
      ("make pdfdocs", and then look at "usb.pdf" for host side and
      "gadget.pdf" for peripheral side.)  Also, Documentation/usb has
      more information.

    * The USB 2.0 specification (from www.usb.org), with supplements
      such as those for USB OTG and the various device classes.
      The USB specification has a good overview chapter, and USB
      peripherals conform to the widely known "Chapter 9".

    * Chip specifications for USB controllers.  Examples include
      host controllers (on PCs, servers, and more); peripheral
      controllers (in devices with Linux firmware, like printers or
      cell phones); and hard-wired peripherals like Ethernet adapters.

    * Specifications for other protocols implemented by USB peripheral
      functions.  Some are vendor-specific; others are vendor-neutral
      but just standardized outside of the www.usb.org team.

Here is a list of what each subdirectory here is, and what is contained in
them.

core/		- This is for the core USB host code, including the
		  usbfs files and the hub class driver ("khubd").

host/		- This is for USB host controller drivers.  This
		  includes UHCI, OHCI, EHCI, and others that might
		  be used with more specialized "embedded" systems.

gadget/		- This is for USB peripheral controller drivers and
		  the various gadget drivers which talk to them.


Individual USB driver directories.  A new driver should be added to the
first subdirectory in the list below that it fits into.

image/		- This is for still image drivers, like scanners or
		  digital cameras.
../input/	- This is for any driver that uses the input subsystem,
		  like keyboard, mice, touchscreens, tablets, etc.
../media/	- This is for multimedia drivers, like video cameras,
		  radios, and any other drivers that talk to the v4l
		  subsystem.
../net/		- This is for network drivers.
serial/		- This is for USB to serial drivers.
storage/	- This is for USB mass-storage drivers.
class/		- This is for all USB device drivers that do not fit
		  into any of the above categories, and work for a range
		  of USB Class specified devices. 
misc/		- This is for all USB device drivers that do not fit
		  into any of the above categories.