iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/block
History
Yu Kuai 077a403354 block: don't allow a disk link holder to itself 
After creating a dm device, then user can reload such dm with itself,
and dead loop will be triggered because dm keep looking up to itself.

Test procedures:

1) dmsetup create test --table "xxx sda", assume dm-0 is created
2) dmsetup suspend test
3) dmsetup reload test --table "xxx dm-0"
4) dmsetup resume test

Test result:

BUG: TASK stack guard page was hit at 00000000736a261f (stack is 000000008d12c88d..00000000c8dd82d5)
stack guard page: 0000 [#1] PREEMPT SMP
CPU: 29 PID: 946 Comm: systemd-udevd Not tainted 6.1.0-rc3-next-20221101-00006-g17640ca3b0ee #1295
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS ?-20190727_073836-buildvm-ppc64le-16.ppc.fedoraproject.org-3.fc31 04/01/2014
RIP: 0010:dm_prepare_ioctl+0xf/0x1e0
Code: da 48 83 05 4a 7c 99 0b 01 41 89 c4 eb cd e8 b8 1f 40 00 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 41 57 48 83 05 a1 5a 99 0b 01 <41> 56 49 89 d6 41 55 4c 8d af 90 02 00 00 9
RSP: 0018:ffffc90002090000 EFLAGS: 00010206
RAX: ffff8881049d6800 RBX: ffff88817e589000 RCX: 0000000000000000
RDX: ffffc90002090010 RSI: ffffc9000209001c RDI: ffff88817e589000
RBP: 00000000484a101d R08: 0000000000000000 R09: 0000000000000007
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000005331
R13: 0000000000005331 R14: 0000000000000000 R15: 0000000000000000
FS:  00007fddf9609200(0000) GS:ffff889fbfd40000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffc9000208fff8 CR3: 0000000179043000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 dm_blk_ioctl+0x50/0x1c0
 ? dm_prepare_ioctl+0xe0/0x1e0
 dm_blk_ioctl+0x88/0x1c0
 dm_blk_ioctl+0x88/0x1c0
 ......(a lot of same lines)
 dm_blk_ioctl+0x88/0x1c0
 dm_blk_ioctl+0x88/0x1c0
 blkdev_ioctl+0x184/0x3e0
 __x64_sys_ioctl+0xa3/0x110
 do_syscall_64+0x35/0x80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fddf7306577
Code: b3 66 90 48 8b 05 11 89 2c 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d e1 88 8
RSP: 002b:00007ffd0b2ec318 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00005634ef478320 RCX: 00007fddf7306577
RDX: 0000000000000000 RSI: 0000000000005331 RDI: 0000000000000007
RBP: 0000000000000007 R08: 00005634ef4843e0 R09: 0000000000000080
R10: 00007fddf75cfb38 R11: 0000000000000246 R12: 00000000030d4000
R13: 0000000000000000 R14: 0000000000000000 R15: 00005634ef48b800
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:dm_prepare_ioctl+0xf/0x1e0
Code: da 48 83 05 4a 7c 99 0b 01 41 89 c4 eb cd e8 b8 1f 40 00 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 41 57 48 83 05 a1 5a 99 0b 01 <41> 56 49 89 d6 41 55 4c 8d af 90 02 00 00 9
RSP: 0018:ffffc90002090000 EFLAGS: 00010206
RAX: ffff8881049d6800 RBX: ffff88817e589000 RCX: 0000000000000000
RDX: ffffc90002090010 RSI: ffffc9000209001c RDI: ffff88817e589000
RBP: 00000000484a101d R08: 0000000000000000 R09: 0000000000000007
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000005331
R13: 0000000000005331 R14: 0000000000000000 R15: 0000000000000000
FS:  00007fddf9609200(0000) GS:ffff889fbfd40000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffc9000208fff8 CR3: 0000000179043000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Kernel panic - not syncing: Fatal exception in interrupt
Kernel Offset: disabled
---[ end Kernel panic - not syncing: Fatal exception in interrupt ]---

Fix the problem by forbidding a disk to create link to itself.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20221115141054.1051801-11-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-11-16 15:19:56 -07:00
..
partitions
block: don't add partitions if GD_SUPPRESS_PART_SCAN is set
2022-09-03 11:29:03 -06:00
badblocks.c
block/badblocks: Remove redundant assignments
2022-04-23 07:15:26 -06:00
bdev.c
vfs: support STATX_DIOALIGN on block devices
2022-09-11 19:47:12 -05:00
bfq-cgroup.c
block, bfq: don't declare 'bfqd' as type 'void *' in bfq_group
2022-11-01 20:10:55 -06:00
bfq-iosched.c
bfq: ignore oom_bfqq in bfq_check_waker
2022-11-09 12:42:26 -07:00
bfq-iosched.h
block, bfq: don't declare 'bfqd' as type 'void *' in bfq_group
2022-11-01 20:10:55 -06:00
bfq-wf2q.c
block, bfq: don't declare 'bfqd' as type 'void *' in bfq_group
2022-11-01 20:10:55 -06:00
bio-integrity.c
block: pass struct queue_limits to the bio splitting helpers
2022-08-02 21:08:53 -06:00
bio.c
bio: shrink max number of pcpu cached bios
2022-11-16 09:44:26 -07:00
blk-cgroup-fc-appid.c
cgroup: Homogenize cgroup_get_from_id() return value
2022-08-26 10:57:41 -10:00
blk-cgroup-rwstat.c
blk-cgroup: Fix the recursive blkg rwstat
2021-03-05 11:32:15 -07:00
blk-cgroup-rwstat.h
block: Use the new blk_opf_t type
2022-07-14 12:14:30 -06:00
blk-cgroup.c
blk-cgroup: don't update the blkg lookup hint in blkg_conf_prep
2022-09-27 11:50:05 -06:00
blk-cgroup.h
blk-cgroup: pass a gendisk to blkcg_init_queue and blkcg_exit_queue
2022-09-26 19:09:31 -06:00
blk-core.c
blk-mq: move the srcu_struct used for quiescing to the tagset
2022-11-02 08:35:34 -06:00
blk-crypto-fallback.c
treewide: use get_random_bytes() when possible
2022-10-11 17:42:58 -06:00
blk-crypto-internal.h
blk-crypto: show crypto capabilities in sysfs
2022-02-28 06:40:23 -07:00
blk-crypto-profile.c
blk-crypto: remove blk_crypto_unregister()
2021-11-29 06:38:51 -07:00
blk-crypto-sysfs.c
blk-crypto: show crypto capabilities in sysfs
2022-02-28 06:40:23 -07:00
blk-crypto.c
blk-crypto: show crypto capabilities in sysfs
2022-02-28 06:40:23 -07:00
blk-flush.c
block: change request end_io handler to pass back a return value
2022-09-30 07:49:09 -06:00
blk-ia-ranges.c
block: simplify disk_set_independent_access_ranges
2022-06-29 08:36:46 -06:00
blk-integrity.c
blk-crypto: remove blk_crypto_unregister()
2021-11-29 06:38:51 -07:00
blk-ioc.c
block: fix default IO priority handling again
2022-06-27 06:29:12 -06:00
blk-iocost.c
blk-iocost: read 'ioc->params' inside 'ioc->lock' in ioc_timer_fn()
2022-10-23 18:59:17 -06:00
blk-iolatency.c
block: Replace struct rq_depth with unsigned int in struct iolatency_grp
2022-11-01 09:12:24 -06:00
blk-ioprio.c
blk-ioprio: pass a gendisk to blk_ioprio_init and blk_ioprio_exit
2022-09-26 19:09:31 -06:00
blk-ioprio.h
blk-ioprio: pass a gendisk to blk_ioprio_init and blk_ioprio_exit
2022-09-26 19:09:31 -06:00
blk-lib.c
blk-lib: fix blkdev_issue_secure_erase
2022-09-15 00:25:17 -06:00
blk-map.c
block: set FOLL_PCI_P2PDMA in bio_map_user_iov()
2022-11-09 11:29:21 -07:00
blk-merge.c
block: Micro-optimize get_max_segment_size()
2022-10-25 13:41:20 -06:00
blk-mq-cpumap.c
block: Change the return type of blk_mq_map_queues() into void
2022-08-22 10:07:53 -06:00
blk-mq-debugfs-zoned.c
block: move zone related fields to struct gendisk
2022-07-06 06:46:26 -06:00
blk-mq-debugfs.c
for-6.1/block-2022-10-03
2022-10-07 09:19:14 -07:00
blk-mq-debugfs.h
block: remove per-disk debugfs files in blk_unregister_queue
2022-06-17 07:31:05 -06:00
blk-mq-pci.c
block: Change the return type of blk_mq_map_queues() into void
2022-08-22 10:07:53 -06:00
blk-mq-rdma.c
block: Change the return type of blk_mq_map_queues() into void
2022-08-22 10:07:53 -06:00
blk-mq-sched.c
block: split elevator_switch
2022-11-01 09:12:24 -06:00
blk-mq-sched.h
block: move blk_mq_sched_assign_ioc to blk-ioc.c
2021-11-29 06:41:29 -07:00
blk-mq-sysfs.c
blk-mq: cleanup disk sysfs registration
2022-06-28 11:32:42 -06:00
blk-mq-tag.c
sbitmap: fix batched wait_cnt accounting
2022-09-12 00:10:34 -06:00
blk-mq-tag.h
blk-mq: blk_mq_tag_busy is no need to return a value
2022-06-27 06:29:12 -06:00
blk-mq-virtio.c
block: Change the return type of blk_mq_map_queues() into void
2022-08-22 10:07:53 -06:00
blk-mq.c
blk-mq: simplify blk_mq_realloc_tag_set_tags
2022-11-10 11:18:09 -07:00
blk-mq.h
blk-mq: move the srcu_struct used for quiescing to the tagset
2022-11-02 08:35:34 -06:00
blk-pm.c
scsi: block: pm: Always set request queue runtime active in blk_post_runtime_resume()
2021-12-22 23:38:29 -05:00
blk-pm.h
block: Remove unused blk_pm_*() function definitions
2021-02-22 06:33:48 -07:00
blk-rq-qos.c
block/rq_qos: Use atomic_try_cmpxchg in atomic_inc_below
2022-07-12 14:38:52 -06:00
blk-rq-qos.h
block/blk-rq-qos: delete useless enmu RQ_QOS_IOPRIO
2022-09-21 19:50:53 -06:00
blk-settings.c
block: Constify most queue limits pointers
2022-10-25 13:41:17 -06:00
blk-stat.c
block: make queue stat accounting a reference
2021-12-14 17:23:05 -07:00
blk-stat.h
block: make queue stat accounting a reference
2021-12-14 17:23:05 -07:00
blk-sysfs.c
blk-mq: move the srcu_struct used for quiescing to the tagset
2022-11-02 08:35:34 -06:00
blk-throttle.c
blk-throttle: pass a gendisk to blk_throtl_cancel_bios
2022-09-26 19:17:28 -06:00
blk-throttle.h
blk-throttle: pass a gendisk to blk_throtl_cancel_bios
2022-09-26 19:17:28 -06:00
blk-timeout.c
block: blk-timeout: delete duplicated word
2020-07-31 16:29:47 -06:00
blk-wbt.c
blk-wbt: don't enable throttling if default elevator is bfq
2022-10-23 18:59:17 -06:00
blk-wbt.h
blk-wbt: don't show valid wbt_lat_usec in sysfs while wbt is disabled
2022-10-23 18:59:17 -06:00
blk-zoned.c
block: adapt blk_mq_plug() to not plug for writes that require a zone lock
2022-09-29 07:45:47 -06:00
blk.h
blk-mq: move the srcu_struct used for quiescing to the tagset
2022-11-02 08:35:34 -06:00
bounce.c
block: change the blk_queue_bounce calling convention
2022-08-02 17:22:54 -06:00
bsg-lib.c
blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue
2022-10-25 08:25:10 -06:00
bsg.c
scsi: core: bsg: Remove usage of the deprecated ida_simple_xxx() API
2022-06-21 21:22:51 -04:00
disk-events.c
block: remove genhd.h
2022-02-02 07:49:59 -07:00
elevator.c
block: Fix some kernel-doc comments
2022-11-07 07:21:45 -07:00
elevator.h
block: add proper helpers for elevator_type module refcount management
2022-10-23 18:59:17 -06:00
fops.c
block: remove blkdev_writepages
2022-11-16 11:32:53 -07:00
genhd.c
block: remove delayed holder registration
2022-11-16 15:19:56 -07:00
holder.c
block: don't allow a disk link holder to itself
2022-11-16 15:19:56 -07:00
ioctl.c
block: replace blkdev_nr_zones with bdev_nr_zones
2022-07-06 06:46:26 -06:00
ioprio.c
block: Fix handling of tasks without ioprio in ioprio_get(2)
2022-06-27 06:29:12 -06:00
Kconfig
block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency
2022-06-29 08:35:57 -06:00
Kconfig.iosched
block: only build the icq tracking code when needed
2021-12-16 10:59:02 -07:00
kyber-iosched.c
block/kyber: Use the new blk_opf_t type
2022-07-14 12:14:30 -06:00
Makefile
blk-cgroup: move blkcg_{get,set}_fc_appid out of line
2022-05-02 14:06:20 -06:00
mq-deadline.c
block/mq-deadline: Use the new blk_opf_t type
2022-07-14 12:14:30 -06:00
opal_proto.h
block: sed-opal: Add ioctl to return device status
2022-08-22 07:52:51 -06:00
sed-opal.c
block: sed-opal: Add ioctl to return device status
2022-08-22 07:52:51 -06:00
t10-pi.c
block: add pi for extended integrity
2022-03-07 12:48:35 -07:00