Serhey Popovych 07f615574f ipv6: Do not leak throw route references
While commit 73ba57bfae4a ("ipv6: fix backtracking for throw routes")
does good job on error propagation to the fib_rules_lookup()
in fib rules core framework that also corrects throw routes
handling, it does not solve route reference leakage problem
happened when we return -EAGAIN to the fib_rules_lookup()
and leave routing table entry referenced in arg->result.

If rule with matched throw route isn't last matched in the
list we overwrite arg->result losing reference on throw
route stored previously forever.

We also partially revert commit ab997ad40839 ("ipv6: fix the
incorrect return value of throw route") since we never return
routing table entry with dst.error == -EAGAIN when
CONFIG_IPV6_MULTIPLE_TABLES is on. Also there is no point
to check for RTF_REJECT flag since it is always set throw
route.

Fixes: 73ba57bfae4a ("ipv6: fix backtracking for throw routes")
Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-20 15:34:02 -04:00
..
2017-04-24 07:56:31 +02:00
2017-03-27 16:05:06 -07:00
2017-02-15 11:04:11 +01:00
2016-12-25 17:21:23 +01:00
2017-06-04 22:56:55 -04:00
2017-06-12 09:53:14 -04:00
2017-06-04 22:56:55 -04:00
2016-06-27 15:06:17 -04:00
2015-11-03 10:52:13 -05:00
2017-02-15 11:04:11 +01:00