iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/clk
History
Maxime Ripard 08a32902a5 clk: Remove WARN_ON NULL parent in clk_core_init_rate_req() 
If a clock has CLK_SET_RATE_PARENT, but core->parent is NULL (most
likely because it's orphan), callers of clk_core_init_rate_req() will
blindly call this function leading to a very verbose warning.

Since it's a fairly common situation, let's just remove the WARN_ON but
keep the check that prevents us from dereferencing the pointer.

Interestingly, it fixes a regression on the Mediatek MT8195 where the
GPU would stall during a clk_set_rate for its main clock. We couldn't
come up with a proper explanation since the condition is essentially the
same.

It was then assumed that it could be timing related since printing the
warning stacktrace takes a while, but we couldn't replicate the failure
by using fairly large (10ms) mdelays.

Fixes: 262ca38f4b6e ("clk: Stop forwarding clk_rate_requests to the parent")
Reported-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20221018-clk-range-checks-fixes-v1-1-f3ef80518140@cerno.tech
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
2022-10-27 17:06:50 -07:00
..
actions
clk: actions: remove redundant assignment after a mask operation
2022-04-22 19:01:20 -07:00
analogbits
Merge branch 'akpm' (patches from Andrew)
2021-07-02 12:08:10 -07:00
at91
Merge branch 'clk-rate-range' into clk-next
2022-10-14 13:44:44 -07:00
axis
clk: cleanup comments
2022-03-11 18:22:15 -08:00
axs10x
treewide: Replace GPLv2 boilerplate/reference with SPDX - gpl-2.0_56.RULE (part 2)
2022-06-10 14:51:35 +02:00
baikal-t1
clk: baikal-t1: Convert to platform device driver
2022-09-30 14:20:56 -07:00
bcm
Here's the main clk pull request for this merge window. We have some
2022-10-08 10:06:48 -07:00
berlin
clk: berlin: Add of_node_put() for of_get_parent()
2022-08-19 14:50:24 -07:00
davinci
Merge branches 'clk-fixed-rate', 'clk-spreadtrum', 'clk-pxa' and 'clk-ti' into clk-next
2022-10-04 10:54:14 -07:00
hisilicon
Merge branches 'clk-starfive', 'clk-ti', 'clk-terminate' and 'clk-cleanup' into clk-next
2022-03-29 10:19:10 -07:00
imgtec
…
imx
Here's the main clk pull request for this merge window. We have some
2022-10-08 10:06:48 -07:00
ingenic
clk: ingenic-tcu: Properly enable registers before accessing timers
2022-08-31 18:28:20 -07:00
keystone
treewide: Replace GPLv2 boilerplate/reference with SPDX - gpl-2.0_320.RULE
2022-06-10 14:51:36 +02:00
loongson1
clk: loongson1: Terminate clk_div_table with sentinel element
2022-03-11 18:13:24 -08:00
mediatek
clk: mediatek: clk-mt8195-topckgen: Fix error return code in clk_mt8195_topck_probe()
2022-10-17 14:07:50 -07:00
meson
clk: meson: Hold reference returned by of_get_parent()
2022-08-19 14:29:00 -07:00
microchip
clk: microchip: add PolarFire SoC fabric clock support
2022-09-14 10:57:07 +03:00
mmp
clk: mmp: pxa168: control shared SDH bits with separate clock
2022-09-30 13:34:07 -07:00
mstar
clk: mstar: msc313-mpll: Fix format specifier
2021-02-16 12:52:28 -08:00
mvebu
clk: mvebu: armada-37xx-tbg: Remove the unneeded result variable
2022-09-30 17:46:30 -07:00
mxs
…
nxp
clk: nxp: fix typo in comment
2022-10-03 12:34:32 -07:00
pistachio
clk: pistachio: Fix initconst confusion
2022-09-28 18:35:45 -07:00
pxa
clk: pxa: add a check for the return value of kzalloc()
2022-10-03 12:32:03 -07:00
qcom
Merge branch 'clk-rate-range' into clk-next
2022-10-14 13:44:44 -07:00
ralink
clk: ralink: make system controller node a reset provider
2022-02-15 17:06:37 +01:00
renesas
clk: renesas: r8a779g0: Fix HSCIF parent clocks
2022-10-26 12:05:36 +02:00
rockchip
clk: rockchip: Add clock controller support for RV1126 SoC
2022-09-23 11:15:30 +02:00
samsung
clk: samsung: exynos850: Implement CMU_MFCMSCL domain
2022-08-23 10:14:47 +03:00
sifive
clk: sifive: select by default if SOC_SIFIVE
2022-10-17 14:07:11 -07:00
socfpga
clk: cleanup comments
2022-03-11 18:22:15 -08:00
spear
clk: spear: Move prototype to accessible header
2022-10-10 10:37:58 +02:00
sprd
Merge branches 'clk-fixed-rate', 'clk-spreadtrum', 'clk-pxa' and 'clk-ti' into clk-next
2022-10-04 10:54:14 -07:00
st
clk: st: Hold reference returned by of_get_parent()
2022-08-19 14:34:44 -07:00
starfive
clk: starfive: Add JH7100 audio clock driver
2022-03-10 18:17:33 -08:00
stm32
clk: stm32: rcc_reset: Fix missing spin_lock_init()
2022-06-09 15:34:08 -07:00
sunxi
clk: sunxi: Do not select the PRCM MFD
2022-07-04 21:59:30 +02:00
sunxi-ng
Here's the main clk pull request for this merge window. We have some
2022-10-08 10:06:48 -07:00
tegra
clk: tegra: Fix Tegra PWM parent clock
2022-10-14 13:44:24 -07:00
ti
Here's the main clk pull request for this merge window. We have some
2022-10-08 10:06:48 -07:00
uniphier
clk: uniphier: Fix fixed-rate initialization
2022-03-11 19:29:02 -08:00
ux500
clk: ux500: fix a possible off-by-one in u8500_prcc_reset_base()
2022-05-18 13:34:03 -07:00
versatile
clk: versatile: clk-icst: use after free on error path
2021-12-07 12:25:29 -08:00
visconti
clk: visconti: prevent array overflow in visconti_clk_register_gates()
2022-03-17 12:21:28 -07:00
x86
platform/x86: Drop the PMC_ATOM Kconfig option
2022-06-12 14:41:22 +02:00
xilinx
clk: clocking-wizard: Depend on HAS_IOMEM
2022-10-03 13:27:58 -07:00
zynq
clk: zynq: Update the parameters to zynq_clk_register_periph_clk
2022-03-29 10:17:49 -07:00
zynqmp
clk: zynqmp: pll: rectify rate rounding in zynqmp_pll_round_rate
2022-08-30 15:05:59 -07:00
.kunitconfig
clk: explicitly disable CONFIG_UML_PCI_OVER_VIRTIO in .kunitconfig
2022-07-14 10:35:44 -06:00
clk_test.c
clk: tests: Add tests for notifiers
2022-10-10 20:37:50 -07:00
clk-apple-nco.c
clk: clk-apple-nco: Allow and fix module building
2022-03-15 09:56:12 -07:00
clk-asm9260.c
clk: asm9260: use parent index to link the reference clock
2022-09-29 17:55:26 -07:00
clk-aspeed.c
…
clk-aspeed.h
…
clk-ast2600.c
clk: ast2600: BCLK comes from EPLL
2022-10-03 14:12:15 -07:00
clk-axi-clkgen.c
clk: axi-clkgen: use devm_platform_ioremap_resource() short-hand
2021-02-08 18:13:13 -08:00
clk-axm5516.c
…
clk-bd718x7.c
clk: bd718xx: Drop BD70528 support
2021-06-27 18:42:45 -07:00
clk-bm1880.c
clk: bm1880: remove kfrees on static allocations
2022-01-06 17:46:56 -08:00
clk-bulk.c
…
clk-cdce706.c
i2c: Make remove callback return void
2022-08-16 12:46:26 +02:00
clk-cdce925.c
clk: cdce925: use i2c_match_id and simple i2c probe
2022-04-22 19:28:07 -07:00
clk-clps711x.c
clk: clps711x: Terminate clk_div_table with sentinel element
2022-03-11 18:13:24 -08:00
clk-composite.c
clk: Stop forwarding clk_rate_requests to the parent
2022-09-15 09:32:11 -07:00
clk-conf.c
…
clk-cs2000-cp.c
i2c: Make remove callback return void
2022-08-16 12:46:26 +02:00
clk-devres.c
clk: Fix pointer casting to prevent oops in devm_clk_release()
2022-06-22 16:10:23 -07:00
clk-divider.c
clk: Introduce clk_hw_init_rate_request()
2022-09-15 09:31:40 -07:00
clk-en7523.c
clk: en7523: fix wrong pointer check in en7523_clk_probe()
2022-04-26 11:17:47 -07:00
clk-fixed-factor.c
clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw()
2022-07-29 16:44:08 -07:00
clk-fixed-mmio.c
clk: clk-fixed-mmio: Demote obvious kernel-doc abuse
2021-02-11 11:56:05 -08:00
clk-fixed-rate.c
clk: fixed-rate: add devm_clk_hw_register_fixed_rate
2022-09-29 17:55:29 -07:00
clk-fractional-divider.c
clk: cleanup comments
2022-03-11 18:22:15 -08:00
clk-fractional-divider.h
clk: fractional-divider: Hide clk_fractional_divider_ops from wide audience
2021-08-12 12:42:00 -07:00
clk-fsl-flexspi.c
…
clk-fsl-sai.c
…
clk-gate_test.c
clk: gate: Add some kunit test suites
2022-01-24 17:22:53 -08:00
clk-gate.c
clk: gate: Add devm_clk_hw_register_gate()
2021-12-08 11:19:20 +01:00
clk-gemini.c
clk: Gemini: fix struct name in kernel-doc
2021-12-02 17:27:48 -08:00
clk-gpio.c
…
clk-hi655x.c
…
clk-highbank.c
…
clk-hsdk-pll.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - gpl-2.0_56.RULE (part 2)
2022-06-10 14:51:35 +02:00
clk-k210.c
clk: k210: Fix k210_clk_set_parent()
2021-06-30 11:34:36 -07:00
clk-lan966x.c
clk: allow building lan966x as a module
2022-10-03 14:14:02 -07:00
clk-lmk04832.c
spi: make remove callback a void function
2022-02-09 13:00:45 +00:00
clk-lochnagar.c
dt-bindings: clock: Move lochnagar.h to dt-bindings/clock
2022-08-22 16:04:00 -07:00
clk-max9485.c
clk: max9485: use simple i2c probe function
2022-04-22 19:28:08 -07:00
clk-max77686.c
…
clk-milbeaut.c
…
clk-moxart.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - gpl-2.0_56.RULE (part 2)
2022-06-10 14:51:35 +02:00
clk-multiplier.c
…
clk-mux.c
clk: mux: remove redundant initialization of variable width
2022-04-25 15:49:20 -07:00
clk-nomadik.c
clk: nomadik: Add missing of_node_put()
2022-08-19 14:24:27 -07:00
clk-npcm7xx.c
clk: clk-npcm7xx: Remove unused struct npcm7xx_clk_gate_data and npcm7xx_clk_div_fixed_data
2022-09-28 17:39:04 -07:00
clk-nspire.c
…
clk-oxnas.c
clk: oxnas: Hold reference returned by of_get_parent()
2022-08-19 14:35:43 -07:00
clk-palmas.c
clk: palmas: Add a missing SPDX license header
2021-08-05 17:34:30 -07:00
clk-plldig.c
…
clk-pwm.c
…
clk-qoriq.c
clk: qoriq: Hold reference returned by of_get_parent()
2022-08-19 14:41:47 -07:00
clk-renesas-pcie.c
clk: rs9: Fix I2C accessors
2022-10-17 14:06:07 -07:00
clk-rk808.c
…
clk-s2mps11.c
…
clk-scmi.c
clk: scmi: Support atomic clock enable/disable API
2022-02-21 10:37:00 +00:00
clk-scpi.c
…
clk-si514.c
i2c: Make remove callback return void
2022-08-16 12:46:26 +02:00
clk-si544.c
clk: si544: use i2c_match_id and simple i2c probe
2022-04-22 19:28:08 -07:00
clk-si570.c
i2c: Make remove callback return void
2022-08-16 12:46:26 +02:00
clk-si5341.c
i2c: Make remove callback return void
2022-08-16 12:46:26 +02:00
clk-si5351.c
i2c: Make remove callback return void
2022-08-16 12:46:26 +02:00
clk-si5351.h
clk: si5351: Update datasheet references
2021-11-02 14:29:17 -07:00
clk-sparx5.c
…
clk-stm32f4.c
clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell
2021-12-15 22:45:48 -08:00
clk-stm32h7.c
clk: stm32h7: Switch to clk_divider.determine_rate
2021-08-05 17:36:10 -07:00
clk-stm32mp1.c
clk: stm32mp1: Add parent_data to ETHRX clock
2022-01-24 17:17:31 -08:00
clk-tps68470.c
platform/x86: int3472: Support multiple clock consumers
2022-09-24 19:12:32 +02:00
clk-twl6040.c
…
clk-versaclock5.c
Here's the main clk pull request for this merge window. We have some
2022-10-08 10:06:48 -07:00
clk-versaclock7.c
Here's the main clk pull request for this merge window. We have some
2022-10-08 10:06:48 -07:00
clk-vt8500.c
…
clk-wm831x.c
…
clk-xgene.c
clk: clk-xgene: simplify if-if to if-else
2022-10-03 14:13:29 -07:00
clk.c
clk: Remove WARN_ON NULL parent in clk_core_init_rate_req()
2022-10-27 17:06:50 -07:00
clk.h
…
clkdev.c
clkdev: Simplify devm_clk_hw_register_clkdev() function
2022-09-30 14:50:11 -07:00
Kconfig
Merge branches 'clk-baikal', 'clk-broadcom', 'clk-vc5' and 'clk-versaclock' into clk-next
2022-10-04 10:54:34 -07:00
Makefile
clk: Renesas versaclock7 ccf device driver
2022-09-30 17:34:35 -07:00