360fdc999d
Starting with commit eee16b147121 ("net: dsa: microchip: perform the
compatibility check for dev probed"), the KSZ switch driver now bails
out if it thinks the DT compatible doesn't match the actual chip ID
read back from the hardware:
ksz9477-switch 1-005f: Device tree specifies chip KSZ9893 but found
KSZ8563, please fix it!
For the KSZ8563, which used ksz_switch_chips[KSZ9893], this was fine
at first, because it indeed shares the same chip id as the KSZ9893.
Commit b44908095612 ("net: dsa: microchip: add separate struct
ksz_chip_data for KSZ8563 chip") started differentiating KSZ9893
compatible chips by consulting the 0x1F register. The resulting breakage
was fixed for the SPI driver in the same commit by introducing the
appropriate ksz_switch_chips[KSZ8563], but not for the I2C driver.
Fix this for I2C-connected KSZ8563 now to get it probing again.
Fixes: b44908095612 ("net: dsa: microchip: add separate struct ksz_chip_data for KSZ8563 chip").
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20230120110933.1151054-1-a.fatoum@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
133 lines
2.7 KiB
C
133 lines
2.7 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Microchip KSZ9477 series register access through I2C
|
|
*
|
|
* Copyright (C) 2018-2019 Microchip Technology Inc.
|
|
*/
|
|
|
|
#include <linux/i2c.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/regmap.h>
|
|
|
|
#include "ksz_common.h"
|
|
|
|
KSZ_REGMAP_TABLE(ksz9477, not_used, 16, 0, 0);
|
|
|
|
static int ksz9477_i2c_probe(struct i2c_client *i2c)
|
|
{
|
|
struct regmap_config rc;
|
|
struct ksz_device *dev;
|
|
int i, ret;
|
|
|
|
dev = ksz_switch_alloc(&i2c->dev, i2c);
|
|
if (!dev)
|
|
return -ENOMEM;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(ksz9477_regmap_config); i++) {
|
|
rc = ksz9477_regmap_config[i];
|
|
rc.lock_arg = &dev->regmap_mutex;
|
|
dev->regmap[i] = devm_regmap_init_i2c(i2c, &rc);
|
|
if (IS_ERR(dev->regmap[i])) {
|
|
return dev_err_probe(&i2c->dev, PTR_ERR(dev->regmap[i]),
|
|
"Failed to initialize regmap%i\n",
|
|
ksz9477_regmap_config[i].val_bits);
|
|
}
|
|
}
|
|
|
|
if (i2c->dev.platform_data)
|
|
dev->pdata = i2c->dev.platform_data;
|
|
|
|
dev->irq = i2c->irq;
|
|
|
|
ret = ksz_switch_register(dev);
|
|
|
|
/* Main DSA driver may not be started yet. */
|
|
if (ret)
|
|
return ret;
|
|
|
|
i2c_set_clientdata(i2c, dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void ksz9477_i2c_remove(struct i2c_client *i2c)
|
|
{
|
|
struct ksz_device *dev = i2c_get_clientdata(i2c);
|
|
|
|
if (dev)
|
|
ksz_switch_remove(dev);
|
|
}
|
|
|
|
static void ksz9477_i2c_shutdown(struct i2c_client *i2c)
|
|
{
|
|
struct ksz_device *dev = i2c_get_clientdata(i2c);
|
|
|
|
if (!dev)
|
|
return;
|
|
|
|
if (dev->dev_ops->reset)
|
|
dev->dev_ops->reset(dev);
|
|
|
|
dsa_switch_shutdown(dev->ds);
|
|
|
|
i2c_set_clientdata(i2c, NULL);
|
|
}
|
|
|
|
static const struct i2c_device_id ksz9477_i2c_id[] = {
|
|
{ "ksz9477-switch", 0 },
|
|
{},
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(i2c, ksz9477_i2c_id);
|
|
|
|
static const struct of_device_id ksz9477_dt_ids[] = {
|
|
{
|
|
.compatible = "microchip,ksz9477",
|
|
.data = &ksz_switch_chips[KSZ9477]
|
|
},
|
|
{
|
|
.compatible = "microchip,ksz9896",
|
|
.data = &ksz_switch_chips[KSZ9896]
|
|
},
|
|
{
|
|
.compatible = "microchip,ksz9897",
|
|
.data = &ksz_switch_chips[KSZ9897]
|
|
},
|
|
{
|
|
.compatible = "microchip,ksz9893",
|
|
.data = &ksz_switch_chips[KSZ9893]
|
|
},
|
|
{
|
|
.compatible = "microchip,ksz9563",
|
|
.data = &ksz_switch_chips[KSZ9563]
|
|
},
|
|
{
|
|
.compatible = "microchip,ksz8563",
|
|
.data = &ksz_switch_chips[KSZ8563]
|
|
},
|
|
{
|
|
.compatible = "microchip,ksz9567",
|
|
.data = &ksz_switch_chips[KSZ9567]
|
|
},
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, ksz9477_dt_ids);
|
|
|
|
static struct i2c_driver ksz9477_i2c_driver = {
|
|
.driver = {
|
|
.name = "ksz9477-switch",
|
|
.of_match_table = of_match_ptr(ksz9477_dt_ids),
|
|
},
|
|
.probe_new = ksz9477_i2c_probe,
|
|
.remove = ksz9477_i2c_remove,
|
|
.shutdown = ksz9477_i2c_shutdown,
|
|
.id_table = ksz9477_i2c_id,
|
|
};
|
|
|
|
module_i2c_driver(ksz9477_i2c_driver);
|
|
|
|
MODULE_AUTHOR("Tristram Ha <Tristram.Ha@microchip.com>");
|
|
MODULE_DESCRIPTION("Microchip KSZ9477 Series Switch I2C access Driver");
|
|
MODULE_LICENSE("GPL v2");
|