iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/crypto
History
Ard Biesheuvel 0aa171e9b2 crypto: ecdh - avoid buffer overflow in ecdh_set_secret() 
Pavel reports that commit 17858b140bf4 ("crypto: ecdh - avoid unaligned
accesses in ecdh_set_secret()") fixes one problem but introduces another:
the unconditional memcpy() introduced by that commit may overflow the
target buffer if the source data is invalid, which could be the result of
intentional tampering.

So check params.key_size explicitly against the size of the target buffer
before validating the key further.

Fixes: 17858b140bf4 ("crypto: ecdh - avoid unaligned accesses in ecdh_set_secret()")
Reported-by: Pavel Machek <pavel@denx.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2021-01-03 08:35:35 +11:00
..
asymmetric_keys
crypto: sha - split sha.h into sha1.h and sha2.h
2020-11-20 14:45:33 +11:00
async_tx
md/raid6: let async recovery function support different page offset
2020-09-24 16:44:44 -07:00
842.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157
2019-05-30 11:26:37 -07:00
acompress.c
crypto: api - permit users to specify numa node of acomp hardware
2020-07-09 18:25:23 +10:00
adiantum.c
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
aead.c
crypto: algapi - enforce that all instances have a ->free() method
2020-01-09 11:30:58 +08:00
aegis128-core.c
crypto: aegis128 - avoid spurious references crypto_aegis128_update_simd
2020-12-04 18:16:53 +11:00
aegis128-neon-inner.c
crypto: aegis128/neon - move final tag check to SIMD domain
2020-11-27 17:13:40 +11:00
aegis128-neon.c
crypto: aegis128/neon - move final tag check to SIMD domain
2020-11-27 17:13:40 +11:00
aegis.h
crypto: aegis128 - Fix -Wunused-const-variable warning
2019-08-30 18:05:30 +10:00
aes_generic.c
crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN
2020-01-09 11:30:53 +08:00
aes_ti.c
crypto: aes - create AES library based on the fixed time AES code
2019-07-26 14:55:33 +10:00
af_alg.c
crypto: af_alg - avoid undefined behavior accessing salg_name
2020-11-06 14:29:11 +11:00
ahash.c
crypto: ahash - Add init_tfm/exit_tfm
2020-08-28 16:58:28 +10:00
akcipher.c
crypto: algapi - enforce that all instances have a ->free() method
2020-01-09 11:30:58 +08:00
algapi.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
algboss.c
crypto: algboss - don't wait during notifier callback
2020-06-15 17:38:54 +10:00
algif_aead.c
crypto: algif_aead - Do not set MAY_BACKLOG on the async path
2020-08-21 14:45:27 +10:00
algif_hash.c
net: make ->{get,set}sockopt in proto_ops optional
2020-07-19 18:16:41 -07:00
algif_rng.c
crypto: af_alg - add extra parameters for DRBG interface
2020-09-25 17:48:52 +10:00
algif_skcipher.c
crypto: algif_skcipher - EBUSY on aio should be an error
2020-08-21 14:45:26 +10:00
ansi_cprng.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 42
2019-05-24 17:27:12 +02:00
anubis.c
crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN
2020-01-09 11:30:53 +08:00
api.c
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
arc4.c
crypto: arc4 - mark ecb(arc4) skcipher as obsolete
2020-09-11 14:39:16 +10:00
authenc.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
authencesn.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
blake2b_generic.c
crypto: Replace HTTP links with HTTPS ones
2020-07-23 17:34:20 +10:00
blake2s_generic.c
crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN
2020-01-09 11:30:53 +08:00
blowfish_common.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
blowfish_generic.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
camellia_generic.c
crypto: Replace HTTP links with HTTPS ones
2020-07-23 17:34:20 +10:00
cast5_generic.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 140
2019-05-30 11:25:16 -07:00
cast6_generic.c
crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN
2020-01-09 11:30:53 +08:00
cast_common.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 44
2019-05-24 17:27:12 +02:00
cbc.c
crypto: cbc - Remove cbc.h
2020-09-11 14:39:16 +10:00
ccm.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
cfb.c
crypto: skcipher - Add skcipher_ialg_simple helper
2019-12-27 18:18:04 +08:00
chacha20poly1305.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
chacha_generic.c
crypto: chacha_generic - remove unnecessary setkey() functions
2019-11-22 18:48:39 +08:00
cipher.c
crypto: remove propagation of CRYPTO_TFM_RES_* flags
2020-01-09 11:30:53 +08:00
cmac.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
compress.c
crypto: compress - remove crt_u.compress (struct compress_tfm)
2019-12-11 16:37:01 +08:00
crc32_generic.c
crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN
2020-01-09 11:30:53 +08:00
crc32c_generic.c
crypto: crc32c_generic - delete and fix duplicated words
2020-08-21 14:45:25 +10:00
crct10dif_common.c
crypto: crct10dif - Add fallback for broken initrds
2013-09-12 15:31:34 +10:00
crct10dif_generic.c
crypto: crct10dif_generic - fix duplicated words
2020-08-21 14:45:25 +10:00
cryptd.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
crypto_engine.c
crypto: engine - delete duplicated word
2020-08-21 14:45:26 +10:00
crypto_null.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
crypto_user_base.c
crypto: algapi - make unregistration functions return void
2019-12-20 14:58:35 +08:00
crypto_user_stat.c
crypto: skcipher - remove the "blkcipher" algorithm type
2019-11-01 13:38:32 +08:00
ctr.c
crypto: algapi - add NEED_FALLBACK to INHERITED_FLAGS
2020-07-16 21:49:08 +10:00
cts.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
curve25519-generic.c
crypto: curve25519 - implement generic KPP driver
2019-11-17 09:02:43 +08:00
deflate.c
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
des_generic.c
crypto: remove CRYPTO_TFM_RES_WEAK_KEY
2020-01-09 11:30:53 +08:00
dh_helper.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dh.c
crypto: dh - SP800-56A rev 3 local public key validation
2020-07-31 18:08:59 +10:00
drbg.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
ecb.c
crypto: skcipher - Add skcipher_ialg_simple helper
2019-12-27 18:18:04 +08:00
ecc_curve_defs.h
crypto: ecc - make ecc into separate module
2019-04-18 22:15:02 +08:00
ecc.c
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
ecc.h
crypto: ecc - SP800-56A rev 3 local public key validation
2020-07-31 18:08:59 +10:00
ecdh_helper.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
ecdh.c
crypto: ecdh - avoid buffer overflow in ecdh_set_secret()
2021-01-03 08:35:35 +11:00
echainiv.c
crypto: geniv - remove unneeded arguments from aead_geniv_alloc()
2020-07-16 21:49:07 +10:00
ecrdsa_defs.h
crypto: ecrdsa - add EC-RDSA (GOST 34.10) algorithm
2019-04-18 22:15:02 +08:00
ecrdsa_params.asn1
crypto: ecrdsa - add EC-RDSA (GOST 34.10) algorithm
2019-04-18 22:15:02 +08:00
ecrdsa_pub_key.asn1
crypto: ecrdsa - add EC-RDSA (GOST 34.10) algorithm
2019-04-18 22:15:02 +08:00
ecrdsa.c
crypto: algapi - Remove skbuff.h inclusion
2020-08-20 14:04:28 +10:00
essiv.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
fcrypt.c
crypto: make all generic algorithms set cra_driver_name
2019-06-13 14:31:39 +08:00
fips.c
crypto: fips - add FIPS test failure notification chain
2019-07-26 14:51:57 +10:00
gcm.c
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
geniv.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
gf128mul.c
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
ghash-generic.c
crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN
2020-01-09 11:30:53 +08:00
hash_info.c
crypto: rename sm3-256 to sm3 in hash_algo_name
2020-02-18 07:35:49 -05:00
hmac.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
internal.h
crypto: algapi - Move crypto_yield into internal.h
2020-08-19 21:59:43 +10:00
jitterentropy-kcapi.c
crypto: algapi - Remove skbuff.h inclusion
2020-08-20 14:04:28 +10:00
jitterentropy.c
crypto: Replace HTTP links with HTTPS ones
2020-07-23 17:34:20 +10:00
jitterentropy.h
crypto: jitter - add header to fix buildwarnings
2019-10-18 18:49:40 +11:00
Kconfig
crypto: tcrypt - permit tcrypt.ko to be builtin
2020-11-27 17:13:45 +11:00
keywrap.c
crypto: skcipher - Add skcipher_ialg_simple helper
2019-12-27 18:18:04 +08:00
khazad.c
crypto: make all generic algorithms set cra_driver_name
2019-06-13 14:31:39 +08:00
kpp.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
lrw.c
crypto: Replace HTTP links with HTTPS ones
2020-07-23 17:34:20 +10:00
lz4.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
lz4hc.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
lzo-rle.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
lzo.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
Makefile
crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm
2020-09-25 17:48:54 +10:00
md4.c
crypto: make all generic algorithms set cra_driver_name
2019-06-13 14:31:39 +08:00
md5.c
crypto: md5 - remove unused macros
2020-02-28 08:43:21 +08:00
memneq.c
crypto: memneq - fix for archs without efficient unaligned access
2013-12-09 20:09:12 +08:00
michael_mic.c
crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN
2020-01-09 11:30:53 +08:00
nhpoly1305.c
crypto: poly1305 - add new 32 and 64-bit generic versions
2020-01-16 15:18:12 +08:00
ofb.c
crypto: skcipher - Add skcipher_ialg_simple helper
2019-12-27 18:18:04 +08:00
pcbc.c
crypto: skcipher - Add skcipher_ialg_simple helper
2019-12-27 18:18:04 +08:00
pcrypt.c
padata: fold padata_alloc_possible() into padata_alloc()
2020-07-23 17:34:18 +10:00
poly1305_generic.c
crypto: poly1305 - add new 32 and 64-bit generic versions
2020-01-16 15:18:12 +08:00
proc.c
crypto: proc - Removing some useless only space lines
2020-09-25 17:48:15 +10:00
ripemd.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
rmd128.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
rmd160.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
rmd256.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
rmd320.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
rng.c
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
rsa_helper.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
rsa-pkcs1pad.c
crypto: algapi - Remove skbuff.h inclusion
2020-08-20 14:04:28 +10:00
rsa.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36
2019-05-24 17:27:11 +02:00
rsaprivkey.asn1
crypto: rsa - Store rest of the private key components
2016-07-05 23:05:26 +08:00
rsapubkey.asn1
crypto: akcipher - Changes to asymmetric key API
2015-10-14 22:23:16 +08:00
salsa20_generic.c
crypto: Replace HTTP links with HTTPS ones
2020-07-23 17:34:20 +10:00
scatterwalk.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
scompress.c
crypto: algapi - make unregistration functions return void
2019-12-20 14:58:35 +08:00
seed.c
crypto: seed - remove trailing semicolon in macro definition
2020-12-04 18:13:16 +11:00
seqiv.c
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
serpent_generic.c
crypto: x86 - Regularize glue function prototypes
2019-12-11 16:36:54 +08:00
sha1_generic.c
crypto: sha - split sha.h into sha1.h and sha2.h
2020-11-20 14:45:33 +11:00
sha3_generic.c
crypto: Replace HTTP links with HTTPS ones
2020-07-23 17:34:20 +10:00
sha256_generic.c
crypto: sha - split sha.h into sha1.h and sha2.h
2020-11-20 14:45:33 +11:00
sha512_generic.c
crypto: sha - split sha.h into sha1.h and sha2.h
2020-11-20 14:45:33 +11:00
shash.c
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
simd.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
skcipher.c
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
sm2.c
crypto: sm2 - remove unnecessary reset operations
2020-10-30 17:35:02 +11:00
sm2signature.asn1
crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm
2020-09-25 17:48:54 +10:00
sm3_generic.c
crypto: sm3 - export crypto_sm3_final function
2020-09-25 17:48:53 +10:00
sm4_generic.c
crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN
2020-01-09 11:30:53 +08:00
streebog_generic.c
crypto: streebog - remove two unused variables
2019-08-15 21:52:14 +10:00
tcrypt.c
crypto: tcrypt - include 1420 byte blocks in aead and skcipher benchmarks
2020-11-27 17:13:45 +11:00
tcrypt.h
crypto: tcrypt - Add support for hash speed testing with keys
2020-08-21 14:45:27 +10:00
tea.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
testmgr.c
crypto: testmgr - WARN on test failure
2020-11-06 14:29:10 +11:00
testmgr.h
crypto: sm2 - add SM2 test vectors to testmgr
2020-09-25 17:48:54 +10:00
tgr192.c
crypto: tgr192 - remove unneeded semicolon
2019-11-15 13:44:17 +08:00
twofish_common.c
crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN
2020-01-09 11:30:53 +08:00
twofish_generic.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13
2019-05-21 11:28:45 +02:00
vmac.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
wp512.c
crypto: make all generic algorithms set cra_driver_name
2019-06-13 14:31:39 +08:00
xcbc.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
xor.c
crypto: xor - Remove unused variable count in do_xor_speed
2020-10-08 16:38:06 +11:00
xts.c
crypto: xts - Replace memcpy() invocation with simple assignment
2020-07-31 18:09:00 +10:00
xxhash_generic.c
crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN
2020-01-09 11:30:53 +08:00
zstd.c
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00