Eric Dumazet
c77e2ef181
netfilter: nftables: avoid overflows in nft_hash_buckets() ...
[ Upstream commit a54754ec9891830ba548e2010c889e3c8146e449 ]
Number of buckets being stored in 32bit variables, we have to
ensure that no overflows occur in nft_hash_buckets()
syzbot injected a size == 0x40000000 and reported:
UBSAN: shift-out-of-bounds in ./include/linux/log2.h:57:13
shift exponent 64 is too large for 64-bit type 'long unsigned int'
CPU: 1 PID: 29539 Comm: syz-executor.4 Not tainted 5.12.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:79 [inline]
dump_stack+0x141/0x1d7 lib/dump_stack.c:120
ubsan_epilogue+0xb/0x5a lib/ubsan.c:148
__ubsan_handle_shift_out_of_bounds.cold+0xb1/0x181 lib/ubsan.c:327
__roundup_pow_of_two include/linux/log2.h:57 [inline]
nft_hash_buckets net/netfilter/nft_set_hash.c:411 [inline]
nft_hash_estimate.cold+0x19/0x1e net/netfilter/nft_set_hash.c:652
nft_select_set_ops net/netfilter/nf_tables_api.c:3586 [inline]
nf_tables_newset+0xe62/0x3110 net/netfilter/nf_tables_api.c:4322
nfnetlink_rcv_batch+0xa09/0x24b0 net/netfilter/nfnetlink.c:488
nfnetlink_rcv_skb_batch net/netfilter/nfnetlink.c:612 [inline]
nfnetlink_rcv+0x3af/0x420 net/netfilter/nfnetlink.c:630
netlink_unicast_kernel net/netlink/af_netlink.c:1312 [inline]
netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1338
netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1927
sock_sendmsg_nosec net/socket.c:654 [inline]
sock_sendmsg+0xcf/0x120 net/socket.c:674
____sys_sendmsg+0x6e8/0x810 net/socket.c:2350
___sys_sendmsg+0xf3/0x170 net/socket.c:2404
__sys_sendmsg+0xe5/0x1b0 net/socket.c:2433
do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
Fixes: 0ed6389c483d ("netfilter: nf_tables: rename set implementations")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-05-19 10:08:28 +02:00
2020-11-05 11:43:20 +01:00
2021-01-17 14:05:31 +01:00
2021-04-07 14:47:41 +02:00
2020-10-01 13:17:58 +02:00
2020-07-31 18:39:31 +02:00
2021-04-14 08:24:11 +02:00
2021-05-19 10:08:21 +02:00
2020-04-21 09:04:53 +02:00
2021-05-19 10:08:21 +02:00
2019-10-28 13:33:41 -07:00
2021-04-14 08:24:14 +02:00
2020-11-05 11:43:34 +01:00
2021-05-19 10:08:23 +02:00
2021-01-23 15:57:59 +01:00
2021-04-07 14:47:38 +02:00
2020-01-04 19:18:58 +01:00
2020-04-23 10:36:45 +02:00
2021-03-20 10:39:47 +01:00
2020-01-09 10:20:06 +01:00
2021-05-14 09:44:10 +02:00
2021-04-21 12:56:15 +02:00
2019-09-26 08:56:17 +02:00
2021-05-14 09:44:33 +02:00
2021-05-19 10:08:21 +02:00
2021-03-07 12:20:42 +01:00
2019-09-27 10:27:14 +02:00
2021-02-13 13:52:54 +01:00
2020-07-22 09:32:47 +02:00
2021-02-10 09:25:28 +01:00
2020-10-01 13:17:15 +02:00
2021-05-19 10:08:22 +02:00
2021-04-14 08:24:18 +02:00
2021-03-17 17:03:31 +01:00
2021-04-14 08:24:15 +02:00
2021-05-19 10:08:28 +02:00
2021-03-17 17:03:35 +01:00
2020-07-22 09:32:46 +02:00
2020-04-29 16:33:08 +02:00
2021-05-14 09:44:32 +02:00
2021-05-11 14:04:14 +02:00
2020-09-09 19:12:29 +02:00
2019-10-28 13:33:41 -07:00
2019-12-04 22:30:54 +01:00
2021-03-30 14:35:29 +02:00
2021-04-14 08:24:15 +02:00
2020-11-24 13:29:05 +01:00
2020-12-08 10:40:23 +01:00
2021-02-17 10:35:18 +01:00
2021-05-19 10:08:23 +02:00
2021-05-19 10:08:27 +02:00
2021-05-19 10:08:28 +02:00
2021-05-19 10:08:27 +02:00
2021-02-07 15:35:46 +01:00
2021-05-19 10:08:20 +02:00
2020-12-08 10:40:23 +01:00
2020-10-01 13:17:31 +02:00
2021-05-14 09:44:30 +02:00
2019-08-10 15:25:47 -07:00
2021-05-14 09:44:13 +02:00
2020-12-08 10:40:26 +01:00
2020-12-30 11:50:53 +01:00
2021-04-14 08:24:13 +02:00
2020-08-21 13:05:25 +02:00
2020-04-01 11:02:18 +02:00
2020-08-19 08:16:22 +02:00
c77e2ef181