48d4180939
In a system with a single initiator node, and one or more memory-only 'target' nodes, the memory-only node(s) would fail to register their initiator node correctly. i.e. in sysfs: # ls /sys/devices/system/node/node0/access0/targets/ node0 Where as the correct behavior should be: # ls /sys/devices/system/node/node0/access0/targets/ node0 node1 This happened because hmat_register_target_initiators() uses list_sort() to sort the initiator list, but the sort comparision function (initiator_cmp()) is overloaded to also set the node mask's bits. In a system with a single initiator, the list is singular, and list_sort elides the comparision helper call. Thus the node mask never gets set, and the subsequent search for the best initiator comes up empty. Add a new helper to consume the sorted initiator list, and generate the nodemask, decoupling it from the overloaded initiator_cmp() comparision callback. This prevents the singular list corner case naturally, and makes the code easier to follow as well. Cc: <stable@vger.kernel.org> Cc: Rafael J. Wysocki <rafael@kernel.org> Cc: Liu Shixin <liushixin2@huawei.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Reported-by: Chris Piper <chris.d.piper@intel.com> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Link: https://lore.kernel.org/r/20221116-acpi_hmat_fix-v2-2-3712569be691@intel.com Signed-off-by: Dan Williams <dan.j.williams@intel.com> |
||
---|---|---|
.. | ||
acpica | ||
apei | ||
arm64 | ||
dptf | ||
nfit | ||
numa | ||
pmic | ||
x86 | ||
ac.c | ||
acpi_adxl.c | ||
acpi_amba.c | ||
acpi_apd.c | ||
acpi_cmos_rtc.c | ||
acpi_configfs.c | ||
acpi_dbg.c | ||
acpi_extlog.c | ||
acpi_fpdt.c | ||
acpi_ipmi.c | ||
acpi_lpat.c | ||
acpi_lpit.c | ||
acpi_lpss.c | ||
acpi_memhotplug.c | ||
acpi_pad.c | ||
acpi_pcc.c | ||
acpi_platform.c | ||
acpi_pnp.c | ||
acpi_processor.c | ||
acpi_tad.c | ||
acpi_video.c | ||
acpi_watchdog.c | ||
battery.c | ||
bgrt.c | ||
blacklist.c | ||
bus.c | ||
button.c | ||
container.c | ||
cppc_acpi.c | ||
custom_method.c | ||
debugfs.c | ||
device_pm.c | ||
device_sysfs.c | ||
dock.c | ||
ec_sys.c | ||
ec.c | ||
event.c | ||
evged.c | ||
fan_attr.c | ||
fan_core.c | ||
fan.h | ||
glue.c | ||
hed.c | ||
internal.h | ||
ioapic.c | ||
irq.c | ||
Kconfig | ||
Makefile | ||
nvs.c | ||
osi.c | ||
osl.c | ||
pci_irq.c | ||
pci_link.c | ||
pci_mcfg.c | ||
pci_root.c | ||
pci_slot.c | ||
pfr_telemetry.c | ||
pfr_update.c | ||
platform_profile.c | ||
power.c | ||
pptt.c | ||
prmt.c | ||
proc.c | ||
processor_core.c | ||
processor_driver.c | ||
processor_idle.c | ||
processor_pdc.c | ||
processor_perflib.c | ||
processor_thermal.c | ||
processor_throttling.c | ||
property.c | ||
reboot.c | ||
resource.c | ||
sbs.c | ||
sbshc.c | ||
sbshc.h | ||
scan.c | ||
sleep.c | ||
sleep.h | ||
spcr.c | ||
sysfs.c | ||
tables.c | ||
thermal.c | ||
tiny-power-button.c | ||
utils.c | ||
video_detect.c | ||
viot.c | ||
wakeup.c |