linux/sound/soc
Nathan Chancellor 7d3ac70d82
ASoC: codes: src4xxx: Avoid clang -Wsometimes-uninitialized in src4xxx_hw_params()
Clang warns:

  sound/soc/codecs/src4xxx.c:280:3: error: variable 'd' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
                  default:
                  ^~~~~~~
  sound/soc/codecs/src4xxx.c:298:59: note: uninitialized use occurs here
                  ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_11, d);
                                                                          ^
  sound/soc/codecs/src4xxx.c:223:20: note: initialize the variable 'd' to silence this warning
          int val, pj, jd, d;
                            ^
                            = 0
  sound/soc/codecs/src4xxx.c:280:3: error: variable 'jd' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
                  default:
                  ^~~~~~~
  sound/soc/codecs/src4xxx.c:293:59: note: uninitialized use occurs here
                  ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_10, jd);
                                                                          ^~
  sound/soc/codecs/src4xxx.c:223:17: note: initialize the variable 'jd' to silence this warning
          int val, pj, jd, d;
                        ^
                          = 0
  sound/soc/codecs/src4xxx.c:280:3: error: variable 'pj' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
                  default:
                  ^~~~~~~
  sound/soc/codecs/src4xxx.c:288:59: note: uninitialized use occurs here
                  ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_0F, pj);
                                                                          ^~
  sound/soc/codecs/src4xxx.c:223:13: note: initialize the variable 'pj' to silence this warning
          int val, pj, jd, d;
                    ^
                      = 0
  3 errors generated.

The datasheet does not have any default values for these regmap values
so pick some arbitrary values and print to the user that this is the
case to silence the warnings.

Link: https://github.com/ClangBuiltLinux/linux/issues/1691
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: "Sudip Mukherjee (Codethink)" <sudipm.mukherjee@gmail.com>
Suggested-by: Matt Flax <flatmax@flatmax.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Matt Flax <flatmax@flatmax.com>
Link: https://lore.kernel.org/r/20220823151939.2493697-1-nathan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
2022-08-23 22:54:30 +01:00
..
adi ASoC: adi: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:34 +01:00
amd ASoC: amd: acp: remove unnecessary NULL checks 2022-08-19 13:20:00 +01:00
atmel ASoC: atmel_ssc_dai: Remove the unneeded result variable 2022-08-23 13:04:51 +01:00
au1x ASoC: au1x: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:39 +01:00
bcm sound updates for 6.0-rc1 2022-08-06 10:19:51 -07:00
cirrus ASoC: ep93xx: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:20 +01:00
codecs ASoC: codes: src4xxx: Avoid clang -Wsometimes-uninitialized in src4xxx_hw_params() 2022-08-23 22:54:30 +01:00
dwc ASoC: dwc: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:35 +01:00
fsl ASoC: fsl_sai: Update slots number according to bclk_ratio 2022-08-23 19:52:36 +01:00
generic ASoC: simple-card-utils: Fixup DAI sample format 2022-08-15 01:19:55 +01:00
hisilicon ASoC: hisilicon: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:24 +01:00
img ASoC: Refactor non_legacy_dai_naming flag 2022-06-29 16:58:08 +01:00
intel ASoC: Intel: HSW and BDW updates 2022-08-16 17:33:11 +01:00
jz4740 ASoC: jz4740-i2s: Remove unused 'mem' resource 2022-07-20 21:43:53 +01:00
kirkwood
mediatek ASoC: mediatek: mt8186: rename sound card name 2022-08-23 13:04:50 +01:00
meson ASoC: meson: Remove now redundant non_legacy_dai_naming flag 2022-06-27 13:16:48 +01:00
mxs ASoC: mxs-saif: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:43 +01:00
pxa ASoC: pxa: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:40 +01:00
qcom ASoC: qcom: qdsp6: q6prm: add new clocks 2022-08-17 13:00:28 +01:00
rockchip ASoC: rockchip-i2s: Undo BCLK pinctrl changes 2022-07-14 13:25:52 +01:00
samsung ASoC: samsung: Use iio_get_channel_type() accessor. 2022-08-22 14:07:22 +01:00
sh Merge remote-tracking branch 'asoc/for-5.20' into asoc-6.0 2022-08-15 00:33:32 +01:00
sof ASoC: SOF: Intel: hda: Skip IMR boot after a firmware crash or boot failure 2022-08-23 19:52:41 +01:00
spear ASoC: spear: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:18 +01:00
sprd
sti ASoC: sti-uniperf: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:29 +01:00
stm ASoC: stm32: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:20 +01:00
sunxi ASoC: Refactor non_legacy_dai_naming flag 2022-06-29 16:58:08 +01:00
tegra ASoC: tegra: tegra20_das: Drop write-only driver data member 2022-07-05 19:54:00 +01:00
ti ASoC: omap: Replace sprintf() with sysfs_emit() 2022-08-15 01:19:51 +01:00
uniphier ASoC: uniphier: Remove now redundant non_legacy_dai_naming flag 2022-06-27 13:16:55 +01:00
ux500 ASoC: ux500: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:41 +01:00
xilinx ASoC: xilinx: Suppress second error message about reset failure in .remove() 2022-07-05 16:44:31 +01:00
xtensa ASoC: xtensa: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:33 +01:00
Kconfig ASoC: soc-utils: Add kunit test for snd_soc_tdm_params_to_bclk() 2022-04-05 18:27:56 +01:00
Makefile ASoC: Makefile: Fix simultaneous build of KUNIT tests 2022-07-20 21:43:52 +01:00
soc-ac97.c ASoC: Variable type completion 2022-08-17 13:00:27 +01:00
soc-acpi.c
soc-card.c ASoC: Introduce 'fixup_controls' card method 2022-06-10 13:32:20 +01:00
soc-component.c ASoC: soc-component: Update handling to component delays 2022-05-16 12:58:41 +01:00
soc-compress.c
soc-core.c ASoC: core: Replace sprintf() with sysfs_emit() 2022-08-15 01:19:49 +01:00
soc-dai.c ASoC: Change handling of unimplemented set_bclk_ratio 2022-08-19 13:19:59 +01:00
soc-dapm.c ASoC: DAPM: Replace sprintf() calls with sysfs_emit_at() 2022-08-15 01:19:50 +01:00
soc-devres.c
soc-generic-dmaengine-pcm.c ASoC: soc-generic-dmaengine-pcm: Use default config when none is given 2022-05-04 15:31:19 +01:00
soc-jack.c ASoC: soc-card: Create jack kcontrol without pins 2022-04-14 17:37:21 +01:00
soc-link.c
soc-ops.c ASoC: ops: Fix integer detection for when max possible values > 1 2022-06-17 18:25:23 +01:00
soc-pcm.c ASoC: soc-pcm.c: summarize related settings at soc_new_pcm() 2022-08-22 14:07:21 +01:00
soc-topology-test.c ASoC: topology: KUnit: Remove now redundant non_legacy_dai_naming flag 2022-06-27 13:16:54 +01:00
soc-topology.c ASoC: topology: Drop superfluous check of CONFIG_SND_CTL_VALIDATION 2022-06-15 07:45:26 +02:00
soc-utils-test.c ASoC: soc-utils-test: Add test for snd_soc_params_to_bclk() 2022-08-17 15:19:14 +01:00
soc-utils.c ASoC: soc-utils: Improve kerneldoc for snd_soc_tdm_params_to_bclk() 2022-08-15 17:23:26 +01:00