659ab7a49c
USB devices cannot perform DMA and hence have no dma_mask set in their
device structure. Therefore importing dmabuf into a USB-based driver
fails, which breaks joining and mirroring of display in X11.
For USB devices, pick the associated USB controller as attachment device.
This allows the DRM import helpers to perform the DMA setup. If the DMA
controller does not support DMA transfers, we're out of luck and cannot
import. Our current USB-based DRM drivers don't use DMA, so the actual
DMA device is not important.
Tested by joining/mirroring displays of udl and radeon under Gnome/X11.
v8:
* release dmadev if device initialization fails (Noralf)
* fix commit description (Noralf)
v7:
* fix use-before-init bug in gm12u320 (Dan)
v6:
* implement workaround in DRM drivers and hold reference to
DMA device while USB device is in use
* remove dev_is_usb() (Greg)
* collapse USB helper into usb_intf_get_dma_device() (Alan)
* integrate Daniel's TODO statement (Daniel)
* fix typos (Greg)
v5:
* provide a helper for USB interfaces (Alan)
* add FIXME item to documentation and TODO list (Daniel)
v4:
* implement workaround with USB helper functions (Greg)
* use struct usb_device->bus->sysdev as DMA device (Takashi)
v3:
* drop gem_create_object
* use DMA mask of USB controller, if any (Daniel, Christian, Noralf)
v2:
* move fix to importer side (Christian, Daniel)
* update SHMEM and CMA helpers for new PRIME callbacks
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 6eb0233ec2d0 ("usb: don't inherity DMA properties for USB devices")
Tested-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Christian König <christian.koenig@amd.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Noralf Trønnes <noralf@tronnes.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <stable@vger.kernel.org> # v5.10+
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20210303133229.3288-1-tzimmermann@suse.de
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
111 lines
3.0 KiB
C
111 lines
3.0 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* Copyright (C) 2012 Red Hat
|
|
*
|
|
* based in parts on udlfb.c:
|
|
* Copyright (C) 2009 Roberto De Ioris <roberto@unbit.it>
|
|
* Copyright (C) 2009 Jaya Kumar <jayakumar.lkml@gmail.com>
|
|
* Copyright (C) 2009 Bernie Thompson <bernie@plugable.com>
|
|
*/
|
|
|
|
#ifndef UDL_DRV_H
|
|
#define UDL_DRV_H
|
|
|
|
#include <linux/mm_types.h>
|
|
#include <linux/usb.h>
|
|
|
|
#include <drm/drm_device.h>
|
|
#include <drm/drm_framebuffer.h>
|
|
#include <drm/drm_gem.h>
|
|
#include <drm/drm_simple_kms_helper.h>
|
|
|
|
struct drm_mode_create_dumb;
|
|
|
|
#define DRIVER_NAME "udl"
|
|
#define DRIVER_DESC "DisplayLink"
|
|
#define DRIVER_DATE "20120220"
|
|
|
|
#define DRIVER_MAJOR 0
|
|
#define DRIVER_MINOR 0
|
|
#define DRIVER_PATCHLEVEL 1
|
|
|
|
struct udl_device;
|
|
|
|
struct urb_node {
|
|
struct list_head entry;
|
|
struct udl_device *dev;
|
|
struct delayed_work release_urb_work;
|
|
struct urb *urb;
|
|
};
|
|
|
|
struct urb_list {
|
|
struct list_head list;
|
|
spinlock_t lock;
|
|
struct semaphore limit_sem;
|
|
int available;
|
|
int count;
|
|
size_t size;
|
|
};
|
|
|
|
struct udl_device {
|
|
struct drm_device drm;
|
|
struct device *dev;
|
|
struct device *dmadev;
|
|
|
|
struct drm_simple_display_pipe display_pipe;
|
|
|
|
struct mutex gem_lock;
|
|
|
|
int sku_pixel_limit;
|
|
|
|
struct urb_list urbs;
|
|
|
|
char mode_buf[1024];
|
|
uint32_t mode_buf_len;
|
|
};
|
|
|
|
#define to_udl(x) container_of(x, struct udl_device, drm)
|
|
|
|
static inline struct usb_device *udl_to_usb_device(struct udl_device *udl)
|
|
{
|
|
return interface_to_usbdev(to_usb_interface(udl->drm.dev));
|
|
}
|
|
|
|
/* modeset */
|
|
int udl_modeset_init(struct drm_device *dev);
|
|
struct drm_connector *udl_connector_init(struct drm_device *dev);
|
|
|
|
struct urb *udl_get_urb(struct drm_device *dev);
|
|
|
|
int udl_submit_urb(struct drm_device *dev, struct urb *urb, size_t len);
|
|
void udl_urb_completion(struct urb *urb);
|
|
|
|
int udl_init(struct udl_device *udl);
|
|
|
|
int udl_render_hline(struct drm_device *dev, int log_bpp, struct urb **urb_ptr,
|
|
const char *front, char **urb_buf_ptr,
|
|
u32 byte_offset, u32 device_byte_offset, u32 byte_width);
|
|
|
|
int udl_drop_usb(struct drm_device *dev);
|
|
|
|
#define CMD_WRITE_RAW8 "\xAF\x60" /**< 8 bit raw write command. */
|
|
#define CMD_WRITE_RL8 "\xAF\x61" /**< 8 bit run length command. */
|
|
#define CMD_WRITE_COPY8 "\xAF\x62" /**< 8 bit copy command. */
|
|
#define CMD_WRITE_RLX8 "\xAF\x63" /**< 8 bit extended run length command. */
|
|
|
|
#define CMD_WRITE_RAW16 "\xAF\x68" /**< 16 bit raw write command. */
|
|
#define CMD_WRITE_RL16 "\xAF\x69" /**< 16 bit run length command. */
|
|
#define CMD_WRITE_COPY16 "\xAF\x6A" /**< 16 bit copy command. */
|
|
#define CMD_WRITE_RLX16 "\xAF\x6B" /**< 16 bit extended run length command. */
|
|
|
|
/* On/Off for driving the DisplayLink framebuffer to the display */
|
|
#define UDL_REG_BLANK_MODE 0x1f
|
|
|
|
#define UDL_BLANK_MODE_ON 0x00 /* hsync and vsync on, visible */
|
|
#define UDL_BLANK_MODE_BLANKED 0x01 /* hsync and vsync on, blanked */
|
|
#define UDL_BLANK_MODE_VSYNC_OFF 0x03 /* vsync off, blanked */
|
|
#define UDL_BLANK_MODE_HSYNC_OFF 0x05 /* hsync off, blanked */
|
|
#define UDL_BLANK_MODE_POWERDOWN 0x07 /* powered off; requires modeset */
|
|
|
|
#endif
|