bf7660dab3
There is a mix of drivers using either 'depends on HID' or 'select HID',
which causes both circular dependencies and missed dependencies for
a 'select':
WARNING: unment direct dependencies for HID
Depends on [m]: HID_SUPPORT [=y] && INPUT [=m]
Selected by [y]:
- AMD_SFH_HID [=y] && HID_SUPPORT [=y] && (X86_64 || COMPILE_TEST [=y]) && PCI [=y]
Selected by [m]:
- I2C_HID_CORE [=m] && HID_SUPPORT [=y]
WARNING: unmet direct dependencies detected for INPUT_FF_MEMLESS
Depends on [m]: INPUT [=m]
Selected by [y]:
- DRAGONRISE_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_DRAGONRISE [=y]
- HID_MICROSOFT [=y] && HID_SUPPORT [=y] && HID [=y]
- GREENASIA_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_GREENASIA [=y]
Selected by [m]:
- INPUT_ARIZONA_HAPTICS [=m] && INPUT [=m] && INPUT_MISC [=y] && MFD_ARIZONA [=y] && SND_SOC [=m]
- INPUT_PM8XXX_VIBRATOR [=m] && INPUT [=m] && INPUT_MISC [=y] && (MFD_PM8XXX [=m] || MFD_SPMI_PMIC [=n])
- INPUT_MAX8997_HAPTIC [=m] && INPUT [=m] && INPUT_MISC [=y] && PWM [=y] && MFD_MAX8997 [=y]
- INPUT_GPIO_VIBRA [=m] && INPUT [=m] && INPUT_MISC [=y] && (GPIOLIB [=y] || COMPILE_TEST [=y])
- INPUT_REGULATOR_HAPTIC [=m] && INPUT [=m] && INPUT_MISC [=y] && REGULATOR [=y]
- INPUT_TWL6040_VIBRA [=m] && INPUT [=m] && INPUT_MISC [=y] && TWL6040_CORE [=y]
- INPUT_PWM_VIBRA [=m] && INPUT [=m] && INPUT_MISC [=y] && PWM [=y]
- INPUT_DRV260X_HAPTICS [=m] && INPUT_MISC [=y] && INPUT [=m] && I2C [=y] && (GPIOLIB [=y] || COMPILE_TEST [=y])
- INPUT_DRV2665_HAPTICS [=m] && INPUT_MISC [=y] && INPUT [=m] && I2C [=y]
- INPUT_DRV2667_HAPTICS [=m] && INPUT_MISC [=y] && INPUT [=m] && I2C [=y]
- INPUT_SC27XX_VIBRA [=m] && INPUT [=m] && INPUT_MISC [=y] && (MFD_SC27XX_PMIC [=y] || COMPILE_TEST [=y])
- HID_MAYFLASH [=m] && HID_SUPPORT [=y] && HID [=y]
Avoid this by changing all HID client drivers to use 'depends on HID'.
For I2C_HID, this requires a larger rework of the Kconfig description,
but it hopefully becomes easier to understand without the complex
I2C_HID_CORE definition.
Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
73 lines
2.0 KiB
Plaintext
73 lines
2.0 KiB
Plaintext
# SPDX-License-Identifier: GPL-2.0-only
|
|
menuconfig I2C_HID
|
|
tristate "I2C HID support"
|
|
default y
|
|
depends on I2C && INPUT && HID
|
|
|
|
if I2C_HID
|
|
|
|
config I2C_HID_ACPI
|
|
tristate "HID over I2C transport layer ACPI driver"
|
|
depends on ACPI
|
|
select I2C_HID_CORE
|
|
help
|
|
Say Y here if you use a keyboard, a touchpad, a touchscreen, or any
|
|
other HID based devices which is connected to your computer via I2C.
|
|
This driver supports ACPI-based systems.
|
|
|
|
If unsure, say N.
|
|
|
|
This support is also available as a module. If so, the module
|
|
will be called i2c-hid-acpi. It will also build/depend on the
|
|
module i2c-hid.
|
|
|
|
config I2C_HID_OF
|
|
tristate "HID over I2C transport layer Open Firmware driver"
|
|
depends on OF
|
|
select I2C_HID_CORE
|
|
help
|
|
Say Y here if you use a keyboard, a touchpad, a touchscreen, or any
|
|
other HID based devices which is connected to your computer via I2C.
|
|
This driver supports Open Firmware (Device Tree)-based systems.
|
|
|
|
If unsure, say N.
|
|
|
|
This support is also available as a module. If so, the module
|
|
will be called i2c-hid-of. It will also build/depend on the
|
|
module i2c-hid.
|
|
|
|
config I2C_HID_OF_ELAN
|
|
tristate "Driver for Elan hid-i2c based devices on OF systems"
|
|
depends on OF
|
|
select I2C_HID_CORE
|
|
help
|
|
Say Y here if you want support for Elan i2c devices that use
|
|
the i2c-hid protocol on Open Firmware (Device Tree)-based
|
|
systems.
|
|
|
|
If unsure, say N.
|
|
|
|
This support is also available as a module. If so, the module
|
|
will be called i2c-hid-of-elan. It will also build/depend on
|
|
the module i2c-hid.
|
|
|
|
config I2C_HID_OF_GOODIX
|
|
tristate "Driver for Goodix hid-i2c based devices on OF systems"
|
|
depends on OF
|
|
select I2C_HID_CORE
|
|
help
|
|
Say Y here if you want support for Goodix i2c devices that use
|
|
the i2c-hid protocol on Open Firmware (Device Tree)-based
|
|
systems.
|
|
|
|
If unsure, say N.
|
|
|
|
This support is also available as a module. If so, the module
|
|
will be called i2c-hid-of-goodix. It will also build/depend on
|
|
the module i2c-hid.
|
|
|
|
config I2C_HID_CORE
|
|
tristate
|
|
endif
|
|
|