Xin Long ae954bbc45 sctp: move the active_key update after sh_keys is added ... In commit 58acd10092 ("sctp: update active_key for asoc when old key is being replaced"), sctp_auth_asoc_init_active_key() is called to update the active_key right after the old key is deleted and before the new key is added, and it caused that the active_key could be found with the key_id. In Ying Xu's testing, the BUG_ON in sctp_auth_asoc_init_active_key() was triggered: [ ] kernel BUG at net/sctp/auth.c:416! [ ] RIP: 0010:sctp_auth_asoc_init_active_key.part.8+0xe7/0xf0 [sctp] [ ] Call Trace: [ ] sctp_auth_set_key+0x16d/0x1b0 [sctp] [ ] sctp_setsockopt.part.33+0x1ba9/0x2bd0 [sctp] [ ] __sys_setsockopt+0xd6/0x1d0 [ ] __x64_sys_setsockopt+0x20/0x30 [ ] do_syscall_64+0x5b/0x1a0 So fix it by moving the active_key update after sh_keys is added. Fixes: 58acd10092 ("sctp: update active_key for asoc when old key is being replaced") Reported-by: Ying Xu <yinxu@redhat.com> Signed-off-by: Xin Long <lucien.xin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2021-08-03 11:43:43 +01:00
..
associola.c	sctp: enable PLPMTUD when the transport is ready	2021-06-22 11:28:52 -07:00
auth.c	sctp: move the active_key update after sh_keys is added	2021-08-03 11:43:43 +01:00
bind_addr.c	sctp: validate from_addr_param return	2021-06-28 15:34:50 -07:00
chunk.c	net: sctp: chunk.c: delete duplicated word	2020-08-24 16:21:43 -07:00
debug.c	sctp: add the probe timer in transport for PLPMTUD	2021-06-22 11:28:52 -07:00
diag.c	net: Use nlmsg_unicast() instead of netlink_unicast()	2021-07-13 09:28:29 -07:00
endpointola.c	sctp: get netns from asoc and ep base	2019-12-09 20:14:01 -08:00
input.c	sctp: fix return value check in __sctp_rcv_asconf_lookup	2021-07-28 09:25:18 +01:00
inqueue.c
ipv6.c	sctp: delete addr based on sin6_scope_id	2021-07-26 12:34:03 +01:00
Kconfig	sctp: create udp4 sock and add its encap_rcv	2020-10-30 15:23:52 -07:00
Makefile
objcnt.c
offload.c	sctp: remove the NETIF_F_SG flag before calling skb_segment	2021-01-16 19:05:59 -08:00
output.c	sctp: do not update transport pathmtu if SPP_PMTUD_ENABLE is not set	2021-07-21 14:17:58 -07:00
outqueue.c	sctp: do the basic send and recv for PLPMTUD probe	2021-06-22 11:28:52 -07:00
primitive.c
proc.c	net: fix iteration for sctp transport seq_files	2021-02-08 10:15:49 -08:00
protocol.c	sctp: move 198 addresses from unusable to private scope	2021-07-01 11:47:13 -07:00
sm_make_chunk.c	sctp: prevent info leak in sctp_make_heartbeat()	2021-07-01 11:16:38 -07:00
sm_sideeffect.c	sctp: add the probe timer in transport for PLPMTUD	2021-06-22 11:28:52 -07:00
sm_statefuns.c	sctp: improve the code for pmtu probe send and recv update	2021-07-25 23:06:02 +01:00
sm_statetable.c	sctp: add the probe timer in transport for PLPMTUD	2021-06-22 11:28:52 -07:00
socket.c	sctp: trim optlen when it's a huge value in sctp_setsockopt	2021-07-18 09:47:29 -07:00
stream_interleave.c	sctp: get netns from asoc and ep base	2019-12-09 20:14:01 -08:00
stream_sched_prio.c
stream_sched_rr.c
stream_sched.c	sctp: rename asoc intl_enable to asoc peer.intl_capable	2019-07-08 20:16:25 -07:00
stream.c	net: sctp: Fix negotiation of the number of data streams.	2020-08-20 16:37:37 -07:00
sysctl.c	sctp: add probe_interval in sysctl and sock/asoc/transport	2021-06-22 11:28:51 -07:00
transport.c	sctp: send pmtu probe only if packet loss in Search Complete state	2021-07-25 23:06:02 +01:00
tsnmap.c	net: sctp: trivial: fix typo in comment	2021-03-04 13:48:32 -08:00
ulpevent.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-05-31 17:48:46 -07:00
ulpqueue.c	net: sctp: ulpqueue.c: delete duplicated word	2020-08-24 16:21:43 -07:00