iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
1047d4ac6677e8fb0cd787da90dec196de5803a5
linux/net/mac80211
History
Peter Seiderer 042f8d5a13 mac80211: minstrel_ht: fix where rate stats are stored (fixes debugfs output) 
[ Upstream commit 5c6dd7bd56 ]

Using an ath9k card the debugfs output of minstrel_ht looks like the following
(note the zero values for the first four rates sum-of success/attempts):

             best    ____________rate__________    ____statistics___    _____last____    ______sum-of________
mode guard #  rate   [name   idx airtime  max_tp]  [avg(tp) avg(prob)]  [retry|suc|att]  [#success | #attempts]
OFDM       1    DP     6.0M  272    1640     5.2       3.1      53.8       3     0 0             0   0
OFDM       1   C       9.0M  273    1104     7.7       4.6      53.8       4     0 0             0   0
OFDM       1  B       12.0M  274     836    10.0       6.0      53.8       4     0 0             0   0
OFDM       1 A    S   18.0M  275     568    14.3       8.5      53.8       5     0 0             0   0
OFDM       1      S   24.0M  276     436    18.1       0.0       0.0       5     0 1            80   1778
OFDM       1          36.0M  277     300    24.9       0.0       0.0       0     0 1             0   107
OFDM       1      S   48.0M  278     236    30.4       0.0       0.0       0     0 0             0   75
OFDM       1          54.0M  279     212    33.0       0.0       0.0       0     0 0             0   72

Total packet count::    ideal 16582      lookaround 885
Average # of aggregated frames per A-MPDU: 1.0

Debugging showed that the rate statistics for the first four rates where
stored in the MINSTREL_CCK_GROUP instead of the MINSTREL_OFDM_GROUP because
in minstrel_ht_get_stats() the supported check was not honoured as done in
various other places, e.g net/mac80211/rc80211_minstrel_ht_debugfs.c:

 74                 if (!(mi->supported[i] & BIT(j)))
 75                         continue;

With the patch applied the output looks good:

              best    ____________rate__________    ____statistics___    _____last____    ______sum-of________
mode guard #  rate   [name   idx airtime  max_tp]  [avg(tp) avg(prob)]  [retry|suc|att]  [#success | #attempts]
OFDM       1    D      6.0M  272    1640     5.2       5.2     100.0       3     0 0             1   1
OFDM       1   C       9.0M  273    1104     7.7       7.7     100.0       4     0 0            38   38
OFDM       1  B       12.0M  274     836    10.0       9.9      89.5       4     2 2           372   395
OFDM       1 A   P    18.0M  275     568    14.3      14.3      97.2       5    52 53         6956   7181
OFDM       1      S   24.0M  276     436    18.1       0.0       0.0       0     0 1             6   163
OFDM       1          36.0M  277     300    24.9       0.0       0.0       0     0 1             0   35
OFDM       1      S   48.0M  278     236    30.4       0.0       0.0       0     0 0             0   38
OFDM       1      S   54.0M  279     212    33.0       0.0       0.0       0     0 0             0   38

Total packet count::    ideal 7097      lookaround 287
Average # of aggregated frames per A-MPDU: 1.0

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Link: https://lore.kernel.org/r/20220404165414.1036-1-ps.report@gmx.net
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-06-09 10:22:31 +02:00
..
aead_api.c
mac80211: Check crypto_aead_encrypt for errors
2021-03-16 21:20:41 +01:00
aead_api.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
aes_ccm.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
aes_cmac.c
mac80211: aes_cmac: check crypto_shash_setkey() return value
2021-04-19 12:01:40 +02:00
aes_cmac.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
aes_gcm.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
aes_gmac.c
mac80211: Check crypto_aead_encrypt for errors
2021-03-16 21:20:41 +01:00
aes_gmac.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
agg-rx.c
mac80211: fix lookup when adding AddBA extension element
2021-12-22 09:32:42 +01:00
agg-tx.c
mac80211: refuse aggregations sessions before authorized
2022-03-19 13:47:48 +01:00
airtime.c
mac80211: add AQL support for VHT160 tx rates
2020-09-18 11:36:03 +02:00
cfg.c
mac80211: fix potential double free on mesh join
2022-03-28 09:58:45 +02:00
chan.c
mac80211: handle rate control (RC) racing with chanctx definition
2021-06-23 11:29:14 +02:00
debug.h
…
debugfs_key.c
mac80211: remove trailing semicolon in macro definitions
2020-12-11 12:51:55 +01:00
debugfs_key.h
mac80211: Support BIGTK configuration for Beacon protection
2020-02-24 10:35:57 +01:00
debugfs_netdev.c
mac80211: Switch to a virtual time-based airtime scheduler
2021-06-23 18:12:00 +02:00
debugfs_netdev.h
…
debugfs_sta.c
mac80211: Switch to a virtual time-based airtime scheduler
2021-06-23 18:12:00 +02:00
debugfs_sta.h
…
debugfs.c
mac80211: Switch to a virtual time-based airtime scheduler
2021-06-23 18:12:00 +02:00
debugfs.h
…
driver-ops.c
mac80211: fix station rate table updates on assoc
2021-02-01 15:07:09 +01:00
driver-ops.h
mac80211: mark TX-during-stop for TX in in_reconfig
2021-12-22 09:32:34 +01:00
ethtool.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 432
2019-06-05 17:37:16 +02:00
fils_aead.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
fils_aead.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
he.c
mac80211: fix NULL ptr dereference during mesh peer connection for non HE devices
2021-06-23 18:06:44 +02:00
ht.c
mac80211: allow SMPS requests only in client mode
2021-06-23 11:29:13 +02:00
ibss.c
mac80211: Remove unnecessary variable and label
2021-08-13 09:58:25 +02:00
ieee80211_i.h
mac80211: limit bandwidth in HE capabilities
2022-04-08 14:23:28 +02:00
iface.c
mac80211: fix monitor_sdata RCU/locking assertions
2021-11-25 09:48:34 +01:00
Kconfig
ath9k: fix build error with LEDS_CLASS=m
2021-01-28 09:29:34 +02:00
key.c
mac80211: prevent mixed key and fragment cache attacks
2021-05-11 20:12:51 +02:00
key.h
mac80211: prevent mixed key and fragment cache attacks
2021-05-11 20:12:51 +02:00
led.c
mac80211: don't open-code LED manipulations
2021-06-23 11:29:12 +02:00
led.h
mac80211: fix throughput LED trigger
2021-12-08 09:04:38 +01:00
main.c
mac80211: Remove a couple of obsolete TODO
2022-04-08 14:23:28 +02:00
Makefile
mac80211: remove legacy minstrel rate control
2021-01-22 09:11:37 +01:00
mesh_hwmp.c
mac80211: fix some spelling mistakes
2021-06-23 12:36:32 +02:00
mesh_pathtbl.c
mac80211: mesh: embedd mesh_paths and mpp_paths into ieee80211_if_mesh
2022-01-11 15:35:13 +01:00
mesh_plink.c
mac80211: fix some spelling mistakes
2021-06-23 12:36:32 +02:00
mesh_ps.c
mac80211: mesh: fix potentially unaligned access
2021-09-23 13:25:09 +02:00
mesh_sync.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
mesh.c
mac80211: limit bandwidth in HE capabilities
2022-04-08 14:23:28 +02:00
mesh.h
mac80211: mesh: embedd mesh_paths and mpp_paths into ieee80211_if_mesh
2022-01-11 15:35:13 +01:00
michael.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
michael.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
mlme.c
mac80211: Reset MBSSID parameters upon connection
2022-05-18 10:26:47 +02:00
ocb.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
offchannel.c
mac80211: Inform AP when returning operating channel
2020-09-28 13:18:53 +02:00
pm.c
cfg80211: avoid holding the RTNL when calling the driver
2021-01-26 11:55:50 +01:00
rate.c
Revert "mac80211: do not use low data rates for data frames with no ack flag"
2021-09-23 12:59:29 +02:00
rate.h
mac80211: populate debugfs only after cfg80211 init
2020-04-24 11:30:13 +02:00
rc80211_minstrel_ht_debugfs.c
mac80211: minstrel_ht: show sampling rates in debugfs
2021-02-12 08:58:11 +01:00
rc80211_minstrel_ht.c
mac80211: minstrel_ht: fix where rate stats are stored (fixes debugfs output)
2022-06-09 10:22:31 +02:00
rc80211_minstrel_ht.h
mac80211: minstrel_ht: remove sample rate switching code for constrained devices
2021-02-12 08:58:22 +01:00
rx.c
mac80211: fix rx reordering with non explicit / psmp ack policy
2022-05-25 09:57:35 +02:00
s1g.c
mac80211: twt: don't use potentially unaligned pointer
2021-11-18 19:16:25 +01:00
scan.c
mac80211: fix skb length check in ieee80211_scan_rx()
2021-05-31 21:39:10 +02:00
spectmgmt.c
mac80211: 160MHz with extended NSS BW in CSA
2021-01-21 13:39:11 +01:00
sta_info.c
mac80211: Reject zero MAC address in sta_info_insert_check()
2021-08-13 09:50:43 +02:00
sta_info.h
mac80211: fix regression in SSN handling of addba tx
2021-12-22 09:32:34 +01:00
status.c
mac80211: introduce individual TWT support in AP mode
2021-08-24 10:30:43 +02:00
tdls.c
mac80211: use sdata->skb_queue for TDLS
2021-06-23 11:00:17 +02:00
tkip.c
mac80211: Fix TKIP replay protection immediately after key setup
2020-01-15 09:52:12 +01:00
tkip.h
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
trace_msg.h
mac80211: Increase MAX_MSG_LEN
2019-03-29 11:20:36 +01:00
trace.c
…
trace.h
mac80211: introduce individual TWT support in AP mode
2021-08-24 10:30:43 +02:00
tx.c
mac80211: fix rate control for retransmitted frames
2021-12-22 09:32:34 +01:00
util.c
mac80211: limit bandwidth in HE capabilities
2022-04-08 14:23:28 +02:00
vht.c
mac80211: remove NSS number of 160MHz if not support 160MHz for HE
2021-01-21 13:45:13 +01:00
wep.c
mac80211: make ieee80211_wep_init() return void
2020-02-07 12:40:34 +01:00
wep.h
mac80211: make ieee80211_wep_init() return void
2020-02-07 12:40:34 +01:00
wme.c
mac80211: drop check for DONT_REORDER in __ieee80211_select_queue
2021-11-25 09:48:47 +01:00
wme.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
wpa.c
mac80211: fix use-after-free in CCMP/GCMP RX
2021-09-27 11:59:49 +02:00
wpa.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00