664e68bcab
We get a warning from 'make headers_check' about a newly introduced usage
of integer types in the scsi/scsi_bsg_ufs.h uapi header:
usr/include/scsi/scsi_bsg_ufs.h:18: found __[us]{8,16,32,64} type without #include <linux/types.h>
Aside from the missing linux/types.h inclusion, I also noticed that it
uses the wrong types: 'u32' is not available at all in user space, and
'uint32_t' depends on the inclusion of a standard header that we should
not include from kernel headers.
Change the all to __u32 and similar types here.
I also note the usage of '__be32' and '__be16' that seems unfortunate for
a user space API. I wonder if it would be better to define the interface
in terms of a CPU-endian structure and convert it in kernel space.
Fixes: e77044c5a8 ("scsi: ufs-bsg: Add support for uic commands in ufs_bsg_request()")
Fixes: df032bf27a ("scsi: ufs: Add a bsg endpoint that supports UPIUs")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
107 lines
2.7 KiB
C
107 lines
2.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* UFS Transport SGIO v4 BSG Message Support
|
|
*
|
|
* Copyright (C) 2011-2013 Samsung India Software Operations
|
|
* Copyright (C) 2018 Western Digital Corporation
|
|
*/
|
|
#ifndef SCSI_BSG_UFS_H
|
|
#define SCSI_BSG_UFS_H
|
|
|
|
#include <linux/types.h>
|
|
/*
|
|
* This file intended to be included by both kernel and user space
|
|
*/
|
|
|
|
#define UFS_CDB_SIZE 16
|
|
#define UPIU_TRANSACTION_UIC_CMD 0x1F
|
|
/* uic commands are 4DW long, per UFSHCI V2.1 paragraph 5.6.1 */
|
|
#define UIC_CMD_SIZE (sizeof(__u32) * 4)
|
|
|
|
/**
|
|
* struct utp_upiu_header - UPIU header structure
|
|
* @dword_0: UPIU header DW-0
|
|
* @dword_1: UPIU header DW-1
|
|
* @dword_2: UPIU header DW-2
|
|
*/
|
|
struct utp_upiu_header {
|
|
__be32 dword_0;
|
|
__be32 dword_1;
|
|
__be32 dword_2;
|
|
};
|
|
|
|
/**
|
|
* struct utp_upiu_query - upiu request buffer structure for
|
|
* query request.
|
|
* @opcode: command to perform B-0
|
|
* @idn: a value that indicates the particular type of data B-1
|
|
* @index: Index to further identify data B-2
|
|
* @selector: Index to further identify data B-3
|
|
* @reserved_osf: spec reserved field B-4,5
|
|
* @length: number of descriptor bytes to read/write B-6,7
|
|
* @value: Attribute value to be written DW-5
|
|
* @reserved: spec reserved DW-6,7
|
|
*/
|
|
struct utp_upiu_query {
|
|
__u8 opcode;
|
|
__u8 idn;
|
|
__u8 index;
|
|
__u8 selector;
|
|
__be16 reserved_osf;
|
|
__be16 length;
|
|
__be32 value;
|
|
__be32 reserved[2];
|
|
};
|
|
|
|
/**
|
|
* struct utp_upiu_cmd - Command UPIU structure
|
|
* @data_transfer_len: Data Transfer Length DW-3
|
|
* @cdb: Command Descriptor Block CDB DW-4 to DW-7
|
|
*/
|
|
struct utp_upiu_cmd {
|
|
__be32 exp_data_transfer_len;
|
|
__u8 cdb[UFS_CDB_SIZE];
|
|
};
|
|
|
|
/**
|
|
* struct utp_upiu_req - general upiu request structure
|
|
* @header:UPIU header structure DW-0 to DW-2
|
|
* @sc: fields structure for scsi command DW-3 to DW-7
|
|
* @qr: fields structure for query request DW-3 to DW-7
|
|
*/
|
|
struct utp_upiu_req {
|
|
struct utp_upiu_header header;
|
|
union {
|
|
struct utp_upiu_cmd sc;
|
|
struct utp_upiu_query qr;
|
|
struct utp_upiu_query tr;
|
|
/* use utp_upiu_query to host the 4 dwords of uic command */
|
|
struct utp_upiu_query uc;
|
|
};
|
|
};
|
|
|
|
/* request (CDB) structure of the sg_io_v4 */
|
|
struct ufs_bsg_request {
|
|
__u32 msgcode;
|
|
struct utp_upiu_req upiu_req;
|
|
};
|
|
|
|
/* response (request sense data) structure of the sg_io_v4 */
|
|
struct ufs_bsg_reply {
|
|
/*
|
|
* The completion result. Result exists in two forms:
|
|
* if negative, it is an -Exxx system errno value. There will
|
|
* be no further reply information supplied.
|
|
* else, it's the 4-byte scsi error result, with driver, host,
|
|
* msg and status fields. The per-msgcode reply structure
|
|
* will contain valid data.
|
|
*/
|
|
__u32 result;
|
|
|
|
/* If there was reply_payload, how much was received? */
|
|
__u32 reply_payload_rcv_len;
|
|
|
|
struct utp_upiu_req upiu_rsp;
|
|
};
|
|
#endif /* UFS_BSG_H */
|