iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Liu Shixin via Jfs-discussion 114ea3cb13 jfs: fix invalid free of JFS_IP(ipimap)->i_imap in diUnmount 
[ Upstream commit 6e2bda2c192d0244b5a78b787ef20aa10cb319b7 ]

syzbot found an invalid-free in diUnmount:

BUG: KASAN: double-free in slab_free mm/slub.c:3661 [inline]
BUG: KASAN: double-free in __kmem_cache_free+0x71/0x110 mm/slub.c:3674
Free of addr ffff88806f410000 by task syz-executor131/3632

 CPU: 0 PID: 3632 Comm: syz-executor131 Not tainted 6.1.0-rc7-syzkaller-00012-gca57f02295f1 #0
 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
 Call Trace:
  <TASK>
  __dump_stack lib/dump_stack.c:88 [inline]
  dump_stack_lvl+0x1b1/0x28e lib/dump_stack.c:106
  print_address_description+0x74/0x340 mm/kasan/report.c:284
  print_report+0x107/0x1f0 mm/kasan/report.c:395
  kasan_report_invalid_free+0xac/0xd0 mm/kasan/report.c:460
  ____kasan_slab_free+0xfb/0x120
  kasan_slab_free include/linux/kasan.h:177 [inline]
  slab_free_hook mm/slub.c:1724 [inline]
  slab_free_freelist_hook+0x12e/0x1a0 mm/slub.c:1750
  slab_free mm/slub.c:3661 [inline]
  __kmem_cache_free+0x71/0x110 mm/slub.c:3674
  diUnmount+0xef/0x100 fs/jfs/jfs_imap.c:195
  jfs_umount+0x108/0x370 fs/jfs/jfs_umount.c:63
  jfs_put_super+0x86/0x190 fs/jfs/super.c:194
  generic_shutdown_super+0x130/0x310 fs/super.c:492
  kill_block_super+0x79/0xd0 fs/super.c:1428
  deactivate_locked_super+0xa7/0xf0 fs/super.c:332
  cleanup_mnt+0x494/0x520 fs/namespace.c:1186
  task_work_run+0x243/0x300 kernel/task_work.c:179
  exit_task_work include/linux/task_work.h:38 [inline]
  do_exit+0x664/0x2070 kernel/exit.c:820
  do_group_exit+0x1fd/0x2b0 kernel/exit.c:950
  __do_sys_exit_group kernel/exit.c:961 [inline]
  __se_sys_exit_group kernel/exit.c:959 [inline]
  __x64_sys_exit_group+0x3b/0x40 kernel/exit.c:959
  do_syscall_x64 arch/x86/entry/common.c:50 [inline]
  do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
  entry_SYSCALL_64_after_hwframe+0x63/0xcd
[...]

JFS_IP(ipimap)->i_imap is not setting to NULL after free in diUnmount.
If jfs_remount() free JFS_IP(ipimap)->i_imap but then failed at diMount().
JFS_IP(ipimap)->i_imap will be freed once again.
Fix this problem by setting JFS_IP(ipimap)->i_imap to NULL after free.

Reported-by: syzbot+90a11e6b1e810785c6ff@syzkaller.appspotmail.com
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-09-23 10:48:16 +02:00
..
9p
9p: missing chunk of "fs/9p: Don't update file type when updating file attributes"
2022-06-25 11:48:57 +02:00
adfs
fs/adfs: super: fix use-after-free bug
2019-08-06 19:06:49 +02:00
affs
affs: initialize fsdata in affs_truncate()
2023-02-06 07:49:38 +01:00
afs
treewide: Remove uninitialized_var() usage
2023-08-11 11:45:01 +02:00
autofs
autofs: fix memory leak of waitqueues in autofs_catatonic_mode
2023-09-23 10:48:15 +02:00
befs
…
bfs
…
btrfs
btrfs: output extra debug info if we failed to find an inline backref
2023-09-23 10:48:15 +02:00
cachefiles
cachefiles: Handle readpage error correctly
2020-11-05 11:08:54 +01:00
ceph
ceph: don't let check_caps skip sending responses for revoke msgs
2023-08-11 11:45:22 +02:00
cifs
new helper: lookup_positive_unlocked()
2023-09-23 10:47:59 +02:00
coda
coda: add error handling for fget
2019-08-06 19:06:51 +02:00
configfs
configfs: fix a race in configfs_{,un}register_subsystem()
2022-03-02 11:38:13 +01:00
cramfs
…
crypto
fscrypt: add fscrypt_symlink_getattr() for computing st_size
2021-09-22 11:47:56 +02:00
debugfs
new helper: lookup_positive_unlocked()
2023-09-23 10:47:59 +02:00
devpts
…
dlm
dlm: fix plock lookup when using multiple lockspaces
2023-09-23 10:48:11 +02:00
ecryptfs
Revert "ecryptfs: replace BUG_ON with error handling code"
2021-05-26 11:48:34 +02:00
efivarfs
efivarfs: revert "fix memory leak in efivarfs_create()"
2020-12-02 08:48:12 +01:00
efs
…
exofs
exofs_mount(): fix leaks on failure exits
2019-12-05 09:20:32 +01:00
exportfs
exportfs: fix 'passing zero to ERR_PTR()' warning
2020-01-27 14:50:02 +01:00
ext2
ext2: fix datatype of block number in ext2_xattr_set2()
2023-09-23 10:48:16 +02:00
ext4
ext4: fix to check return value of freeze_bdev() in ext4_shutdown()
2023-08-11 11:45:30 +02:00
f2fs
f2fs: fix error path handling in truncate_dnode()
2023-08-11 11:45:13 +02:00
fat
treewide: Remove uninitialized_var() usage
2023-08-11 11:45:01 +02:00
freevxfs
…
fscache
fscache: Fix cookie key hashing
2021-09-22 11:48:02 +02:00
fuse
fuse: revalidate: don't invalidate if interrupted
2023-08-11 11:45:24 +02:00
gfs2
gfs2: Fix possible data races in gfs2_show_options()
2023-08-30 16:31:43 +02:00
hfs
hfs: fix missing hfs_bnode_get() in __hfs_bnode_create
2023-03-11 16:31:49 +01:00
hfsplus
treewide: Remove uninitialized_var() usage
2023-08-11 11:45:01 +02:00
hostfs
…
hpfs
…
hugetlbfs
hugetlbfs: hugetlb_fault_mutex_hash() cleanup
2021-06-03 08:38:12 +02:00
isofs
treewide: Remove uninitialized_var() usage
2023-08-11 11:45:01 +02:00
jbd2
jbd2: fix assertion 'jh->b_frozen_data == NULL' failure when journal aborted
2022-08-25 11:15:19 +02:00
jffs2
jffs2: reduce stack usage in jffs2_build_xattr_subsystem()
2023-08-11 11:45:15 +02:00
jfs
jfs: fix invalid free of JFS_IP(ipimap)->i_imap in diUnmount
2023-09-23 10:48:16 +02:00
kernfs
new helper: lookup_positive_unlocked()
2023-09-23 10:47:59 +02:00
lockd
fs: lockd: avoid possible wrong NULL parameter
2023-09-23 10:48:06 +02:00
minix
minix: fix bug when opening a file with O_DIRECT
2022-04-15 14:15:03 +02:00
nfs
NFSv4/pnfs: minor fix for cleanup path in nfs4_get_device_info
2023-09-23 10:48:12 +02:00
nfs_common
nfs_common: need lock during iterate through the list
2020-12-30 11:26:02 +01:00
nfsd
NFSD: da_addr_body field missing in some GETDEVICEINFO replies
2023-09-23 10:48:06 +02:00
nilfs2
nilfs2: fix WARNING in mark_buffer_dirty due to discarded buffer reuse
2023-09-23 10:47:57 +02:00
nls
fs/nls: make load_nls() take a const parameter
2023-09-23 10:47:58 +02:00
notify
fsnotify: fix wrong lockdep annotations
2022-06-14 16:59:20 +02:00
ntfs
ntfs: check overflow when iterating ATTR_RECORDs
2022-11-25 17:40:30 +01:00
ocfs2
fs: ocfs2: namei: check return value of ocfs2_add_entry()
2023-09-23 10:48:01 +02:00
omfs
treewide: Remove uninitialized_var() usage
2023-08-11 11:45:01 +02:00
openpromfs
…
orangefs
orangefs: Fix kmemleak in orangefs_prepare_debugfs_help_string()
2023-01-18 11:30:37 +01:00
overlayfs
new helper: lookup_positive_unlocked()
2023-09-23 10:47:59 +02:00
proc
procfs: block chmod on /proc/thread-self/comm
2023-09-23 10:48:11 +02:00
pstore
pstore/ram: Check start of empty przs during init
2023-09-23 10:48:11 +02:00
qnx4
qnx4: work around gcc false positive warning bug
2021-10-06 15:31:20 +02:00
qnx6
…
quota
quota: fix dqput() to follow the guarantees dquot_srcu should provide
2023-09-23 10:48:02 +02:00
ramfs
ramfs: fix nommu mmap with gaps in the page cache
2020-10-30 10:38:21 +01:00
reiserfs
reiserfs: Check the return value from __getblk()
2023-09-23 10:47:59 +02:00
romfs
romfs: fix uninitialized memory leak in romfs_dev_read()
2020-08-26 10:30:59 +02:00
squashfs
revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"
2023-02-22 12:47:20 +01:00
sysfs
fs: sysfs_emit_at: Remove PAGE_SIZE alignment check
2023-03-22 13:27:08 +01:00
sysv
fs/sysv: Null check to prevent null-ptr-deref bug
2023-08-11 11:45:39 +02:00
tracefs
tracefs: Only clobber mode/uid/gid on remount if asked
2022-09-20 12:26:48 +02:00
ubifs
treewide: Remove uninitialized_var() usage
2023-08-11 11:45:01 +02:00
udf
udf: initialize newblock to 0
2023-09-23 10:48:12 +02:00
ufs
fs/ufs: avoid potential u32 multiplication overflow
2020-08-21 11:05:38 +02:00
xfs
treewide: Remove uninitialized_var() usage
2023-08-11 11:45:01 +02:00
aio.c
aio: fix mremap after fork null-deref
2023-02-22 12:47:19 +01:00
anon_inodes.c
…
attr.c
vfs: Check the truncate maximum size in inode_newsize_ok()
2022-08-25 11:14:53 +02:00
bad_inode.c
…
binfmt_aout.c
binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf
2023-01-18 11:30:42 +01:00
binfmt_elf_fdpic.c
binfmt: Fix error return code in load_elf_fdpic_binary()
2023-01-18 11:30:42 +01:00
binfmt_elf.c
elf: don't use MAP_FIXED_NOREPLACE for elf interpreter mappings
2021-10-06 15:31:24 +02:00
binfmt_em86.c
…
binfmt_flat.c
binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf
2023-01-18 11:30:42 +01:00
binfmt_misc.c
binfmt_misc: fix shift-out-of-bounds in check_special_flags
2023-01-18 11:30:33 +01:00
binfmt_script.c
exec: load_script: Do not exec truncated interpreter path
2019-11-06 13:05:37 +01:00
block_dev.c
block: reexpand iov_iter after read/write
2021-05-22 10:59:49 +02:00
buffer.c
mm: fs: initialize fsdata passed to write_begin/write_end interface
2022-11-25 17:40:29 +01:00
char_dev.c
chardev: fix error handling in cdev_device_add()
2023-01-18 11:30:27 +01:00
compat_binfmt_elf.c
…
compat_ioctl.c
fix compat handling of FICLONERANGE, FIDEDUPERANGE and FS_IOC_FIEMAP
2020-01-09 10:19:07 +01:00
compat.c
…
coredump.c
coredump: fix crash when umh is disabled
2020-05-14 07:57:21 +02:00
d_path.c
…
dax.c
dax: fix cache flush on PMD-mapped pages
2022-06-14 16:59:24 +02:00
dcache.c
fs, fscrypt: clear DCACHE_ENCRYPTED_NAME when unaliasing directory
2020-11-05 11:08:35 +01:00
dcookies.c
…
direct-io.c
fs: direct-io: fix missing sdio->boundary
2021-04-14 08:22:32 +02:00
drop_caches.c
fs: avoid softlockups in s_inodes iterators
2020-01-12 12:17:20 +01:00
eventfd.c
eventfd: prevent underflow for eventfd semaphores
2023-09-23 10:47:59 +02:00
eventpoll.c
ep_create_wakeup_source(): dentry name can change under you...
2020-10-07 08:00:09 +02:00
exec.c
exec: Force single empty string when argv is empty
2022-06-06 08:24:21 +02:00
fcntl.c
fcntl: fix potential deadlock for &fasync_struct.fa_lock
2021-09-22 11:47:50 +02:00
fhandle.c
…
file_table.c
fs: add fget_many() and fput_many()
2021-12-08 08:50:13 +01:00
file.c
fs: prevent out-of-bounds array speculation when closing a file descriptor
2023-03-17 08:31:41 +01:00
filesystems.c
fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()
2020-04-17 10:48:51 +02:00
fs_pin.c
…
fs_struct.c
…
fs-writeback.c
writeback: fix call of incorrect macro
2023-05-17 11:13:23 +02:00
inode.c
fs: fix UAF/GPF bug in nilfs_mdt_destroy
2022-10-26 13:19:16 +02:00
internal.h
acct_on(): don't mess with freeze protection
2019-05-31 06:46:05 -07:00
ioctl.c
…
iomap.c
iomap: fix sub-page uptodate handling
2021-05-22 10:59:50 +02:00
Kconfig
…
Kconfig.binfmt
…
libfs.c
libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value
2023-01-18 11:30:06 +01:00
locks.c
locks: print unsigned ino in /proc/locks
2020-01-09 10:19:00 +01:00
Makefile
…
mbcache.c
mbcache: Avoid nesting of cache->c_list_lock under bit locks
2023-01-18 11:30:51 +01:00
mount.h
…
mpage.c
…
namei.c
fs: Fix error checking for d_hash_and_lookup()
2023-09-23 10:47:59 +02:00
namespace.c
VFS: Fix memory leak caused by concurrently mounting fs with subtype
2022-05-15 19:41:59 +02:00
no-block.c
…
nsfs.c
dcache: sort the freeing-without-RCU-delay mess for good.
2019-05-25 18:23:26 +02:00
open.c
cifs_atomic_open(): fix double-put on late allocation failure
2020-03-18 07:14:21 +01:00
pipe.c
pipe: increase minimum default pipe size to 2 pages
2021-08-12 13:19:43 +02:00
pnode.c
pnode: terminate at peers of source
2023-01-18 11:30:40 +01:00
pnode.h
…
posix_acl.c
…
proc_namespace.c
…
read_write.c
vfs: avoid problematic remapping requests into partial EOF block
2019-12-01 09:17:04 +01:00
readdir.c
readdir: make sure to verify directory entry for legacy interfaces too
2021-04-28 13:16:50 +02:00
select.c
select: Fix indefinitely sleeping task in poll_schedule_timeout()
2022-01-29 10:19:18 +01:00
seq_file.c
seq_file: disallow extremely large seq buffer allocations
2021-07-20 16:16:16 +02:00
signalfd.c
signalfd: use wake_up_pollfree()
2021-12-14 10:18:07 +01:00
splice.c
Revert "fs: check FMODE_LSEEK to control internal pipe splicing"
2022-10-26 13:19:21 +02:00
stack.c
…
stat.c
stat: fix inconsistency between struct stat and struct compat_stat
2022-04-27 13:39:44 +02:00
statfs.c
statfs: enforce statfs[64] structure initialization
2023-05-30 12:42:11 +01:00
super.c
vfs: make freeze_super abort when sync_filesystem returns error
2022-02-23 11:58:38 +01:00
sync.c
…
timerfd.c
…
userfaultfd.c
userfaultfd: prevent concurrent API initialization
2021-09-22 11:48:02 +02:00
utimes.c
…
xattr.c
fs: don't audit the capability check in simple_xattr_list()
2023-01-18 11:30:04 +01:00