linux/drivers/staging/media
Dan Carpenter 115b7ac211 media: atomisp2: array underflow in ap1302_enum_frame_size()
The problem is this code from ap1302_enum_frame_size():

   738          int index = fse->index;
   739
   740          mutex_lock(&dev->input_lock);
   741          context = ap1302_get_context(sd);
   742          if (index >= dev->cntx_res[context].res_num) {
   743                  mutex_unlock(&dev->input_lock);
   744                  return -EINVAL;
   745          }
   746
   747          res_table = dev->cntx_res[context].res_table;
   748          fse->min_width = res_table[index].width;

"fse->index" is a u32 that come from the user.  We want negative values
of "index" to be treated as -EINVAL but they're not so we can read from
before the start of the res_table[] array.

I've fixed this by making "res_num" a u32.  I made "cur_res" a u32 as
well, just for consistency.

Fixes: a49d25364d ("staging/atomisp: Add support for the Intel IPU v2")

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2017-07-26 08:25:25 -04:00
..
atomisp media: atomisp2: array underflow in ap1302_enum_frame_size() 2017-07-26 08:25:25 -04:00
bcm2048 [media] media: bcm2048: fix several macros 2017-04-10 14:44:08 -03:00
cxd2099 media: staging: cxd2099: Activate cxd2099 buffer mode 2017-06-26 08:19:13 -03:00
davinci_vpfe Staging: media: Unmap and release region obtained by ioremap_nocache 2017-03-21 08:52:29 +01:00
imx [media] media: imx: Drop warning upon multiple S_STREAM disable calls 2017-06-20 08:12:20 -03:00
lirc [media] staging: remove todo and replace with lirc_zilog todo 2017-06-06 09:18:08 -03:00
omap4iss [media] staging: media: omap4iss: Replace a bit shift by a use of BIT 2017-04-18 12:13:11 -03:00
Kconfig [media] media: Add i.MX media core driver 2017-06-20 07:30:38 -03:00
Makefile [media] media: Add i.MX media core driver 2017-06-20 07:30:38 -03:00