Rafael Aquini 117aad1e9e mm: avoid reinserting isolated balloon pages into LRU lists ...

Isolated balloon pages can wrongly end up in LRU lists when
migrate_pages() finishes its round without draining all the isolated
page list.

The same issue can happen when reclaim_clean_pages_from_list() tries to
reclaim pages from an isolated page list, before migration, in the CMA
path.  Such balloon page leak opens a race window against LRU lists
shrinkers that leads us to the following kernel panic:

  BUG: unable to handle kernel NULL pointer dereference at 0000000000000028
  IP: [<ffffffff810c2625>] shrink_page_list+0x24e/0x897
  PGD 3cda2067 PUD 3d713067 PMD 0
  Oops: 0000 [#1] SMP
  CPU: 0 PID: 340 Comm: kswapd0 Not tainted 3.12.0-rc1-22626-g4367597 #87
  Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
  RIP: shrink_page_list+0x24e/0x897
  RSP: 0000:ffff88003da499b8  EFLAGS: 00010286
  RAX: 0000000000000000 RBX: ffff88003e82bd60 RCX: 00000000000657d5
  RDX: 0000000000000000 RSI: 000000000000031f RDI: ffff88003e82bd40
  RBP: ffff88003da49ab0 R08: 0000000000000001 R09: 0000000081121a45
  R10: ffffffff81121a45 R11: ffff88003c4a9a28 R12: ffff88003e82bd40
  R13: ffff88003da0e800 R14: 0000000000000001 R15: ffff88003da49d58
  FS:  0000000000000000(0000) GS:ffff88003fc00000(0000) knlGS:0000000000000000
  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  CR2: 00000000067d9000 CR3: 000000003ace5000 CR4: 00000000000407b0
  Call Trace:
    shrink_inactive_list+0x240/0x3de
    shrink_lruvec+0x3e0/0x566
    __shrink_zone+0x94/0x178
    shrink_zone+0x3a/0x82
    balance_pgdat+0x32a/0x4c2
    kswapd+0x2f0/0x372
    kthread+0xa2/0xaa
    ret_from_fork+0x7c/0xb0
  Code: 80 7d 8f 01 48 83 95 68 ff ff ff 00 4c 89 e7 e8 5a 7b 00 00 48 85 c0 49 89 c5 75 08 80 7d 8f 00 74 3e eb 31 48 8b 80 18 01 00 00 <48> 8b 74 0d 48 8b 78 30 be 02 00 00 00 ff d2 eb
  RIP  [<ffffffff810c2625>] shrink_page_list+0x24e/0x897
   RSP <ffff88003da499b8>
  CR2: 0000000000000028
  ---[ end trace 703d2451af6ffbfd ]---
  Kernel panic - not syncing: Fatal exception

This patch fixes the issue, by assuring the proper tests are made at
putback_movable_pages() & reclaim_clean_pages_from_list() to avoid
isolated balloon pages being wrongly reinserted in LRU lists.

[akpm@linux-foundation.org: clarify awkward comment text]
Signed-off-by: Rafael Aquini <aquini@redhat.com>
Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
Tested-by: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Rik van Riel <riel@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

2013-09-30 14:31:02 -07:00

..

backing-dev.c

mm/backing-dev.c: check user buffer length before copying data to the related user buffer

2013-09-11 15:58:03 -07:00

balloon_compaction.c

mm: introduce a common interface for balloon pages mobility

2012-12-11 17:22:26 -08:00

bootmem.c

mm: kill free_all_bootmem_node()

2013-07-03 16:07:39 -07:00

bounce.c

mm/bounce.c: fix a regression where MS_SNAP_STABLE (stable pages snapshotting) was ignored

2013-09-30 14:31:02 -07:00

cleancache.c

mm: cleancache: clean up cleancache_enabled

2013-04-30 17:04:01 -07:00

compaction.c

mm/compaction.c: periodically schedule when freeing pages

2013-09-30 14:31:01 -07:00

debug-pagealloc.c

mm, x86: Remove debug_pagealloc_enabled

2011-12-06 09:24:07 +01:00

dmapool.c

dmapool: make DMAPOOL_DEBUG detect corruption of free marker

2012-12-11 17:22:24 -08:00

fadvise.c

teach SYSCALL_DEFINE<n> how to deal with long long/unsigned long long

2013-03-03 22:46:22 -05:00

failslab.c

switch debugfs to umode_t

2012-01-03 22:54:56 -05:00

filemap_xip.c

lift sb_start_write() out of ->write()

2013-04-09 14:12:56 -04:00

filemap.c

mm: cleanup add_to_page_cache_locked()

2013-09-12 15:38:03 -07:00

fremap.c

mm: save soft-dirty bits on file pages

2013-08-13 17:57:48 -07:00

frontswap.c

frontswap: fix incorrect zeroing and allocation size for frontswap_map

2013-06-12 16:29:46 -07:00

highmem.c

Some nice cleanups, and even a patch my wife did as a "live" demo for

2012-12-20 08:37:05 -08:00

huge_memory.c

Merge branch 'akpm' (patches from Andrew Morton)

2013-09-12 15:44:27 -07:00

hugetlb_cgroup.c

cgroup: pass around cgroup_subsys_state instead of cgroup in file methods

2013-08-08 20:11:24 -04:00

hugetlb.c

mm: prepare to remove /proc/sys/vm/hugepages_treat_as_movable

2013-09-11 15:57:49 -07:00

hwpoison-inject.c

mm/hwpoison-inject.c: change permission of corrupt-pfn/unpoison-pfn to 0200

2013-09-11 15:58:11 -07:00

init-mm.c

atomic: use <linux/atomic.h>

2011-07-26 16:49:47 -07:00

internal.h

mm: vmscan: fix do_try_to_free_pages() livelock

2013-09-11 15:58:01 -07:00

interval_tree.c

mm: add CONFIG_DEBUG_VM_RB build option

2012-10-09 16:22:42 +09:00

Kconfig

mm/Kconfig: add MMU dependency for MIGRATION.

2013-09-12 15:38:03 -07:00

Kconfig.debug

mm: more intensive memory corruption debugging

2012-01-10 16:30:42 -08:00

kmemcheck.c

…

kmemleak-test.c

kmemleak: remove memset by using kzalloc

2011-01-27 18:31:51 +00:00

kmemleak.c

mm: replace strict_strtoul() with kstrtoul()

2013-09-11 15:57:11 -07:00

ksm.c

mm: replace strict_strtoul() with kstrtoul()

2013-09-11 15:57:11 -07:00

list_lru.c

list_lru: dynamically adjust node arrays

2013-09-10 18:56:32 -04:00

maccess.c

mm: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

madvise.c

mm/madvise.c:madvise_hwpoison(): remove local `ret'

2013-09-11 15:58:13 -07:00

Makefile

list: add a new LRU list type

2013-09-10 18:56:30 -04:00

memblock.c

memblock, numa: binary search node id

2013-09-11 15:57:51 -07:00

memcontrol.c

revert "memcg, vmscan: integrate soft reclaim tighter with zone shrinking code"

2013-09-24 17:00:26 -07:00

memory_hotplug.c

ACPI and power management fixes for 3.12-rc1

2013-09-12 11:22:45 -07:00

memory-failure.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2013-09-12 15:01:38 -07:00

memory.c

thp: consolidate code between handle_mm_fault() and do_huge_pmd_anonymous_page()

2013-09-12 15:38:03 -07:00

mempolicy.c

mbind: add BUG_ON(!vma) in new_vma_page()

2013-09-11 15:57:50 -07:00

mempool.c

mm/mempool.c: convert kmalloc_node(...GFP_ZERO...) to kzalloc_node(...)

2013-09-11 15:58:14 -07:00

migrate.c

mm: avoid reinserting isolated balloon pages into LRU lists

2013-09-30 14:31:02 -07:00

mincore.c

swap: make each swap partition have one address_space

2013-02-23 17:50:17 -08:00

mlock.c

mm: Place preemption point in do_mlockall() loop

2013-09-24 19:44:40 -07:00

mm_init.c

mm: tune vm_committed_as percpu_counter batching size

2013-07-03 16:07:32 -07:00

mmap.c

mm/mmap: remove unnecessary assignment

2013-09-11 15:58:13 -07:00

mmu_context.c

mm: remove old aio use_mm() comment

2013-05-07 18:38:27 -07:00

mmu_notifier.c

treewide: relase -> release

2013-06-28 14:34:33 +02:00

mmzone.c

mm: rename page struct field helpers

2013-02-23 17:50:18 -08:00

mprotect.c

mm/mprotect.c: coding-style cleanups

2012-12-18 15:02:15 -08:00

mremap.c

mm/mremap.c: call pud_free() after fail calling pmd_alloc()

2013-09-11 15:58:03 -07:00

msync.c

…

nobootmem.c

mm: concentrate modification of totalram_pages into the mm core

2013-07-03 16:07:33 -07:00

nommu.c

mm: remove free_area_cache

2013-07-10 18:11:34 -07:00

oom_kill.c

mm: memcg: do not trap chargers with full callstack on OOM

2013-09-12 15:38:02 -07:00

page_alloc.c

revert "mm/memory-hotplug: fix lowmem count overflow when offline pages"

2013-09-30 14:31:01 -07:00

page_cgroup.c

memcontrol: use N_MEMORY instead N_HIGH_MEMORY

2012-12-12 17:38:32 -08:00

page_io.c

aio: Kill aio_rw_vect_retry()

2013-07-30 11:53:12 -04:00

page_isolation.c

mm: memory-hotplug: enable memory hotplug to handle hugepage

2013-09-11 15:57:48 -07:00

page-writeback.c

memcg: add per cgroup writeback pages accounting

2013-09-12 15:38:02 -07:00

pagewalk.c

mm/pagewalk.c: walk_page_range should avoid VM_PFNMAP areas

2013-05-24 16:22:53 -07:00

percpu-km.c

…

percpu-vm.c

mm: fix kernel-doc warnings

2012-06-20 14:39:36 -07:00

percpu.c

mm, percpu: Make sure percpu_alloc early parameter has an argument

2012-12-02 06:23:04 -08:00

pgtable-generic.c

mm: move pgtable related functions to right place

2013-09-11 15:57:30 -07:00

process_vm_access.c

Fix: compat_rw_copy_check_uvector() misuse in aio, readv, writev, and security keys

2013-03-12 11:05:45 -07:00

quicklist.c

mm: delete various needless include <linux/module.h>

2011-10-31 09:20:11 -04:00

readahead.c

readahead: make context readahead more conservative

2013-09-11 15:57:39 -07:00

rmap.c

thp: account anon transparent huge pages into NR_ANON_PAGES

2013-09-12 15:38:03 -07:00

shmem.c

initmpfs: make rootfs use tmpfs when CONFIG_TMPFS enabled

2013-09-11 15:59:37 -07:00

slab_common.c

mm/sl[aou]b: Move kmallocXXX functions to common code

2013-09-04 20:51:33 +03:00

slab.c

kernel: delete __cpuinit usage from all core kernel files

2013-07-14 19:36:59 -04:00

slab.h

memcg: check that kmem_cache has memcg_params before accessing it

2013-08-28 19:26:38 -07:00

slob.c

mm/sl[aou]b: Move kmallocXXX functions to common code

2013-09-04 20:51:33 +03:00

slub.c

Merge branch 'slab/next' of git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux

2013-09-15 07:15:06 -04:00

sparse-vmemmap.c

sparse-vmemmap: specify vmemmap population range in bytes

2013-04-29 15:54:35 -07:00

sparse.c

mm/sparse: introduce alloc_usemap_and_memmap

2013-09-11 15:58:01 -07:00

swap_state.c

lib/radix-tree.c: make radix_tree_node_alloc() work correctly within interrupt

2013-09-11 15:59:36 -07:00

swap.c

mm: make lru_add_drain_all() selective

2013-09-12 15:38:02 -07:00

swapfile.c

swap: make cluster allocation per-cpu

2013-09-11 15:57:17 -07:00

truncate.c

truncate: drop 'oldsize' truncate_pagecache() parameter

2013-09-12 15:38:02 -07:00

util.c

swap: clean-up #ifdef in page_mapping()

2013-09-11 15:57:31 -07:00

vmalloc.c

mm/vmalloc: use wrapper function get_vm_area_size to caculate size of vm area

2013-09-11 15:58:02 -07:00

vmpressure.c

Merge branch 'for-3.12' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup

2013-09-03 18:25:03 -07:00

vmscan.c

mm: avoid reinserting isolated balloon pages into LRU lists

2013-09-30 14:31:02 -07:00

vmstat.c

mm: vmscan: fix do_try_to_free_pages() livelock

2013-09-11 15:58:01 -07:00

zbud.c

mm/zbud: fix some trivial typos in comments

2013-09-11 15:57:35 -07:00

zswap.c

mm/zswap: use postorder iteration when destroying rbtree

2013-09-11 15:59:21 -07:00