iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Shiyang Ruan f76b3a3287 fsdax: force clear dirty mark if CoW 
XFS allows CoW on non-shared extents to combat fragmentation[1].  The old
non-shared extent could be mwrited before, its dax entry is marked dirty. 

This results in a WARNing:

[   28.512349] ------------[ cut here ]------------
[   28.512622] WARNING: CPU: 2 PID: 5255 at fs/dax.c:390 dax_insert_entry+0x342/0x390
[   28.513050] Modules linked in: rpcsec_gss_krb5 auth_rpcgss nfsv4 nfs lockd grace fscache netfs nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set nf_tables
[   28.515462] CPU: 2 PID: 5255 Comm: fsstress Kdump: loaded Not tainted 6.3.0-rc1-00001-g85e1481e19c1-dirty #117
[   28.515902] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS Arch Linux 1.16.1-1-1 04/01/2014
[   28.516307] RIP: 0010:dax_insert_entry+0x342/0x390
[   28.516536] Code: 30 5b 5d 41 5c 41 5d 41 5e 41 5f c3 cc cc cc cc 48 8b 45 20 48 83 c0 01 e9 e2 fe ff ff 48 8b 45 20 48 83 c0 01 e9 cd fe ff ff <0f> 0b e9 53 ff ff ff 48 8b 7c 24 08 31 f6 e8 1b 61 a1 00 eb 8c 48
[   28.517417] RSP: 0000:ffffc9000845fb18 EFLAGS: 00010086
[   28.517721] RAX: 0000000000000053 RBX: 0000000000000155 RCX: 000000000018824b
[   28.518113] RDX: 0000000000000000 RSI: ffffffff827525a6 RDI: 00000000ffffffff
[   28.518515] RBP: ffffea00062092c0 R08: 0000000000000000 R09: ffffc9000845f9c8
[   28.518905] R10: 0000000000000003 R11: ffffffff82ddb7e8 R12: 0000000000000155
[   28.519301] R13: 0000000000000000 R14: 000000000018824b R15: ffff88810cfa76b8
[   28.519703] FS:  00007f14a0c94740(0000) GS:ffff88817bd00000(0000) knlGS:0000000000000000
[   28.520148] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   28.520472] CR2: 00007f14a0c8d000 CR3: 000000010321c004 CR4: 0000000000770ee0
[   28.520863] PKRU: 55555554
[   28.521043] Call Trace:
[   28.521219]  <TASK>
[   28.521368]  dax_fault_iter+0x196/0x390
[   28.521595]  dax_iomap_pte_fault+0x19b/0x3d0
[   28.521852]  __xfs_filemap_fault+0x234/0x2b0
[   28.522116]  __do_fault+0x30/0x130
[   28.522334]  do_fault+0x193/0x340
[   28.522586]  __handle_mm_fault+0x2d3/0x690
[   28.522975]  handle_mm_fault+0xe6/0x2c0
[   28.523259]  do_user_addr_fault+0x1bc/0x6f0
[   28.523521]  exc_page_fault+0x60/0x140
[   28.523763]  asm_exc_page_fault+0x22/0x30
[   28.524001] RIP: 0033:0x7f14a0b589ca
[   28.524225] Code: c5 fe 7f 07 c5 fe 7f 47 20 c5 fe 7f 47 40 c5 fe 7f 47 60 c5 f8 77 c3 66 0f 1f 84 00 00 00 00 00 40 0f b6 c6 48 89 d1 48 89 fa <f3> aa 48 89 d0 c5 f8 77 c3 66 66 2e 0f 1f 84 00 00 00 00 00 66 90
[   28.525198] RSP: 002b:00007fff1dea1c98 EFLAGS: 00010202
[   28.525505] RAX: 000000000000001e RBX: 000000000014a000 RCX: 0000000000006046
[   28.525895] RDX: 00007f14a0c82000 RSI: 000000000000001e RDI: 00007f14a0c8d000
[   28.526290] RBP: 000000000000006f R08: 0000000000000004 R09: 000000000014a000
[   28.526681] R10: 0000000000000008 R11: 0000000000000246 R12: 028f5c28f5c28f5c
[   28.527067] R13: 8f5c28f5c28f5c29 R14: 0000000000011046 R15: 00007f14a0c946c0
[   28.527449]  </TASK>
[   28.527600] ---[ end trace 0000000000000000 ]---


To be able to delete this entry, clear its dirty mark before
invalidate_inode_pages2_range().

[1] https://lore.kernel.org/linux-xfs/20230321151339.GA11376@frogsfrogsfrogs/

Link: https://lkml.kernel.org/r/1679653680-2-1-git-send-email-ruansy.fnst@fujitsu.com
Fixes: f80e1668888f3 ("fsdax: invalidate pages when CoW")
Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Darrick J. Wong <djwong@kernel.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2023-04-05 18:06:23 -07:00
..
9p
9p patches for 6.3 merge window (part 1)
2023-03-01 08:52:49 -08:00
adfs
fs: port ->setattr() to pass mnt_idmap
2023-01-19 09:24:02 +01:00
affs
for-6.3/dio-2023-02-16
2023-02-20 14:10:36 -08:00
afs
- Daniel Verkamp has contributed a memfd series ("mm/memfd: add
2023-02-23 17:09:35 -08:00
autofs
fs: port ->permission() to pass mnt_idmap
2023-01-19 09:24:28 +01:00
befs
befs: Convert befs_symlink_read_folio() to use a folio
2022-08-02 12:34:03 -04:00
bfs
fs: port inode_init_owner() to mnt_idmap
2023-01-19 09:24:28 +01:00
btrfs
for-6.3-rc3-tag
2023-03-24 08:32:10 -07:00
cachefiles
fs: port ->permission() to pass mnt_idmap
2023-01-19 09:24:28 +01:00
ceph
Two small fixes from Xiubo and myself, marked for stable.
2023-03-02 10:48:30 -08:00
cifs
smb3: fix unusable share after force unmount failure
2023-03-24 14:37:12 -05:00
coda
hardening updates for v6.3-rc1
2023-02-21 11:07:23 -08:00
configfs
fs: port ->permission() to pass mnt_idmap
2023-01-19 09:24:28 +01:00
cramfs
fs/cramfs/inode.c: initialize file_ra_state
2023-03-02 21:54:23 -08:00
crypto
fscrypt: check for NULL keyring in fscrypt_put_master_key_activeref()
2023-03-18 21:08:03 -07:00
debugfs
ARM: SoC drivers for 6.3
2023-02-27 10:04:49 -08:00
devpts
…
dlm
Driver core changes for 6.3-rc1
2023-02-24 12:58:55 -08:00
ecryptfs
This update includes the following changes:
2023-02-21 18:10:50 -08:00
efivarfs
A healthy mix of EFI contributions this time:
2023-02-23 14:41:48 -08:00
efs
…
erofs
erofs: use wrapper i_blocksize() in erofs_file_read_iter()
2023-03-09 23:36:04 +08:00
exfat
Description for this pull request:
2023-03-01 08:42:27 -08:00
exportfs
fs: port ->permission() to pass mnt_idmap
2023-01-19 09:24:28 +01:00
ext2
for-6.3/dio-2023-02-16
2023-02-20 14:10:36 -08:00
ext4
ext4: fix possible double unlock when moving a directory
2023-03-17 21:53:52 -04:00
f2fs
f2fs-for-6.3-rc1
2023-02-27 16:18:51 -08:00
fat
There is no particular theme here - mainly quick hits all over the tree.
2023-02-23 17:55:40 -08:00
freevxfs
There is no particular theme here - mainly quick hits all over the tree.
2023-02-23 17:55:40 -08:00
fscache
fscache: Use clear_and_wake_up_bit() in fscache_create_volume_work()
2023-01-30 12:51:54 +00:00
fuse
fuse update for 6.3
2023-02-27 09:53:58 -08:00
gfs2
Reinstate "GFS2: free disk inode which is deleted by remote node -V2"
2023-03-23 19:37:56 +01:00
hfs
There is no particular theme here - mainly quick hits all over the tree.
2023-02-23 17:55:40 -08:00
hfsplus
fs: hfsplus: fix UAF issue in hfsplus_put_super
2023-03-02 21:54:23 -08:00
hostfs
This pull request contains the following changes for UML:
2023-03-01 09:13:00 -08:00
hpfs
fs: port ->rename() to pass mnt_idmap
2023-01-19 09:24:26 +01:00
hugetlbfs
- Daniel Verkamp has contributed a memfd series ("mm/memfd: add
2023-02-23 17:09:35 -08:00
iomap
- Daniel Verkamp has contributed a memfd series ("mm/memfd: add
2023-02-23 17:09:35 -08:00
isofs
- hfs and hfsplus kmap API modernization from Fabio Francesco
2022-10-12 11:00:22 -07:00
jbd2
Bug fixes and regressions for ext4, the most serious of which is a
2023-03-12 08:55:55 -07:00
jffs2
This pull request contains updates for JFFS2, UBI and UBIFS
2023-03-01 09:06:51 -08:00
jfs
Just one simple sanity check
2023-03-01 08:47:19 -08:00
kernfs
Driver core changes for 6.3-rc1
2023-02-24 12:58:55 -08:00
ksmbd
ksmbd: return unsupported error on smb1 mount
2023-03-24 00:23:13 -05:00
lockd
lockd: set file_lock start and end when decoding nlm4 testargs
2023-03-14 14:00:55 -04:00
minix
Merge branch 'work.minix' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2023-02-24 19:01:15 -08:00
netfs
iov: Fix netfs_extract_user_to_sg()
2023-03-01 18:18:25 -06:00
nfs
nfsd-6.3 fixes:
2023-03-21 14:48:38 -07:00
nfs_common
filelock: move file locking definitions to separate header file
2023-01-11 06:52:32 -05:00
nfsd
nfsd-6.3 fixes:
2023-03-21 14:48:38 -07:00
nilfs2
nilfs2: fix kernel-infoleak in nilfs_ioctl_wrap_copy()
2023-03-23 17:18:32 -07:00
nls
…
notify
RCU pull request for v6.3
2023-02-21 10:45:51 -08:00
ntfs
There is no particular theme here - mainly quick hits all over the tree.
2023-02-23 17:55:40 -08:00
ntfs3
- Daniel Verkamp has contributed a memfd series ("mm/memfd: add
2023-02-23 17:09:35 -08:00
ocfs2
ocfs2: fix data corruption after failed write
2023-03-07 17:04:55 -08:00
omfs
fs: port inode_init_owner() to mnt_idmap
2023-01-19 09:24:28 +01:00
openpromfs
…
orangefs
- Daniel Verkamp has contributed a memfd series ("mm/memfd: add
2023-02-23 17:09:35 -08:00
overlayfs
fs.idmapped.v6.3
2023-02-20 11:53:11 -08:00
proc
capability: just use a 'u64' instead of a 'u32[2]' array
2023-03-01 10:01:22 -08:00
pstore
pstore updates for v6.2-rc1-fixes
2022-12-23 11:55:54 -08:00
qnx4
…
qnx6
fs/qnx6: delete unnecessary checks before brelse()
2022-09-11 21:55:07 -07:00
quota
RCU pull request for v6.3
2023-02-21 10:45:51 -08:00
ramfs
- Daniel Verkamp has contributed a memfd series ("mm/memfd: add
2023-02-23 17:09:35 -08:00
reiserfs
- Daniel Verkamp has contributed a memfd series ("mm/memfd: add
2023-02-23 17:09:35 -08:00
romfs
mm/nommu: factor out check for NOMMU shared mappings into is_nommu_shared_mapping()
2023-01-18 17:12:56 -08:00
smbfs_common
smb3: Replace smb2pdu 1-element arrays with flex-arrays
2023-02-20 17:25:43 -06:00
squashfs
revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"
2023-02-03 17:52:25 -08:00
sysfs
…
sysv
Merge branch 'work.sysv' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2023-02-24 19:03:26 -08:00
tracefs
fs: port ->mkdir() to pass mnt_idmap
2023-01-19 09:24:26 +01:00
ubifs
This pull request contains updates for JFFS2, UBI and UBIFS
2023-03-01 09:06:51 -08:00
udf
udf: Warn if block mapping is done for in-ICB files
2023-03-06 16:38:25 +01:00
ufs
fs: port inode_init_owner() to mnt_idmap
2023-01-19 09:24:28 +01:00
unicode
…
vboxsf
fs: port ->rename() to pass mnt_idmap
2023-01-19 09:24:26 +01:00
verity
fsverity: don't drop pagecache at end of FS_IOC_ENABLE_VERITY
2023-03-15 22:50:41 -07:00
xfs
xfs: fix mismerged tracepoints
2023-03-24 13:16:01 -07:00
zonefs
zonefs: Fix error message in zonefs_file_dio_append()
2023-03-21 06:36:43 +09:00
aio.c
Merge branch 'mm-hotfixes-stable' into mm-stable
2023-02-10 15:34:48 -08:00
anon_inodes.c
dynamic_dname(): drop unused dentry argument
2022-08-20 11:34:04 -04:00
attr.c
fs.idmapped.v6.3
2023-02-20 11:53:11 -08:00
bad_inode.c
fs: port ->permission() to pass mnt_idmap
2023-01-19 09:24:28 +01:00
binfmt_elf_fdpic.c
elfcore: Add a cprm parameter to elf_core_extra_{phdrs,data_size}
2023-01-05 15:12:12 +00:00
binfmt_elf_test.c
…
binfmt_elf.c
Linux 6.2-rc6
2023-01-31 15:01:20 +01:00
binfmt_flat.c
…
binfmt_misc.c
binfmt_misc: fix shift-out-of-bounds in check_special_flags
2022-12-02 13:57:04 -08:00
binfmt_script.c
…
buffer.c
- Daniel Verkamp has contributed a memfd series ("mm/memfd: add
2023-02-23 17:09:35 -08:00
char_dev.c
chardev: fix error handling in cdev_device_add()
2022-12-02 17:48:59 +01:00
compat_binfmt_elf.c
…
coredump.c
- Daniel Verkamp has contributed a memfd series ("mm/memfd: add
2023-02-23 17:09:35 -08:00
d_path.c
d_path.c: typo fix...
2022-08-20 11:34:33 -04:00
dax.c
fsdax: force clear dirty mark if CoW
2023-04-05 18:06:23 -07:00
dcache.c
tmpfile API change
2022-10-10 19:45:17 -07:00
direct-io.c
fs: move sb_init_dio_done_wq out of direct-io.c
2023-01-26 10:30:56 -07:00
drop_caches.c
…
eventfd.c
eventfd: provide a eventfd_signal_mask() helper
2022-11-22 06:07:55 -07:00
eventpoll.c
eventpoll: add EPOLL_URING_WAKE poll wakeup flag
2022-11-21 07:45:29 -07:00
exec.c
- Daniel Verkamp has contributed a memfd series ("mm/memfd: add
2023-02-23 17:09:35 -08:00
fcntl.c
fs.idmapped.v6.3
2023-02-20 11:53:11 -08:00
fhandle.c
do_sys_name_to_handle(): constify path
2022-09-01 17:36:39 -04:00
file_table.c
filelock: move file locking definitions to separate header file
2023-01-11 06:52:32 -05:00
file.c
fs: prevent out-of-bounds array speculation when closing a file descriptor
2023-03-09 22:46:21 -05:00
filesystems.c
…
fs_context.c
…
fs_parser.c
ext4: journal_path mount options should follow links
2022-12-01 10:46:54 -05:00
fs_pin.c
…
fs_struct.c
…
fs_types.c
…
fs-writeback.c
mm: convert mem_cgroup_css_from_page() to mem_cgroup_css_from_folio()
2023-02-02 22:33:19 -08:00
fsopen.c
…
init.c
fs: port ->permission() to pass mnt_idmap
2023-01-19 09:24:28 +01:00
inode.c
fs.idmapped.v6.3
2023-02-20 11:53:11 -08:00
internal.h
for-6.3/dio-2023-02-16
2023-02-20 14:10:36 -08:00
ioctl.c
fs: port inode_owner_or_capable() to mnt_idmap
2023-01-19 09:24:29 +01:00
Kconfig
fs: build the legacy direct I/O code conditionally
2023-01-26 10:30:56 -07:00
Kconfig.binfmt
Xtensa updates for v6.1
2022-10-10 14:21:11 -07:00
kernel_read_file.c
…
libfs.c
fs.idmapped.v6.3
2023-02-20 11:53:11 -08:00
locks.c
filelocks: use mount idmapping for setlease permission check
2023-03-09 22:36:12 +01:00
Makefile
for-6.3/dio-2023-02-16
2023-02-20 14:10:36 -08:00
mbcache.c
ext4: fix deadlock due to mbcache entry corruption
2022-12-08 21:49:25 -05:00
mnt_idmapping.c
fs: move mnt_idmap
2023-01-19 09:24:30 +01:00
mount.h
…
mpage.c
- Daniel Verkamp has contributed a memfd series ("mm/memfd: add
2023-02-23 17:09:35 -08:00
namei.c
NFSD 6.3 Release Notes
2023-02-22 14:21:40 -08:00
namespace.c
Merge branch 'work.namespace' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2023-02-24 19:20:07 -08:00
no-block.c
…
nsfs.c
nsfs: repair kernel-doc for ns_match()
2023-01-11 15:47:40 -05:00
open.c
vfs: avoid duplicating creds in faccessat if possible
2023-02-27 16:39:19 -08:00
pipe.c
dynamic_dname(): drop unused dentry argument
2022-08-20 11:34:04 -04:00
pnode.c
pnode: terminate at peers of source
2022-12-21 14:45:25 +01:00
pnode.h
…
posix_acl.c
fs.acl.v6.3
2023-02-20 12:14:33 -08:00
proc_namespace.c
…
read_write.c
iov_iter work; most of that is about getting rid of
2022-12-12 18:29:54 -08:00
readdir.c
Change calling conventions for filldir_t
2022-08-17 17:25:04 -04:00
remap_range.c
fs: port i_{g,u}id_into_vfs{g,u}id() to mnt_idmap
2023-01-19 09:24:29 +01:00
select.c
…
seq_file.c
use less confusing names for iov_iter direction initializers
2022-11-25 13:01:55 -05:00
signalfd.c
…
splice.c
splice: Remove redundant assignment to ret
2023-03-09 10:10:31 +01:00
stack.c
…
stat.c
fs.idmapped.v6.3
2023-02-20 11:53:11 -08:00
statfs.c
…
super.c
fscrypt: destroy keyring after security_sb_delete()
2023-03-14 10:30:30 -07:00
sync.c
…
sysctls.c
…
timerfd.c
…
userfaultfd.c
mm: replace vma->vm_flags direct modifications with modifier calls
2023-02-09 16:51:39 -08:00
utimes.c
fs.idmapped.v6.3
2023-02-20 11:53:11 -08:00
xattr.c
fs.idmapped.v6.3
2023-02-20 11:53:11 -08:00