iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
11dd266637
linux/drivers/bcma
History
Guenter Roeck 664eadd6f4 bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets 
Mips builds with BCMA host mode enabled fail in mainline and -next
with:

In file included from include/linux/bcma/bcma.h:10:0,
                 from drivers/bcma/bcma_private.h:9,
		 from drivers/bcma/main.c:8:
include/linux/bcma/bcma_driver_pci.h:218:24: error:
	field 'pci_controller' has incomplete type

Bisect points to commit d41e6858ba ("MIPS: Kconfig: Set default MIPS
system type as generic") as the culprit. Analysis shows that the commmit
changes PCI configuration and enables PCI_DRIVERS_GENERIC. This in turn
disables PCI_DRIVERS_LEGACY. 'struct pci_controller' is, however, only
defined if PCI_DRIVERS_LEGACY is enabled.

Ultimately that means that BCMA_DRIVER_PCI_HOSTMODE depends on
PCI_DRIVERS_LEGACY. Add the missing dependency.

Fixes: d41e6858ba ("MIPS: Kconfig: Set default MIPS system type as ...")
Cc: Matt Redfearn <matt.redfearn@imgtec.com>
Cc: James Hogan <jhogan@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: James Hogan <jhogan@kernel.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
2018-01-16 21:13:55 +02:00
..
bcma_private.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
core.c
driver_chipcommon_b.c bcma: define ChipCommon B MII registers 2016-07-19 21:13:10 +03:00
driver_chipcommon_nflash.c
driver_chipcommon_pflash.c bcma: move parallel flash support to separated file 2016-03-07 14:41:08 +02:00
driver_chipcommon_pmu.c bcma: support PMU present as separated bus core 2016-02-06 13:36:11 +02:00
driver_chipcommon_sflash.c mtd: bcm47xxsflash: use ioremap_cache() instead of KSEG0ADDR() 2016-04-04 00:07:57 -07:00
driver_chipcommon.c Revert "bcma: init serial console directly from ChipCommon code" 2017-01-17 14:23:44 +02:00
driver_gmac_cmn.c
driver_gpio.c gpio: Move irqdomain into struct gpio_irq_chip 2017-11-08 14:06:21 +01:00
driver_mips.c bcma: Use bcma_debug and not pr_cont in MIPS driver 2017-10-27 11:01:37 +03:00
driver_pci_host.c bcma: add missing includes 2015-03-03 15:26:38 +02:00
driver_pci.c bcma: move PCI IRQ control function to host specific code 2015-03-13 16:25:50 +02:00
driver_pcie2.c bcma: add missing includes 2015-03-03 15:26:38 +02:00
host_pci.c bcma: add Dell Inspiron 3148 2016-11-29 17:35:14 +02:00
host_soc.c bcma: use standard bus scanning during early register 2015-01-23 21:47:55 +02:00
Kconfig bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets 2018-01-16 21:13:55 +02:00
main.c bcma: fill core OF info independently of bus type 2017-03-20 19:12:01 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
README
scan.c bcma: support chipsets with PMU and GCI cores (devices) 2016-02-06 13:34:51 +02:00
scan.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
sprom.c bcma: detect SPROM revision 11 2015-01-29 10:49:28 +02:00
TODO

README 

Broadcom introduced new bus as replacement for older SSB. It is based on AMBA,
however from programming point of view there is nothing AMBA specific we use.

Standard AMBA drivers are platform specific, have hardcoded addresses and use
AMBA standard fields like CID and PID.

In case of Broadcom's cards every device consists of:
1) Broadcom specific AMBA device. It is put on AMBA bus, but can not be treated
   as standard AMBA device. Reading it's CID or PID can cause machine lockup.
2) AMBA standard devices called ports or wrappers. They have CIDs (AMBA_CID)
   and PIDs (0x103BB369), but we do not use that info for anything. One of that
   devices is used for managing Broadcom specific core.

Addresses of AMBA devices are not hardcoded in driver and have to be read from
EPROM.

In this situation we decided to introduce separated bus. It can contain up to
16 devices identified by Broadcom specific fields: manufacturer, id, revision
and class.