Chao Yu
b8962cf985
f2fs: compress: don't allow unaligned truncation on released compress inode
...
[ Upstream commit 29ed2b5dd521ce7c5d8466cd70bf0cc9d07afeee ]
f2fs image may be corrupted after below testcase:
- mkfs.f2fs -O extra_attr,compression -f /dev/vdb
- mount /dev/vdb /mnt/f2fs
- touch /mnt/f2fs/file
- f2fs_io setflags compression /mnt/f2fs/file
- dd if=/dev/zero of=/mnt/f2fs/file bs=4k count=4
- f2fs_io release_cblocks /mnt/f2fs/file
- truncate -s 8192 /mnt/f2fs/file
- umount /mnt/f2fs
- fsck.f2fs /dev/vdb
[ASSERT] (fsck_chk_inode_blk:1256) --> ino: 0x5 has i_blocks: 0x00000002, but has 0x3 blocks
[FSCK] valid_block_count matching with CP [Fail] [0x4, 0x5]
[FSCK] other corrupted bugs [Fail]
The reason is: partial truncation assume compressed inode has reserved
blocks, after partial truncation, valid block count may change w/o
.i_blocks and .total_valid_block_count update, result in corruption.
This patch only allow cluster size aligned truncation on released
compress inode for fixing.
Fixes: c61404153eb6 ("f2fs: introduce FI_COMPRESS_RELEASED instead of using IMMUTABLE bit")
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-06-16 13:32:21 +02:00
..
2020-09-14 11:15:37 -07:00
2020-05-08 06:55:55 -07:00
2024-06-16 13:32:18 +02:00
2024-06-16 13:32:18 +02:00
2024-06-16 13:32:18 +02:00
2021-01-06 14:56:54 +01:00
2021-09-18 13:40:13 +02:00
2024-06-16 13:32:18 +02:00
2024-06-16 13:32:17 +02:00
2024-06-16 13:32:21 +02:00
2023-11-08 17:30:46 +01:00
2020-09-11 11:11:15 -07:00
2020-06-09 11:28:59 -07:00
2023-03-11 16:40:09 +01:00
2024-06-16 13:32:17 +02:00
2020-05-11 20:36:46 -07:00
2020-01-17 16:48:07 -08:00
2024-06-16 13:32:18 +02:00
2024-06-16 13:32:21 +02:00
2021-01-06 14:56:54 +01:00
2024-02-23 08:42:11 +01:00
2024-06-16 13:32:18 +02:00
2023-05-17 11:47:49 +02:00
2021-01-06 14:56:54 +01:00
2024-06-16 13:32:17 +02:00
2023-06-14 11:09:31 +02:00
2019-03-05 19:58:06 -08:00
2020-05-08 06:55:55 -07:00
2023-03-11 16:40:09 +01:00
2024-01-25 14:37:35 -08:00
2020-05-26 18:56:10 -07:00