iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1382999aa0
linux/drivers/net/wan
History
Li Zetao 2f623aaf9f net: farsync: Fix kmemleak when rmmods farsync 
There are two memory leaks reported by kmemleak:

  unreferenced object 0xffff888114b20200 (size 128):
    comm "modprobe", pid 4846, jiffies 4295146524 (age 401.345s)
    hex dump (first 32 bytes):
      e0 62 57 09 81 88 ff ff e0 62 57 09 81 88 ff ff  .bW......bW.....
      01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    backtrace:
      [<ffffffff815bcd82>] kmalloc_trace+0x22/0x60
      [<ffffffff83d35c78>] __hw_addr_add_ex+0x198/0x6c0
      [<ffffffff83d3989d>] dev_addr_init+0x13d/0x230
      [<ffffffff83d1063d>] alloc_netdev_mqs+0x10d/0xe50
      [<ffffffff82b4a06e>] alloc_hdlcdev+0x2e/0x80
      [<ffffffffa016a741>] fst_add_one+0x601/0x10e0 [farsync]
      ...

  unreferenced object 0xffff88810b85b000 (size 1024):
    comm "modprobe", pid 4846, jiffies 4295146523 (age 401.346s)
    hex dump (first 32 bytes):
      00 00 b0 02 00 c9 ff ff 00 70 0a 00 00 c9 ff ff  .........p......
      00 00 00 f2 00 00 00 f3 0a 00 00 00 02 00 00 00  ................
    backtrace:
      [<ffffffff815bcd82>] kmalloc_trace+0x22/0x60
      [<ffffffffa016a294>] fst_add_one+0x154/0x10e0 [farsync]
      [<ffffffff82060e83>] local_pci_probe+0xd3/0x170
      ...

The root cause is traced to the netdev and fst_card_info are not freed
when removes one fst in fst_remove_one(), which may trigger oom if
repeated insmod and rmmod module.

Fix it by adding free_netdev() and kfree() in fst_remove_one(), just as
the operations on the error handling path in fst_add_one().

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2022-12-12 09:42:45 +00:00
..
.gitignore
c101.c net: split out ndo_siowandev ioctl 2021-07-27 20:11:45 +01:00
farsync.c net: farsync: Fix kmemleak when rmmods farsync 2022-12-12 09:42:45 +00:00
farsync.h WAN: Fix syntax errors in comments 2022-06-07 10:45:25 +02:00
fsl_ucc_hdlc.c net: wan: switch to netif_napi_add_weight() 2022-05-08 11:33:57 +01:00
fsl_ucc_hdlc.h
hd64570.c
hd64570.h
hd64572.c net: wan: switch to netif_napi_add_weight() 2022-05-08 11:33:57 +01:00
hd64572.h
hdlc_cisco.c net: split out ndo_siowandev ioctl 2021-07-27 20:11:45 +01:00
hdlc_fr.c net: hldc_fr: use dev_addr_set() 2021-10-22 10:16:18 -07:00
hdlc_ppp.c net: split out ndo_siowandev ioctl 2021-07-27 20:11:45 +01:00
hdlc_raw_eth.c net: split out ndo_siowandev ioctl 2021-07-27 20:11:45 +01:00
hdlc_raw.c net: split out ndo_siowandev ioctl 2021-07-27 20:11:45 +01:00
hdlc_x25.c net: split out ndo_siowandev ioctl 2021-07-27 20:11:45 +01:00
hdlc.c net: split out ndo_siowandev ioctl 2021-07-27 20:11:45 +01:00
ixp4xx_hss.c net: wan: switch to netif_napi_add_weight() 2022-05-08 11:33:57 +01:00
Kconfig net: wan: remove support for Z85230-based devices 2022-04-27 12:22:56 +01:00
lapbether.c net: lapbether: fix issue of invalid opcode in lapbeth_open() 2022-11-08 12:47:36 +01:00
Makefile net: wan: remove support for Z85230-based devices 2022-04-27 12:22:56 +01:00
n2.c net: split out ndo_siowandev ioctl 2021-07-27 20:11:45 +01:00
pc300too.c net: split out ndo_siowandev ioctl 2021-07-27 20:11:45 +01:00
pci200syn.c net: split out ndo_siowandev ioctl 2021-07-27 20:11:45 +01:00
slic_ds26522.c spi: make remove callback a void function 2022-02-09 13:00:45 +00:00
slic_ds26522.h
wanxl.c net: split out ndo_siowandev ioctl 2021-07-27 20:11:45 +01:00
wanxl.h
wanxlfw.inc_shipped
wanxlfw.S