Chengen Du
b81a523d54
net/sched: Fix UAF when resolving a clash ...
[ Upstream commit 26488172b0292bed837b95a006a3f3431d1898c3 ]
KASAN reports the following UAF:
BUG: KASAN: slab-use-after-free in tcf_ct_flow_table_process_conn+0x12b/0x380 [act_ct]
Read of size 1 at addr ffff888c07603600 by task handler130/6469
Call Trace:
<IRQ>
dump_stack_lvl+0x48/0x70
print_address_description.constprop.0+0x33/0x3d0
print_report+0xc0/0x2b0
kasan_report+0xd0/0x120
__asan_load1+0x6c/0x80
tcf_ct_flow_table_process_conn+0x12b/0x380 [act_ct]
tcf_ct_act+0x886/0x1350 [act_ct]
tcf_action_exec+0xf8/0x1f0
fl_classify+0x355/0x360 [cls_flower]
__tcf_classify+0x1fd/0x330
tcf_classify+0x21c/0x3c0
sch_handle_ingress.constprop.0+0x2c5/0x500
__netif_receive_skb_core.constprop.0+0xb25/0x1510
__netif_receive_skb_list_core+0x220/0x4c0
netif_receive_skb_list_internal+0x446/0x620
napi_complete_done+0x157/0x3d0
gro_cell_poll+0xcf/0x100
__napi_poll+0x65/0x310
net_rx_action+0x30c/0x5c0
__do_softirq+0x14f/0x491
__irq_exit_rcu+0x82/0xc0
irq_exit_rcu+0xe/0x20
common_interrupt+0xa1/0xb0
</IRQ>
<TASK>
asm_common_interrupt+0x27/0x40
Allocated by task 6469:
kasan_save_stack+0x38/0x70
kasan_set_track+0x25/0x40
kasan_save_alloc_info+0x1e/0x40
__kasan_krealloc+0x133/0x190
krealloc+0xaa/0x130
nf_ct_ext_add+0xed/0x230 [nf_conntrack]
tcf_ct_act+0x1095/0x1350 [act_ct]
tcf_action_exec+0xf8/0x1f0
fl_classify+0x355/0x360 [cls_flower]
__tcf_classify+0x1fd/0x330
tcf_classify+0x21c/0x3c0
sch_handle_ingress.constprop.0+0x2c5/0x500
__netif_receive_skb_core.constprop.0+0xb25/0x1510
__netif_receive_skb_list_core+0x220/0x4c0
netif_receive_skb_list_internal+0x446/0x620
napi_complete_done+0x157/0x3d0
gro_cell_poll+0xcf/0x100
__napi_poll+0x65/0x310
net_rx_action+0x30c/0x5c0
__do_softirq+0x14f/0x491
Freed by task 6469:
kasan_save_stack+0x38/0x70
kasan_set_track+0x25/0x40
kasan_save_free_info+0x2b/0x60
____kasan_slab_free+0x180/0x1f0
__kasan_slab_free+0x12/0x30
slab_free_freelist_hook+0xd2/0x1a0
__kmem_cache_free+0x1a2/0x2f0
kfree+0x78/0x120
nf_conntrack_free+0x74/0x130 [nf_conntrack]
nf_ct_destroy+0xb2/0x140 [nf_conntrack]
__nf_ct_resolve_clash+0x529/0x5d0 [nf_conntrack]
nf_ct_resolve_clash+0xf6/0x490 [nf_conntrack]
__nf_conntrack_confirm+0x2c6/0x770 [nf_conntrack]
tcf_ct_act+0x12ad/0x1350 [act_ct]
tcf_action_exec+0xf8/0x1f0
fl_classify+0x355/0x360 [cls_flower]
__tcf_classify+0x1fd/0x330
tcf_classify+0x21c/0x3c0
sch_handle_ingress.constprop.0+0x2c5/0x500
__netif_receive_skb_core.constprop.0+0xb25/0x1510
__netif_receive_skb_list_core+0x220/0x4c0
netif_receive_skb_list_internal+0x446/0x620
napi_complete_done+0x157/0x3d0
gro_cell_poll+0xcf/0x100
__napi_poll+0x65/0x310
net_rx_action+0x30c/0x5c0
__do_softirq+0x14f/0x491
The ct may be dropped if a clash has been resolved but is still passed to
the tcf_ct_flow_table_process_conn function for further usage. This issue
can be fixed by retrieving ct from skb again after confirming conntrack.
Fixes: 0cc254e5aa37 ("net/sched: act_ct: Offload connections with commit action")
Co-developed-by: Gerald Yang <gerald.yang@canonical.com>
Signed-off-by: Gerald Yang <gerald.yang@canonical.com>
Signed-off-by: Chengen Du <chengen.du@canonical.com>
Link: https://patch.msgid.link/20240710053747.13223-1-chengen.du@canonical.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-07-18 13:05:46 +02:00
2024-06-16 13:32:34 +02:00
2023-01-14 10:16:18 +01:00
2024-02-23 08:41:55 +01:00
2023-12-20 15:44:29 +01:00
2023-12-20 15:44:28 +01:00
2022-06-22 14:13:17 +02:00
2024-07-05 09:12:54 +02:00
2024-07-05 09:12:28 +02:00
2023-01-14 10:15:31 +01:00
2024-05-17 11:48:07 +02:00
2023-03-17 08:45:11 +01:00
2024-07-05 09:12:53 +02:00
2023-10-25 11:54:15 +02:00
2024-07-18 13:05:43 +02:00
2023-08-11 11:57:50 +02:00
2023-11-20 11:06:55 +01:00
2023-06-21 15:45:38 +02:00
2024-01-25 14:37:50 -08:00
2023-07-27 08:44:10 +02:00
2024-05-02 16:23:44 +02:00
2024-07-18 13:05:46 +02:00
2024-03-26 18:22:03 -04:00
2022-11-03 23:57:51 +09:00
2024-01-05 15:12:24 +01:00
2024-07-18 13:05:46 +02:00
2024-07-05 09:12:56 +02:00
2024-07-05 09:12:49 +02:00
2024-03-26 18:21:54 -04:00
2023-08-26 15:26:51 +02:00
2024-05-17 11:48:00 +02:00
2022-04-27 13:53:50 +02:00
2024-02-23 08:42:17 +01:00
2024-07-05 09:12:21 +02:00
2024-04-13 12:58:25 +02:00
2023-02-22 12:55:58 +01:00
2024-07-05 09:12:32 +02:00
2024-07-05 09:12:22 +02:00
2024-07-05 09:12:49 +02:00
2024-01-25 14:37:40 -08:00
2024-05-25 16:19:06 +02:00
2024-07-05 09:12:37 +02:00
2024-06-16 13:32:27 +02:00
2024-05-17 11:48:00 +02:00
2024-06-16 13:32:27 +02:00
2024-07-05 09:12:34 +02:00
2024-05-17 11:48:07 +02:00
2023-12-13 18:27:06 +01:00
2024-06-16 13:32:15 +02:00
2024-04-13 12:59:19 +02:00
2024-01-05 15:12:28 +01:00
2024-01-05 15:12:24 +01:00
2024-02-23 08:42:20 +01:00
2024-07-18 13:05:46 +02:00
2024-07-18 13:05:39 +02:00
2024-04-13 12:59:43 +02:00
2021-11-18 14:04:27 +01:00
2024-07-05 09:12:47 +02:00
2024-07-05 09:12:38 +02:00
2024-06-16 13:32:27 +02:00
2024-07-05 09:12:23 +02:00
2024-01-25 14:37:45 -08:00
2024-07-05 09:12:21 +02:00
2024-03-26 18:21:54 -04:00
2024-05-02 16:23:33 +02:00
2024-06-16 13:32:36 +02:00
2023-06-21 15:45:38 +02:00
2023-06-21 15:45:38 +02:00
2024-01-15 18:48:04 +01:00
b81a523d54