iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/net
History
Stanislav Fomichev 148dcbd3af ppp: associate skb with a device at tx 
[ Upstream commit 9f225444467b98579cf28d94f4ad053460dfdb84 ]

Syzkaller triggered flow dissector warning with the following:

r0 = openat$ppp(0xffffffffffffff9c, &(0x7f0000000000), 0xc0802, 0x0)
ioctl$PPPIOCNEWUNIT(r0, 0xc004743e, &(0x7f00000000c0))
ioctl$PPPIOCSACTIVE(r0, 0x40107446, &(0x7f0000000240)={0x2, &(0x7f0000000180)=[{0x20, 0x0, 0x0, 0xfffff034}, {0x6}]})
pwritev(r0, &(0x7f0000000040)=[{&(0x7f0000000140)='\x00!', 0x2}], 0x1, 0x0, 0x0)

[    9.485814] WARNING: CPU: 3 PID: 329 at net/core/flow_dissector.c:1016 __skb_flow_dissect+0x1ee0/0x1fa0
[    9.485929]  skb_get_poff+0x53/0xa0
[    9.485937]  bpf_skb_get_pay_offset+0xe/0x20
[    9.485944]  ? ppp_send_frame+0xc2/0x5b0
[    9.485949]  ? _raw_spin_unlock_irqrestore+0x40/0x60
[    9.485958]  ? __ppp_xmit_process+0x7a/0xe0
[    9.485968]  ? ppp_xmit_process+0x5b/0xb0
[    9.485974]  ? ppp_write+0x12a/0x190
[    9.485981]  ? do_iter_write+0x18e/0x2d0
[    9.485987]  ? __import_iovec+0x30/0x130
[    9.485997]  ? do_pwritev+0x1b6/0x240
[    9.486016]  ? trace_hardirqs_on+0x47/0x50
[    9.486023]  ? __x64_sys_pwritev+0x24/0x30
[    9.486026]  ? do_syscall_64+0x3d/0x80
[    9.486031]  ? entry_SYSCALL_64_after_hwframe+0x63/0xcd

Flow dissector tries to find skb net namespace either via device
or via socket. Neigher is set in ppp_send_frame, so let's manually
use ppp->dev.

Cc: Paul Mackerras <paulus@samba.org>
Cc: linux-ppp@vger.kernel.org
Reported-by: syzbot+41cab52ab62ee99ed24a@syzkaller.appspotmail.com
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-01-14 10:16:18 +01:00
..
appletalk
…
arcnet
arcnet: fix potential memory leak in com20020_probe()
2022-12-02 17:40:02 +01:00
bonding
bonding: uninitialized variable in bond_miimon_inspect()
2023-01-14 10:15:35 +01:00
caif
caif_virtio: fix race between virtio_device_ready() and ndo_open()
2022-07-07 17:52:18 +02:00
can
can: tcan4x5x: Remove invalid write in clear_interrupts
2023-01-14 10:15:44 +01:00
dsa
net: lan9303: Fix read error execution path
2023-01-14 10:15:44 +01:00
ethernet
igb: Do not free q_vector unless new one was allocated
2023-01-14 10:16:16 +01:00
fddi
net: defxx: Fix missing err handling in dfx_init()
2023-01-14 10:15:42 +01:00
fjes
…
hamradio
hamradio: baycom_epp: Fix return type of baycom_send_packet()
2023-01-14 10:16:16 +01:00
hippi
drivers: net: hippi: Fix deadlock in rr_close()
2022-05-09 09:05:06 +02:00
hyperv
hv_netvsc: Fix race between VF offering and VF association message from host
2022-10-30 09:41:19 +01:00
ieee802154
ca8210: Fix crash by zero initializing data
2022-12-14 11:32:00 +01:00
ipa
net: ipa: properly limit modem routing table use
2022-09-28 11:10:34 +02:00
ipvlan
ipvlan: Fix out-of-bound bugs caused by unset skb->mac_header
2022-09-28 11:10:30 +02:00
mdio
of: mdio: Add of_node_put() when breaking out of for_each_xx
2022-09-28 11:10:33 +02:00
netdevsim
net: Use u64_stats_fetch_begin_irq() for stats fetch.
2022-09-08 11:11:40 +02:00
pcs
…
phy
net: phy: fix null-ptr-deref while probe() failed
2022-12-08 11:23:56 +01:00
plip
net: plip: don't call kfree_skb/dev_kfree_skb() under spin_lock_irq()
2022-12-14 11:32:04 +01:00
ppp
ppp: associate skb with a device at tx
2023-01-14 10:16:18 +01:00
slip
drivers: net: slip: fix NPD bug in sl_tx_timeout()
2022-04-20 09:23:24 +02:00
team
net: team: Unsync device addresses on ndo_stop
2022-09-28 11:10:31 +02:00
usb
net: usb: qmi_wwan: add u-blox 0x1342 composition
2022-12-14 11:31:54 +01:00
vmxnet3
vmxnet3: correctly report encapsulated LRO packet
2022-12-14 11:32:01 +01:00
wan
net: farsync: Fix kmemleak when rmmods farsync
2023-01-14 10:15:43 +01:00
wimax
…
wireguard
wireguard: netlink: avoid variable-sized memcpy on sockaddr
2022-09-28 11:10:34 +02:00
wireless
wifi: brcmfmac: Fix potential shift-out-of-bounds in brcmf_fw_alloc_request()
2023-01-14 10:16:16 +01:00
xen-netback
xen/netback: fix build warning
2022-12-14 11:32:04 +01:00
bareudp.c
bareudp: use ipv6_mod_enabled to check if IPv6 enabled
2022-04-08 14:40:22 +02:00
dummy.c
…
eql.c
…
geneve.c
geneve: fix TOS inheriting for ipv4
2022-08-25 11:38:02 +02:00
gtp.c
…
ifb.c
…
Kconfig
lib/crypto: blake2s: include as built-in
2022-05-30 09:33:26 +02:00
LICENSE.SRC
…
loopback.c
net: loopback: use NET_NAME_PREDICTABLE for name_assign_type
2022-12-21 17:32:08 +01:00
macsec.c
net: macsec: fix net device access prior to holding a lock
2023-01-14 10:16:09 +01:00
macvlan.c
macvlan: enforce a consistent minimal mtu
2022-11-25 17:45:55 +01:00
macvtap.c
macvtap: advertise link netns via netlink
2022-04-13 21:00:59 +02:00
Makefile
…
mdio.c
…
mii.c
…
net_failover.c
…
netconsole.c
…
nlmon.c
…
ntb_netdev.c
ntb_netdev: Use dev_kfree_skb_any() in interrupt context
2023-01-14 10:15:44 +01:00
rionet.c
…
sb1000.c
…
Space.c
…
sungem_phy.c
net: sungem_phy: Add of_node_put() for reference returned by of_get_parent()
2022-08-03 12:00:46 +02:00
tap.c
tuntap: add sanity checks about msg_controllen in sendmsg
2022-04-13 21:00:59 +02:00
thunderbolt.c
net: thunderbolt: Fix error handling in tbnet_init()
2022-11-25 17:45:48 +01:00
tun.c
net: tun: Fix use-after-free in tun_detach()
2022-12-08 11:23:56 +01:00
veth.c
veth: Ensure eth header is in skb's linear part
2022-04-20 09:23:11 +02:00
virtio_net.c
virtio_net: fix memory leak inside XPD_TX with mergeable
2022-08-25 11:37:57 +02:00
vrf.c
…
vsockmon.c
…
vxlan.c
vxlan: fix error return code in vxlan_fdb_append
2022-04-27 13:53:53 +02:00
xen-netfront.c
xen-netfront: Fix NULL sring after live migration
2022-12-14 11:32:02 +01:00