Jeff Layton 15a8b55dbb nfsd: call op_release, even when op_func returns an error
For ops with "trivial" replies, nfsd4_encode_operation will shortcut
most of the encoding work and skip to just marshalling up the status.
One of the things it skips is calling op_release. This could cause a
memory leak in the layoutget codepath if there is an error at an
inopportune time.

Have the compound processing engine always call op_release, even when
op_func sets an error in op->status. With this change, we also need
nfsd4_block_get_device_info_scsi to set the gd_device pointer to NULL
on error to avoid a double free.

Reported-by: Zhi Li <yieli@redhat.com>
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2181403
Fixes: 34b1744c91cc ("nfsd4: define ->op_release for compound ops")
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2023-03-31 17:29:49 -04:00
..
2022-12-23 11:39:18 -08:00
2023-02-12 11:26:36 -08:00
2022-12-13 10:43:59 -08:00
2022-12-15 18:14:21 -08:00
\n
2022-12-12 20:32:50 -08:00
2022-12-13 19:29:45 -08:00
2023-01-31 16:44:08 -08:00
2022-12-13 19:29:45 -08:00
2022-12-11 18:12:18 -08:00
2022-12-14 10:11:51 -08:00
2022-10-20 10:13:27 +02:00
2022-12-13 19:29:45 -08:00
2022-09-24 07:00:00 +02:00
2023-03-10 09:38:47 -05:00
2022-12-11 18:12:18 -08:00
2022-12-23 11:55:54 -08:00
2022-10-10 19:45:17 -07:00
2022-12-13 09:47:48 -08:00
2022-05-09 16:21:46 -04:00
2023-01-06 15:44:32 +01:00
2022-09-11 20:26:07 -07:00
2023-01-05 07:34:21 -08:00
2023-02-03 17:52:24 -08:00
2022-10-20 10:13:27 +02:00
2022-08-20 11:34:33 -04:00
2022-10-10 19:45:17 -07:00
2022-12-12 19:20:05 -08:00
2022-12-15 18:09:48 -08:00
2022-12-12 19:20:05 -08:00
2022-12-12 19:03:10 -08:00
2022-04-01 19:35:56 -07:00
2022-10-10 14:21:11 -07:00
2022-08-03 10:35:43 -07:00
2022-12-12 19:30:18 -08:00
2022-12-13 09:14:50 -08:00
2022-12-21 14:45:25 +01:00
2022-12-12 19:30:18 -08:00
2022-06-28 13:58:05 -04:00
2022-12-13 10:26:38 -08:00
2022-10-26 10:02:34 +02:00
2022-12-12 18:38:47 -08:00