Jakub Kicinski 166c2c8a6a net/sched: act_mirred: don't override retval if we already lost the skb
If we're redirecting the skb, and haven't called tcf_mirred_forward(),
yet, we need to tell the core to drop the skb by setting the retcode
to SHOT. If we have called tcf_mirred_forward(), however, the skb
is out of our hands and returning SHOT will lead to UaF.

Move the retval override to the error path which actually need it.

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Fixes: e5cf1baf92cb ("act_mirred: use TC_ACT_REINSERT when possible")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2024-02-16 10:13:31 +00:00
..
2023-10-01 19:09:54 +01:00
2024-01-18 11:37:24 -08:00
2023-12-15 16:25:55 -08:00
2023-12-26 20:31:01 +00:00
2024-01-11 10:07:29 -08:00
2024-01-03 18:37:22 -08:00
2023-12-26 20:31:01 +00:00
2023-12-12 14:24:14 +01:00
2024-01-04 10:23:10 -08:00
2024-01-04 10:23:10 -08:00
2024-01-08 11:43:04 -08:00