8b631f9cf0
The bio based I/O path complicates null_blk and also make various data structures, including the per-command one way bigger than required for the main request based interface. As the bio-based path is mostly used by stacking drivers and simple memory based drivers, and brd is a good example driver for the latter there is no need to have a bio based path in null_blk. Remove the path to simplify the driver and make future block layer API changes simpler by not having to deal with the complex two API setup in null_blk. Note that the queue_mode field in struct nullb_device is kept as that is simpler than having two different places to check the value and fully open coding the debugfs helpers as the existing ones won't work without a named struct member. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Hannes Reinecke <hare@suse.de> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Tested-by: Damien Le Moal <dlemoal@kernel.org> Link: https://lore.kernel.org/r/20240220093248.3290292-2-hch@lst.de Signed-off-by: Jens Axboe <axboe@kernel.dk>
81 lines
2.1 KiB
C
81 lines
2.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* null_blk device driver tracepoints.
|
|
*
|
|
* Copyright (C) 2020 Western Digital Corporation or its affiliates.
|
|
*/
|
|
|
|
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM nullb
|
|
|
|
#if !defined(_TRACE_NULLB_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _TRACE_NULLB_H
|
|
|
|
#include <linux/tracepoint.h>
|
|
#include <linux/trace_seq.h>
|
|
|
|
#include "null_blk.h"
|
|
|
|
const char *nullb_trace_disk_name(struct trace_seq *p, char *name);
|
|
|
|
#define __print_disk_name(name) nullb_trace_disk_name(p, name)
|
|
|
|
#ifndef TRACE_HEADER_MULTI_READ
|
|
static inline void __assign_disk_name(char *name, struct gendisk *disk)
|
|
{
|
|
if (disk)
|
|
memcpy(name, disk->disk_name, DISK_NAME_LEN);
|
|
else
|
|
memset(name, 0, DISK_NAME_LEN);
|
|
}
|
|
#endif
|
|
|
|
TRACE_EVENT(nullb_zone_op,
|
|
TP_PROTO(struct nullb_cmd *cmd, unsigned int zone_no,
|
|
unsigned int zone_cond),
|
|
TP_ARGS(cmd, zone_no, zone_cond),
|
|
TP_STRUCT__entry(
|
|
__array(char, disk, DISK_NAME_LEN)
|
|
__field(enum req_op, op)
|
|
__field(unsigned int, zone_no)
|
|
__field(unsigned int, zone_cond)
|
|
),
|
|
TP_fast_assign(
|
|
__entry->op = req_op(blk_mq_rq_from_pdu(cmd));
|
|
__entry->zone_no = zone_no;
|
|
__entry->zone_cond = zone_cond;
|
|
__assign_disk_name(__entry->disk,
|
|
blk_mq_rq_from_pdu(cmd)->q->disk);
|
|
),
|
|
TP_printk("%s req=%-15s zone_no=%u zone_cond=%-10s",
|
|
__print_disk_name(__entry->disk),
|
|
blk_op_str(__entry->op),
|
|
__entry->zone_no,
|
|
blk_zone_cond_str(__entry->zone_cond))
|
|
);
|
|
|
|
TRACE_EVENT(nullb_report_zones,
|
|
TP_PROTO(struct nullb *nullb, unsigned int nr_zones),
|
|
TP_ARGS(nullb, nr_zones),
|
|
TP_STRUCT__entry(
|
|
__array(char, disk, DISK_NAME_LEN)
|
|
__field(unsigned int, nr_zones)
|
|
),
|
|
TP_fast_assign(
|
|
__entry->nr_zones = nr_zones;
|
|
__assign_disk_name(__entry->disk, nullb->disk);
|
|
),
|
|
TP_printk("%s nr_zones=%u",
|
|
__print_disk_name(__entry->disk), __entry->nr_zones)
|
|
);
|
|
|
|
#endif /* _TRACE_NULLB_H */
|
|
|
|
#undef TRACE_INCLUDE_PATH
|
|
#define TRACE_INCLUDE_PATH .
|
|
#undef TRACE_INCLUDE_FILE
|
|
#define TRACE_INCLUDE_FILE trace
|
|
|
|
/* This part must be outside protection */
|
|
#include <trace/define_trace.h>
|