David Disseldorp 179a88a855 cifs: fix DFS traversal oops without CONFIG_CIFS_DFS_UPCALL
When compiled with CONFIG_CIFS_DFS_UPCALL disabled, cifs_dfs_d_automount
is NULL. cifs.ko logic for mapping CIFS_FATTR_DFS_REFERRAL attributes to
S_AUTOMOUNT and corresponding dentry flags is retained regardless of
CONFIG_CIFS_DFS_UPCALL, leading to a NULL pointer dereference in
VFS follow_automount() when traversing a DFS referral link:
  BUG: kernel NULL pointer dereference, address: 0000000000000000
  ...
  Call Trace:
   <TASK>
   __traverse_mounts+0xb5/0x220
   ? cifs_revalidate_mapping+0x65/0xc0 [cifs]
   step_into+0x195/0x610
   ? lookup_fast+0xe2/0xf0
   path_lookupat+0x64/0x140
   filename_lookup+0xc2/0x140
   ? __create_object+0x299/0x380
   ? kmem_cache_alloc+0x119/0x220
   ? user_path_at_empty+0x31/0x50
   user_path_at_empty+0x31/0x50
   __x64_sys_chdir+0x2a/0xd0
   ? exit_to_user_mode_prepare+0xca/0x100
   do_syscall_64+0x42/0x90
   entry_SYSCALL_64_after_hwframe+0x72/0xdc

This fix adds an inline cifs_dfs_d_automount() {return -EREMOTE} handler
when CONFIG_CIFS_DFS_UPCALL is disabled. An alternative would be to
avoid flagging S_AUTOMOUNT, etc. without CONFIG_CIFS_DFS_UPCALL. This
approach was chosen as it provides more control over the error path.

Signed-off-by: David Disseldorp <ddiss@suse.de>
Cc: stable@vger.kernel.org
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
2023-03-30 17:28:44 -05:00
..
2023-02-20 14:10:36 -08:00
2023-03-24 08:32:10 -07:00
2023-02-21 11:07:23 -08:00
2023-02-27 10:04:49 -08:00
2023-02-24 12:58:55 -08:00
2023-03-01 08:42:27 -08:00
2023-02-20 14:10:36 -08:00
2023-02-27 16:18:51 -08:00
2023-02-27 09:53:58 -08:00
2023-03-01 08:47:19 -08:00
2023-02-24 12:58:55 -08:00
2023-03-01 18:18:25 -06:00
2023-03-21 14:48:38 -07:00
2023-03-21 14:48:38 -07:00
2023-02-21 10:45:51 -08:00
2023-02-20 11:53:11 -08:00
2022-12-23 11:55:54 -08:00
2023-02-21 10:45:51 -08:00
2023-03-24 13:16:01 -07:00
2023-02-20 11:53:11 -08:00
2023-01-31 15:01:20 +01:00
2022-08-20 11:34:33 -04:00
2022-10-10 19:45:17 -07:00
2023-02-20 11:53:11 -08:00
2023-02-20 11:53:11 -08:00
2023-02-20 14:10:36 -08:00
2022-10-10 14:21:11 -07:00
2023-02-20 11:53:11 -08:00
2023-02-20 14:10:36 -08:00
2023-01-19 09:24:30 +01:00
2023-02-22 14:21:40 -08:00
2023-01-11 15:47:40 -05:00
2022-12-21 14:45:25 +01:00
2023-02-20 12:14:33 -08:00
2023-02-20 11:53:11 -08:00
2023-02-20 11:53:11 -08:00
2023-02-20 11:53:11 -08:00