iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers
History
Bart Van Assche 17c5f65db6 scsi: qla2xxx: Fix a NULL pointer dereference in an error path 
This patch fixes the following Coverity complaint:

FORWARD_NULL

qla_init.c: 5275 in qla2x00_configure_local_loop()
5269
5270     		if (fcport->scan_state == QLA_FCPORT_FOUND)
5271     			qla24xx_fcport_handle_login(vha, fcport);
5272     	}
5273
5274     cleanup_allocation:
>>>     CID 353340:    (FORWARD_NULL)
>>>     Passing null pointer "new_fcport" to "qla2x00_free_fcport", which dereferences it.
5275     	qla2x00_free_fcport(new_fcport);
5276
5277     	if (rval != QLA_SUCCESS) {
5278     		ql_dbg(ql_dbg_disc, vha, 0x2098,
5279     		    "Configure local loop error exit: rval=%x.\n", rval);
5280     	}
qla_init.c: 5275 in qla2x00_configure_local_loop()
5269
5270     		if (fcport->scan_state == QLA_FCPORT_FOUND)
5271     			qla24xx_fcport_handle_login(vha, fcport);
5272     	}
5273
5274     cleanup_allocation:
>>>     CID 353340:    (FORWARD_NULL)
>>>     Passing null pointer "new_fcport" to "qla2x00_free_fcport", which dereferences it.
5275     	qla2x00_free_fcport(new_fcport);
5276
5277     	if (rval != QLA_SUCCESS) {
5278     		ql_dbg(ql_dbg_disc, vha, 0x2098,
5279     		    "Configure local loop error exit: rval=%x.\n", rval);
5280     	}

Fixes: 3dae220595ba ("scsi: qla2xxx: Use common routine to free fcport struct")
Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Quinn Tran <qutran@marvell.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Daniel Wagner <dwagner@suse.de>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Link: https://lore.kernel.org/r/20200118042056.32232-1-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2020-01-20 18:38:20 -05:00
..
accessibility
…
acpi
ACPI: PM: Avoid attaching ACPI PM domain to certain devices
2019-12-10 00:22:18 +01:00
amba
…
android
binder: fix incorrect calculation for num_valid
2019-12-14 09:10:47 +01:00
ata
compat_ioctl: scsi: handle HDIO commands from drivers
2020-01-03 09:42:52 +01:00
atm
…
auxdisplay
auxdisplay: charlcd: deduplicate simple_strtoul()
2019-12-04 19:44:12 -08:00
base
scsi: drivers: base: Propagate errors through the transport component
2020-01-15 22:55:37 -05:00
bcma
…
block
compat_ioctl: move cdrom commands into cdrom.c
2020-01-03 09:42:52 +01:00
bluetooth
Bluetooth: btbcm: Use the BDADDR_PROPERTY quirk
2019-11-22 13:35:20 +01:00
bus
bus: ti-sysc: Fix missing reset delay handling
2019-12-12 08:20:10 -08:00
cdrom
compat_ioctl: move cdrom commands into cdrom.c
2020-01-03 09:42:52 +01:00
char
Char/misc driver fixes for 5.5-rc3
2019-12-20 10:11:30 -08:00
clk
clk: qcom: Avoid SMMU/cx gdsc corner cases
2019-12-18 22:02:27 -08:00
clocksource
Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-12-03 12:20:25 -08:00
connector
…
counter
…
cpufreq
cpufreq: vexpress-spc: Switch cpumask from topology core to OPP sharing
2019-12-09 11:52:50 +00:00
cpuidle
cpuidle: Drop unnecessary type cast in cpuidle_poll_time()
2019-12-12 17:56:08 +01:00
crypto
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-12-02 17:23:21 -08:00
dax
libnvdimm for 5.5
2019-12-01 18:43:25 -08:00
dca
…
devfreq
PM / devfreq: tegra: Add COMMON_CLK dependency
2019-12-23 10:42:58 +09:00
dio
…
dma
dmaengine: Fix Kconfig indentation
2019-11-22 11:16:26 +05:30
dma-buf
- A fix for a memory leak in the dma-buf support
2019-12-09 17:13:19 +10:00
edac
riscv: move sifive_l2_cache.c to drivers/soc
2019-12-20 03:40:24 -08:00
eisa
…
extcon
Char/Misc driver patches for 5.5-rc1
2019-11-27 10:53:50 -08:00
firewire
FireWire (IEEE 1394) subsystem updates:
2019-12-02 14:13:00 -08:00
firmware
Merge branch 'efi-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-12-17 10:39:55 -08:00
fpga
…
fsi
…
gnss
…
gpio
A set of fixes for the v5.5 series:
2019-12-27 11:02:48 -08:00
gpu
drm/i915: Hold reference to intel_frontbuffer as we track activity
2019-12-23 14:27:23 +02:00
greybus
…
hid
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid
2019-12-01 18:20:54 -08:00
hsi
…
hv
Merge branch 'akpm' (patches from Andrew)
2019-12-01 20:36:41 -08:00
hwmon
compat_ioctl: remove most of fs/compat_ioctl.c
2019-12-01 13:46:15 -08:00
hwspinlock
…
hwtracing
intel_th: msu: Fix window switching without windows
2019-12-17 15:45:59 +01:00
i2c
i2c: remove i2c_new_dummy() API
2019-12-10 23:15:09 +01:00
i3c
…
ide
compat_ioctl: move HDIO ioctl handling into drivers/ide
2020-01-03 09:42:52 +01:00
idle
cpuidle: Drop disabled field from struct cpuidle_state
2019-11-29 11:48:39 +01:00
iio
First set of fixes for IIO in the 5.5 cycle.
2019-12-09 09:27:52 +01:00
infiniband
Pull request for 5.5-rc2
2019-12-15 14:58:13 -08:00
input
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
2019-12-07 18:33:01 -08:00
interconnect
interconnect: qcom: msm8974: Walk the list safely on node removal
2019-12-12 10:28:54 +01:00
iommu
IOMMU Fixes for Linux v5.5-rc2
2019-12-20 10:42:25 -08:00
ipack
…
irqchip
pci-v5.5-changes
2019-12-03 13:58:22 -08:00
isdn
compat_ioctl: remove most of fs/compat_ioctl.c
2019-12-01 13:46:15 -08:00
leds
Merge tag 'leds-5.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds
2019-12-01 16:09:28 -08:00
lightnvm
…
macintosh
powerpc updates for 5.5
2019-11-30 14:35:43 -08:00
mailbox
mailbox changes for v5.5
2019-12-01 18:42:02 -08:00
mcb
…
md
for-linus-20191212
2019-12-13 14:27:19 -08:00
media
treewide: Use sizeof_field() macro
2019-12-09 10:36:44 -08:00
memory
memory: tegra: Fixes for v5.5-rc1
2019-12-06 08:28:51 -08:00
memstick
pci-v5.5-changes
2019-12-03 13:58:22 -08:00
message
…
mfd
chrome platform changes for v5.5
2019-12-03 14:37:12 -08:00
misc
powerpc fixes for 5.5 #4
2019-12-21 06:17:05 -08:00
mmc
mmc: sdhci-of-esdhc: re-implement erratum A-009204 workaround
2019-12-19 08:13:43 +01:00
mtd
TTY/Serial patches for 5.5-rc1
2019-12-03 14:09:14 -08:00
mux
…
net
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-12-22 09:54:33 -08:00
nfc
nfc: s3fwrn5: replace the assertion with a WARN_ON
2019-12-19 17:33:23 -08:00
ntb
Add Hygon Device ID to the AMD NTB device driver
2019-12-07 18:38:17 -08:00
nubus
…
nvdimm
libnvdimm for 5.5
2019-12-01 18:43:25 -08:00
nvme
for-linus-20191212
2019-12-13 14:27:19 -08:00
nvmem
ARM: SoC-related driver updates
2019-12-05 11:43:31 -08:00
of
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-12-22 09:54:33 -08:00
opp
…
oprofile
Printk changes for 5.5
2019-11-25 19:40:40 -08:00
parisc
…
parport
parport: daisy: use new parport device model
2019-11-13 19:09:49 +08:00
pci
PCI: rockchip: Fix IO outbound ATU register number
2019-12-12 15:25:37 -06:00
pcmcia
pcmcia: remove unused dprintk definition
2019-11-22 07:03:45 +01:00
perf
perf/smmuv3: Remove the leftover put_cpu() in error path
2019-12-18 16:15:36 +00:00
phy
ARM: SoC-related driver updates
2019-12-05 11:43:31 -08:00
pinctrl
pinctrl: ingenic: Fixup PIN_CONFIG_OUTPUT config
2019-12-16 11:38:20 +01:00
platform
platform/x86: pcengines-apuv2: Spelling fixes in the driver
2019-12-20 19:01:59 +02:00
pnp
…
power
Additional power management updates for 5.5-rc1
2019-12-04 10:48:09 -08:00
powercap
…
pps
…
ps3
…
ptp
ptp: clockmatrix: add I2C dependency
2019-12-13 15:42:09 -08:00
pwm
pwm: Changes for v5.5-rc1
2019-12-05 11:28:14 -08:00
rapidio
drivers/rapidio/rio-access.c: fix missing include of <linux/rio_drv.h>
2019-12-04 19:44:13 -08:00
ras
…
regulator
regulator: Fixes for v5.5
2019-12-17 13:08:41 -08:00
remoteproc
remoteproc: stm32: fix probe error case
2019-11-18 20:35:16 -08:00
reset
reset: Do not register resource data for missing resets
2019-12-10 11:43:37 +01:00
rpmsg
rpmsg updates for v5.5
2019-12-01 18:39:24 -08:00
rtc
RTC for 5.5
2019-12-03 13:31:08 -08:00
s390
block-5.5-20191221
2019-12-22 10:36:55 -08:00
sbus
…
scsi
scsi: qla2xxx: Fix a NULL pointer dereference in an error path
2020-01-20 18:38:20 -05:00
sfi
…
sh
…
siox
…
slimbus
…
soc
riscv: move sifive_l2_cache.c to drivers/soc
2019-12-20 03:40:24 -08:00
soundwire
…
spi
spi: Fixes for v5.5
2019-12-17 13:06:31 -08:00
spmi
…
ssb
…
staging
staging: wfx: fix wrong error message
2019-12-18 15:51:06 +01:00
target
block, scsi: final compat_ioctl cleanup
2020-01-10 00:14:46 -05:00
tc
…
tee
Merge mainline/master into arm/fixes
2019-12-05 13:18:54 -08:00
thermal
thermal: power_allocator: Fix Kconfig warning
2019-12-07 21:49:06 +08:00
thunderbolt
thunderbolt: Power cycle the router if NVM authentication fails
2019-11-19 17:35:57 +01:00
tty
tty/serial: atmel: fix out of range clock divider handling
2019-12-17 14:17:32 +01:00
uio
uio: fix irq init with dt support & irq not defined
2019-11-14 11:49:48 +08:00
usb
usb: xhci: Fix build warning seen with CONFIG_PM=n
2019-12-18 19:23:42 +01:00
vfio
VFIO updates for v5.5-rc1
2019-12-07 14:51:04 -08:00
vhost
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-12-08 13:28:11 -08:00
video
pci-v5.5-changes
2019-12-03 13:58:22 -08:00
virt
compat_ioctl: remove most of fs/compat_ioctl.c
2019-12-01 13:46:15 -08:00
virtio
virtio_balloon: divide/multiply instead of shifts
2019-12-11 08:14:07 -05:00
visorbus
…
vlynq
…
vme
…
w1
w1: new driver. DS2430 chip
2019-11-14 13:06:33 +08:00
watchdog
linux-watchdog 5.5-rc1 tag
2019-12-01 18:01:03 -08:00
xen
xen: branch for v5.5-rc3
2019-12-21 06:24:56 -08:00
zorro
…
Kconfig
…
Makefile
…