Nicholas Bellinger 17c61ad66f iscsi-target: Fix early login failure statistics misses
Due to the long standing checks in iscsit_snmp_get_tiqn()
that assume conn->sess->tpg dereference of tpg->tpg_tiqn
for iscsit_collect_login_stats() usage, some of the early
login failure cases like ISCSI_LOGIN_STATUS_TGT_FORBIDDEN
where not getting incremented, due to sess->tpg assignment
happening later in iscsi_login_zero_tsih_s2().

Instead, use the earlier conn->tpg assignment done by
iscsi_target_locate_portal() -> iscsit_get_tpg_from_np()
so the existing counters are incremented correctly for
the various early login failure cases.

Also, go ahead and drop the old rate limiting check in
iscsit_collect_login_stats(), so we get the true number
of failed login attempts in the existing statistics.

Reported-by: Ryan Stiles <ras@datera.io>
Cc: Ryan Stiles <ras@datera.io>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
2017-02-26 16:18:22 -08:00
..
2017-01-26 17:27:00 -08:00
2017-02-04 10:44:15 -08:00
2016-12-25 10:47:44 +01:00
2016-12-18 15:49:10 -08:00
2017-01-25 15:35:11 +05:30
2017-01-26 00:24:23 +01:00
2017-01-06 10:49:36 -08:00
2016-12-25 10:47:44 +01:00
2016-12-25 17:21:22 +01:00
2017-01-27 10:29:33 -08:00
2016-12-19 08:16:26 -08:00
2017-01-26 17:49:14 +02:00
2016-12-15 12:46:48 -08:00
2016-12-25 10:47:44 +01:00
2016-12-14 10:49:33 -08:00
2016-12-25 17:21:22 +01:00
2016-12-15 11:45:13 -08:00
2017-02-03 13:46:38 -08:00
2016-12-15 16:03:25 -08:00
2017-01-20 12:25:11 -08:00
2017-02-03 22:19:15 +01:00
2016-12-24 11:27:45 -08:00