Pass crtc_state to the enable callback, and connector_state to all callbacks. This will eliminate the need to guess for the correct pipe in these callbacks. The crtc state is required for pch_enable_backlight to obtain the correct cpu_transcoder. intel_dp_aux_backlight's setup function is called before hw readout, so crtc_state and connector_state->best_encoder are NULL in the enable() and set() callbacks. This fixes the following series of warns from intel_get_pipe_from_connector: [ 219.968428] ------------[ cut here ]------------ [ 219.968481] WARNING: CPU: 3 PID: 2457 at drivers/gpu/drm/i915/intel_display.c:13881 intel_get_pipe_from_connector+0x62/0x90 [i915] [ 219.968483] WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex)) [ 219.968485] Modules linked in: nls_iso8859_1 snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec snd_hda_core snd_hwdep snd_pcm intel_rapl x86_pkg_temp_thermal coretemp kvm_intel snd_seq_midi snd_seq_midi_event kvm snd_rawmidi irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pcbc snd_seq snd_seq_device serio_raw snd_timer aesni_intel aes_x86_64 crypto_simd glue_helper cryptd lpc_ich snd mei_me shpchp soundcore mei rfkill_gpio mac_hid intel_pmc_ipc parport_pc ppdev lp parport ip_tables x_tables autofs4 hid_generic usbhid igb ahci i915 xhci_pci dca xhci_hcd ptp sdhci_pci sdhci libahci pps_core i2c_hid hid video [ 219.968573] CPU: 3 PID: 2457 Comm: kworker/u8:3 Tainted: G W 4.10.0-tip-201703010159+ #2 [ 219.968575] Hardware name: Intel Corp. Broxton P/NOTEBOOK, BIOS APLKRVPA.X64.0144.B10.1606270006 06/27/2016 [ 219.968627] Workqueue: events_unbound intel_atomic_commit_work [i915] [ 219.968629] Call Trace: [ 219.968640] dump_stack+0x63/0x87 [ 219.968646] __warn+0xd1/0xf0 [ 219.968651] warn_slowpath_fmt+0x4f/0x60 [ 219.968657] ? drm_printk+0x97/0xa0 [ 219.968708] intel_get_pipe_from_connector+0x62/0x90 [i915] [ 219.968756] intel_panel_enable_backlight+0x19/0xf0 [i915] [ 219.968804] intel_edp_backlight_on.part.22+0x33/0x40 [i915] [ 219.968852] intel_edp_backlight_on+0x18/0x20 [i915] [ 219.968900] intel_enable_ddi+0x94/0xc0 [i915] [ 219.968950] intel_encoders_enable.isra.93+0x77/0x90 [i915] [ 219.969000] haswell_crtc_enable+0x310/0x7f0 [i915] [ 219.969051] intel_update_crtc+0x58/0x100 [i915] [ 219.969101] skl_update_crtcs+0x218/0x240 [i915] [ 219.969153] intel_atomic_commit_tail+0x350/0x1000 [i915] [ 219.969159] ? vtime_account_idle+0xe/0x50 [ 219.969164] ? finish_task_switch+0x107/0x250 [ 219.969214] intel_atomic_commit_work+0x12/0x20 [i915] [ 219.969219] process_one_work+0x153/0x3f0 [ 219.969223] worker_thread+0x12b/0x4b0 [ 219.969227] kthread+0x101/0x140 [ 219.969230] ? rescuer_thread+0x340/0x340 [ 219.969233] ? kthread_park+0x90/0x90 [ 219.969237] ? do_syscall_64+0x6e/0x180 [ 219.969243] ret_from_fork+0x2c/0x40 [ 219.969246] ---[ end trace 0a8fa19387b9ad6d ]--- Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100022 Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/20170612102115.23665-4-maarten.lankhorst@linux.intel.com Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
209 lines
6.7 KiB
C
209 lines
6.7 KiB
C
/*
|
|
* Copyright © 2015 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*
|
|
*/
|
|
|
|
#include "intel_drv.h"
|
|
|
|
static void set_aux_backlight_enable(struct intel_dp *intel_dp, bool enable)
|
|
{
|
|
uint8_t reg_val = 0;
|
|
|
|
/* Early return when display use other mechanism to enable backlight. */
|
|
if (!(intel_dp->edp_dpcd[1] & DP_EDP_BACKLIGHT_AUX_ENABLE_CAP))
|
|
return;
|
|
|
|
if (drm_dp_dpcd_readb(&intel_dp->aux, DP_EDP_DISPLAY_CONTROL_REGISTER,
|
|
®_val) < 0) {
|
|
DRM_DEBUG_KMS("Failed to read DPCD register 0x%x\n",
|
|
DP_EDP_DISPLAY_CONTROL_REGISTER);
|
|
return;
|
|
}
|
|
if (enable)
|
|
reg_val |= DP_EDP_BACKLIGHT_ENABLE;
|
|
else
|
|
reg_val &= ~(DP_EDP_BACKLIGHT_ENABLE);
|
|
|
|
if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_EDP_DISPLAY_CONTROL_REGISTER,
|
|
reg_val) != 1) {
|
|
DRM_DEBUG_KMS("Failed to %s aux backlight\n",
|
|
enable ? "enable" : "disable");
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Read the current backlight value from DPCD register(s) based
|
|
* on if 8-bit(MSB) or 16-bit(MSB and LSB) values are supported
|
|
*/
|
|
static uint32_t intel_dp_aux_get_backlight(struct intel_connector *connector)
|
|
{
|
|
struct intel_dp *intel_dp = enc_to_intel_dp(&connector->encoder->base);
|
|
uint8_t read_val[2] = { 0x0 };
|
|
uint16_t level = 0;
|
|
|
|
if (drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_BACKLIGHT_BRIGHTNESS_MSB,
|
|
&read_val, sizeof(read_val)) < 0) {
|
|
DRM_DEBUG_KMS("Failed to read DPCD register 0x%x\n",
|
|
DP_EDP_BACKLIGHT_BRIGHTNESS_MSB);
|
|
return 0;
|
|
}
|
|
level = read_val[0];
|
|
if (intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_BYTE_COUNT)
|
|
level = (read_val[0] << 8 | read_val[1]);
|
|
|
|
return level;
|
|
}
|
|
|
|
/*
|
|
* Sends the current backlight level over the aux channel, checking if its using
|
|
* 8-bit or 16 bit value (MSB and LSB)
|
|
*/
|
|
static void
|
|
intel_dp_aux_set_backlight(const struct drm_connector_state *conn_state, u32 level)
|
|
{
|
|
/*
|
|
* conn_state->best_encoder is likely NULL when called from
|
|
* intel_dp_aux_setup_backlight()
|
|
*/
|
|
struct intel_connector *connector = to_intel_connector(conn_state->connector);
|
|
struct intel_dp *intel_dp = enc_to_intel_dp(&connector->encoder->base);
|
|
uint8_t vals[2] = { 0x0 };
|
|
|
|
vals[0] = level;
|
|
|
|
/* Write the MSB and/or LSB */
|
|
if (intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_BYTE_COUNT) {
|
|
vals[0] = (level & 0xFF00) >> 8;
|
|
vals[1] = (level & 0xFF);
|
|
}
|
|
if (drm_dp_dpcd_write(&intel_dp->aux, DP_EDP_BACKLIGHT_BRIGHTNESS_MSB,
|
|
vals, sizeof(vals)) < 0) {
|
|
DRM_DEBUG_KMS("Failed to write aux backlight level\n");
|
|
return;
|
|
}
|
|
}
|
|
|
|
static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_state,
|
|
const struct drm_connector_state *conn_state)
|
|
{
|
|
struct intel_connector *connector = to_intel_connector(conn_state->connector);
|
|
/*
|
|
* conn_state->best_encoder (and crtc_state) are NULL when called from
|
|
* intel_dp_aux_setup_backlight()
|
|
*/
|
|
struct intel_dp *intel_dp = enc_to_intel_dp(&connector->encoder->base);
|
|
uint8_t dpcd_buf = 0;
|
|
uint8_t edp_backlight_mode = 0;
|
|
|
|
if (drm_dp_dpcd_readb(&intel_dp->aux,
|
|
DP_EDP_BACKLIGHT_MODE_SET_REGISTER, &dpcd_buf) != 1) {
|
|
DRM_DEBUG_KMS("Failed to read DPCD register 0x%x\n",
|
|
DP_EDP_BACKLIGHT_MODE_SET_REGISTER);
|
|
return;
|
|
}
|
|
|
|
edp_backlight_mode = dpcd_buf & DP_EDP_BACKLIGHT_CONTROL_MODE_MASK;
|
|
|
|
switch (edp_backlight_mode) {
|
|
case DP_EDP_BACKLIGHT_CONTROL_MODE_PWM:
|
|
case DP_EDP_BACKLIGHT_CONTROL_MODE_PRESET:
|
|
case DP_EDP_BACKLIGHT_CONTROL_MODE_PRODUCT:
|
|
dpcd_buf &= ~DP_EDP_BACKLIGHT_CONTROL_MODE_MASK;
|
|
dpcd_buf |= DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD;
|
|
if (drm_dp_dpcd_writeb(&intel_dp->aux,
|
|
DP_EDP_BACKLIGHT_MODE_SET_REGISTER, dpcd_buf) < 0) {
|
|
DRM_DEBUG_KMS("Failed to write aux backlight mode\n");
|
|
}
|
|
break;
|
|
|
|
/* Do nothing when it is already DPCD mode */
|
|
case DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD:
|
|
default:
|
|
break;
|
|
}
|
|
|
|
set_aux_backlight_enable(intel_dp, true);
|
|
intel_dp_aux_set_backlight(conn_state, connector->panel.backlight.level);
|
|
}
|
|
|
|
static void intel_dp_aux_disable_backlight(const struct drm_connector_state *old_conn_state)
|
|
{
|
|
set_aux_backlight_enable(enc_to_intel_dp(old_conn_state->best_encoder), false);
|
|
}
|
|
|
|
static int intel_dp_aux_setup_backlight(struct intel_connector *connector,
|
|
enum pipe pipe)
|
|
{
|
|
struct intel_dp *intel_dp = enc_to_intel_dp(&connector->encoder->base);
|
|
struct intel_panel *panel = &connector->panel;
|
|
|
|
intel_dp_aux_enable_backlight(NULL, connector->base.state);
|
|
|
|
if (intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_BYTE_COUNT)
|
|
panel->backlight.max = 0xFFFF;
|
|
else
|
|
panel->backlight.max = 0xFF;
|
|
|
|
panel->backlight.min = 0;
|
|
panel->backlight.level = intel_dp_aux_get_backlight(connector);
|
|
|
|
panel->backlight.enabled = panel->backlight.level != 0;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static bool
|
|
intel_dp_aux_display_control_capable(struct intel_connector *connector)
|
|
{
|
|
struct intel_dp *intel_dp = enc_to_intel_dp(&connector->encoder->base);
|
|
|
|
/* Check the eDP Display control capabilities registers to determine if
|
|
* the panel can support backlight control over the aux channel
|
|
*/
|
|
if (intel_dp->edp_dpcd[1] & DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP &&
|
|
(intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP) &&
|
|
!(intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_PWM_PIN_CAP)) {
|
|
DRM_DEBUG_KMS("AUX Backlight Control Supported!\n");
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
|
|
{
|
|
struct intel_panel *panel = &intel_connector->panel;
|
|
|
|
if (!i915.enable_dpcd_backlight)
|
|
return -ENODEV;
|
|
|
|
if (!intel_dp_aux_display_control_capable(intel_connector))
|
|
return -ENODEV;
|
|
|
|
panel->backlight.setup = intel_dp_aux_setup_backlight;
|
|
panel->backlight.enable = intel_dp_aux_enable_backlight;
|
|
panel->backlight.disable = intel_dp_aux_disable_backlight;
|
|
panel->backlight.set = intel_dp_aux_set_backlight;
|
|
panel->backlight.get = intel_dp_aux_get_backlight;
|
|
|
|
return 0;
|
|
}
|