Eduard Zingerman 1a49f4195d bpf: Avoid dummy bpf_offload_netdev in __bpf_prog_dev_bound_init
Fix for a bug observable under the following sequence of events:
1. Create a network device that does not support XDP offload.
2. Load a device bound XDP program with BPF_F_XDP_DEV_BOUND_ONLY flag
   (such programs are not offloaded).
3. Load a device bound XDP program with zero flags
   (such programs are offloaded).

At step (2) __bpf_prog_dev_bound_init() associates with device (1)
a dummy bpf_offload_netdev struct with .offdev field set to NULL.
At step (3) __bpf_prog_dev_bound_init() would reuse dummy struct
allocated at step (2).
However, downstream usage of the bpf_offload_netdev assumes that
.offdev field can't be NULL, e.g. in bpf_prog_offload_verifier_prep().

Adjust __bpf_prog_dev_bound_init() to require bpf_offload_netdev
with non-NULL .offdev for offloaded BPF programs.

Fixes: 2b3486bc2d23 ("bpf: Introduce device-bound XDP programs")
Reported-by: syzbot+291100dcb32190ec02a8@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/bpf/000000000000d97f3c060479c4f8@google.com/
Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>
Link: https://lore.kernel.org/r/20230912005539.2248244-2-eddyz87@gmail.com
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
2023-09-11 22:06:06 -07:00
..
2023-09-05 11:01:47 -07:00
2023-09-04 13:20:19 -07:00
2023-08-08 10:29:21 -07:00
2023-08-31 12:43:10 -07:00
2023-09-04 13:20:19 -07:00
2023-09-01 09:38:00 -07:00
2023-08-30 08:17:35 -07:00
2022-09-26 10:13:13 -07:00
2023-08-18 10:18:49 -07:00
2023-09-01 15:44:45 -07:00
2023-03-24 11:01:29 +01:00
2023-08-30 09:16:56 -07:00
2023-08-23 09:38:17 +09:00
2023-06-28 15:51:08 -07:00
2023-08-18 10:12:02 -07:00
2023-06-28 16:05:21 -07:00
2023-08-15 15:26:17 -07:00