Since commit: 94b1b03b519b ("x86/mm: Rework lazy TLB mode and TLB freshness tracking") x86's lazy TLB mode has been all the way lazy: when running a kernel thread (including the idle thread), the kernel keeps using the last user mm's page tables without attempting to maintain user TLB coherence at all. From a pure semantic perspective, this is fine -- kernel threads won't attempt to access user pages, so having stale TLB entries doesn't matter. Unfortunately, I forgot about a subtlety. By skipping TLB flushes, we also allow any paging-structure caches that may exist on the CPU to become incoherent. This means that we can have a paging-structure cache entry that references a freed page table, and the CPU is within its rights to do a speculative page walk starting at the freed page table. I can imagine this causing two different problems: - A speculative page walk starting from a bogus page table could read IO addresses. I haven't seen any reports of this causing problems. - A speculative page walk that involves a bogus page table can install garbage in the TLB. Such garbage would always be at a user VA, but some AMD CPUs have logic that triggers a machine check when it notices these bogus entries. I've seen a couple reports of this. Boris further explains the failure mode: > It is actually more of an optimization which assumes that paging-structure > entries are in WB DRAM: > > "TlbCacheDis: cacheable memory disable. Read-write. 0=Enables > performance optimization that assumes PML4, PDP, PDE, and PTE entries > are in cacheable WB-DRAM; memory type checks may be bypassed, and > addresses outside of WB-DRAM may result in undefined behavior or NB > protocol errors. 1=Disables performance optimization and allows PML4, > PDP, PDE and PTE entries to be in any memory type. Operating systems > that maintain page tables in memory types other than WB- DRAM must set > TlbCacheDis to insure proper operation." > > The MCE generated is an NB protocol error to signal that > > "Link: A specific coherent-only packet from a CPU was issued to an > IO link. This may be caused by software which addresses page table > structures in a memory type other than cacheable WB-DRAM without > properly configuring MSRC001_0015[TlbCacheDis]. This may occur, for > example, when page table structure addresses are above top of memory. In > such cases, the NB will generate an MCE if it sees a mismatch between > the memory operation generated by the core and the link type." > > I'm assuming coherent-only packets don't go out on IO links, thus the > error. To fix this, reinstate TLB coherence in lazy mode. With this patch applied, we do it in one of two ways: - If we have PCID, we simply switch back to init_mm's page tables when we enter a kernel thread -- this seems to be quite cheap except for the cost of serializing the CPU. - If we don't have PCID, then we set a flag and switch to init_mm the first time we would otherwise need to flush the TLB. The /sys/kernel/debug/x86/tlb_use_lazy_mode debug switch can be changed to override the default mode for benchmarking. In theory, we could optimize this better by only flushing the TLB in lazy CPUs when a page table is freed. Doing that would require auditing the mm code to make sure that all page table freeing goes through tlb_remove_page() as well as reworking some data structures to implement the improved flush logic. Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de> Reported-by: Adam Borowski <kilobyte@angband.pl> Signed-off-by: Andy Lutomirski <luto@kernel.org> Signed-off-by: Borislav Petkov <bp@suse.de> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Eric Biggers <ebiggers@google.com> Cc: Johannes Hirte <johannes.hirte@datenkhaos.de> Cc: Kees Cook <keescook@chromium.org> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Nadav Amit <nadav.amit@gmail.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Rik van Riel <riel@redhat.com> Cc: Roman Kagan <rkagan@virtuozzo.com> Cc: Thomas Gleixner <tglx@linutronix.de> Fixes: 94b1b03b519b ("x86/mm: Rework lazy TLB mode and TLB freshness tracking") Link: http://lkml.kernel.org/r/20171009170231.fkpraqokz6e4zeco@pd.tnic Signed-off-by: Ingo Molnar <mingo@kernel.org>
375 lines
10 KiB
C
375 lines
10 KiB
C
#ifndef _ASM_X86_TLBFLUSH_H
|
|
#define _ASM_X86_TLBFLUSH_H
|
|
|
|
#include <linux/mm.h>
|
|
#include <linux/sched.h>
|
|
|
|
#include <asm/processor.h>
|
|
#include <asm/cpufeature.h>
|
|
#include <asm/special_insns.h>
|
|
#include <asm/smp.h>
|
|
|
|
static inline void __invpcid(unsigned long pcid, unsigned long addr,
|
|
unsigned long type)
|
|
{
|
|
struct { u64 d[2]; } desc = { { pcid, addr } };
|
|
|
|
/*
|
|
* The memory clobber is because the whole point is to invalidate
|
|
* stale TLB entries and, especially if we're flushing global
|
|
* mappings, we don't want the compiler to reorder any subsequent
|
|
* memory accesses before the TLB flush.
|
|
*
|
|
* The hex opcode is invpcid (%ecx), %eax in 32-bit mode and
|
|
* invpcid (%rcx), %rax in long mode.
|
|
*/
|
|
asm volatile (".byte 0x66, 0x0f, 0x38, 0x82, 0x01"
|
|
: : "m" (desc), "a" (type), "c" (&desc) : "memory");
|
|
}
|
|
|
|
#define INVPCID_TYPE_INDIV_ADDR 0
|
|
#define INVPCID_TYPE_SINGLE_CTXT 1
|
|
#define INVPCID_TYPE_ALL_INCL_GLOBAL 2
|
|
#define INVPCID_TYPE_ALL_NON_GLOBAL 3
|
|
|
|
/* Flush all mappings for a given pcid and addr, not including globals. */
|
|
static inline void invpcid_flush_one(unsigned long pcid,
|
|
unsigned long addr)
|
|
{
|
|
__invpcid(pcid, addr, INVPCID_TYPE_INDIV_ADDR);
|
|
}
|
|
|
|
/* Flush all mappings for a given PCID, not including globals. */
|
|
static inline void invpcid_flush_single_context(unsigned long pcid)
|
|
{
|
|
__invpcid(pcid, 0, INVPCID_TYPE_SINGLE_CTXT);
|
|
}
|
|
|
|
/* Flush all mappings, including globals, for all PCIDs. */
|
|
static inline void invpcid_flush_all(void)
|
|
{
|
|
__invpcid(0, 0, INVPCID_TYPE_ALL_INCL_GLOBAL);
|
|
}
|
|
|
|
/* Flush all mappings for all PCIDs except globals. */
|
|
static inline void invpcid_flush_all_nonglobals(void)
|
|
{
|
|
__invpcid(0, 0, INVPCID_TYPE_ALL_NON_GLOBAL);
|
|
}
|
|
|
|
static inline u64 inc_mm_tlb_gen(struct mm_struct *mm)
|
|
{
|
|
u64 new_tlb_gen;
|
|
|
|
/*
|
|
* Bump the generation count. This also serves as a full barrier
|
|
* that synchronizes with switch_mm(): callers are required to order
|
|
* their read of mm_cpumask after their writes to the paging
|
|
* structures.
|
|
*/
|
|
smp_mb__before_atomic();
|
|
new_tlb_gen = atomic64_inc_return(&mm->context.tlb_gen);
|
|
smp_mb__after_atomic();
|
|
|
|
return new_tlb_gen;
|
|
}
|
|
|
|
#ifdef CONFIG_PARAVIRT
|
|
#include <asm/paravirt.h>
|
|
#else
|
|
#define __flush_tlb() __native_flush_tlb()
|
|
#define __flush_tlb_global() __native_flush_tlb_global()
|
|
#define __flush_tlb_single(addr) __native_flush_tlb_single(addr)
|
|
#endif
|
|
|
|
/*
|
|
* If tlb_use_lazy_mode is true, then we try to avoid switching CR3 to point
|
|
* to init_mm when we switch to a kernel thread (e.g. the idle thread). If
|
|
* it's false, then we immediately switch CR3 when entering a kernel thread.
|
|
*/
|
|
DECLARE_STATIC_KEY_TRUE(tlb_use_lazy_mode);
|
|
|
|
/*
|
|
* 6 because 6 should be plenty and struct tlb_state will fit in
|
|
* two cache lines.
|
|
*/
|
|
#define TLB_NR_DYN_ASIDS 6
|
|
|
|
struct tlb_context {
|
|
u64 ctx_id;
|
|
u64 tlb_gen;
|
|
};
|
|
|
|
struct tlb_state {
|
|
/*
|
|
* cpu_tlbstate.loaded_mm should match CR3 whenever interrupts
|
|
* are on. This means that it may not match current->active_mm,
|
|
* which will contain the previous user mm when we're in lazy TLB
|
|
* mode even if we've already switched back to swapper_pg_dir.
|
|
*/
|
|
struct mm_struct *loaded_mm;
|
|
u16 loaded_mm_asid;
|
|
u16 next_asid;
|
|
|
|
/*
|
|
* We can be in one of several states:
|
|
*
|
|
* - Actively using an mm. Our CPU's bit will be set in
|
|
* mm_cpumask(loaded_mm) and is_lazy == false;
|
|
*
|
|
* - Not using a real mm. loaded_mm == &init_mm. Our CPU's bit
|
|
* will not be set in mm_cpumask(&init_mm) and is_lazy == false.
|
|
*
|
|
* - Lazily using a real mm. loaded_mm != &init_mm, our bit
|
|
* is set in mm_cpumask(loaded_mm), but is_lazy == true.
|
|
* We're heuristically guessing that the CR3 load we
|
|
* skipped more than makes up for the overhead added by
|
|
* lazy mode.
|
|
*/
|
|
bool is_lazy;
|
|
|
|
/*
|
|
* Access to this CR4 shadow and to H/W CR4 is protected by
|
|
* disabling interrupts when modifying either one.
|
|
*/
|
|
unsigned long cr4;
|
|
|
|
/*
|
|
* This is a list of all contexts that might exist in the TLB.
|
|
* There is one per ASID that we use, and the ASID (what the
|
|
* CPU calls PCID) is the index into ctxts.
|
|
*
|
|
* For each context, ctx_id indicates which mm the TLB's user
|
|
* entries came from. As an invariant, the TLB will never
|
|
* contain entries that are out-of-date as when that mm reached
|
|
* the tlb_gen in the list.
|
|
*
|
|
* To be clear, this means that it's legal for the TLB code to
|
|
* flush the TLB without updating tlb_gen. This can happen
|
|
* (for now, at least) due to paravirt remote flushes.
|
|
*
|
|
* NB: context 0 is a bit special, since it's also used by
|
|
* various bits of init code. This is fine -- code that
|
|
* isn't aware of PCID will end up harmlessly flushing
|
|
* context 0.
|
|
*/
|
|
struct tlb_context ctxs[TLB_NR_DYN_ASIDS];
|
|
};
|
|
DECLARE_PER_CPU_SHARED_ALIGNED(struct tlb_state, cpu_tlbstate);
|
|
|
|
/* Initialize cr4 shadow for this CPU. */
|
|
static inline void cr4_init_shadow(void)
|
|
{
|
|
this_cpu_write(cpu_tlbstate.cr4, __read_cr4());
|
|
}
|
|
|
|
/* Set in this cpu's CR4. */
|
|
static inline void cr4_set_bits(unsigned long mask)
|
|
{
|
|
unsigned long cr4;
|
|
|
|
cr4 = this_cpu_read(cpu_tlbstate.cr4);
|
|
if ((cr4 | mask) != cr4) {
|
|
cr4 |= mask;
|
|
this_cpu_write(cpu_tlbstate.cr4, cr4);
|
|
__write_cr4(cr4);
|
|
}
|
|
}
|
|
|
|
/* Clear in this cpu's CR4. */
|
|
static inline void cr4_clear_bits(unsigned long mask)
|
|
{
|
|
unsigned long cr4;
|
|
|
|
cr4 = this_cpu_read(cpu_tlbstate.cr4);
|
|
if ((cr4 & ~mask) != cr4) {
|
|
cr4 &= ~mask;
|
|
this_cpu_write(cpu_tlbstate.cr4, cr4);
|
|
__write_cr4(cr4);
|
|
}
|
|
}
|
|
|
|
static inline void cr4_toggle_bits(unsigned long mask)
|
|
{
|
|
unsigned long cr4;
|
|
|
|
cr4 = this_cpu_read(cpu_tlbstate.cr4);
|
|
cr4 ^= mask;
|
|
this_cpu_write(cpu_tlbstate.cr4, cr4);
|
|
__write_cr4(cr4);
|
|
}
|
|
|
|
/* Read the CR4 shadow. */
|
|
static inline unsigned long cr4_read_shadow(void)
|
|
{
|
|
return this_cpu_read(cpu_tlbstate.cr4);
|
|
}
|
|
|
|
/*
|
|
* Save some of cr4 feature set we're using (e.g. Pentium 4MB
|
|
* enable and PPro Global page enable), so that any CPU's that boot
|
|
* up after us can get the correct flags. This should only be used
|
|
* during boot on the boot cpu.
|
|
*/
|
|
extern unsigned long mmu_cr4_features;
|
|
extern u32 *trampoline_cr4_features;
|
|
|
|
static inline void cr4_set_bits_and_update_boot(unsigned long mask)
|
|
{
|
|
mmu_cr4_features |= mask;
|
|
if (trampoline_cr4_features)
|
|
*trampoline_cr4_features = mmu_cr4_features;
|
|
cr4_set_bits(mask);
|
|
}
|
|
|
|
extern void initialize_tlbstate_and_flush(void);
|
|
|
|
static inline void __native_flush_tlb(void)
|
|
{
|
|
/*
|
|
* If current->mm == NULL then we borrow a mm which may change during a
|
|
* task switch and therefore we must not be preempted while we write CR3
|
|
* back:
|
|
*/
|
|
preempt_disable();
|
|
native_write_cr3(__native_read_cr3());
|
|
preempt_enable();
|
|
}
|
|
|
|
static inline void __native_flush_tlb_global_irq_disabled(void)
|
|
{
|
|
unsigned long cr4;
|
|
|
|
cr4 = this_cpu_read(cpu_tlbstate.cr4);
|
|
/* clear PGE */
|
|
native_write_cr4(cr4 & ~X86_CR4_PGE);
|
|
/* write old PGE again and flush TLBs */
|
|
native_write_cr4(cr4);
|
|
}
|
|
|
|
static inline void __native_flush_tlb_global(void)
|
|
{
|
|
unsigned long flags;
|
|
|
|
if (static_cpu_has(X86_FEATURE_INVPCID)) {
|
|
/*
|
|
* Using INVPCID is considerably faster than a pair of writes
|
|
* to CR4 sandwiched inside an IRQ flag save/restore.
|
|
*/
|
|
invpcid_flush_all();
|
|
return;
|
|
}
|
|
|
|
/*
|
|
* Read-modify-write to CR4 - protect it from preemption and
|
|
* from interrupts. (Use the raw variant because this code can
|
|
* be called from deep inside debugging code.)
|
|
*/
|
|
raw_local_irq_save(flags);
|
|
|
|
__native_flush_tlb_global_irq_disabled();
|
|
|
|
raw_local_irq_restore(flags);
|
|
}
|
|
|
|
static inline void __native_flush_tlb_single(unsigned long addr)
|
|
{
|
|
asm volatile("invlpg (%0)" ::"r" (addr) : "memory");
|
|
}
|
|
|
|
static inline void __flush_tlb_all(void)
|
|
{
|
|
if (boot_cpu_has(X86_FEATURE_PGE))
|
|
__flush_tlb_global();
|
|
else
|
|
__flush_tlb();
|
|
|
|
/*
|
|
* Note: if we somehow had PCID but not PGE, then this wouldn't work --
|
|
* we'd end up flushing kernel translations for the current ASID but
|
|
* we might fail to flush kernel translations for other cached ASIDs.
|
|
*
|
|
* To avoid this issue, we force PCID off if PGE is off.
|
|
*/
|
|
}
|
|
|
|
static inline void __flush_tlb_one(unsigned long addr)
|
|
{
|
|
count_vm_tlb_event(NR_TLB_LOCAL_FLUSH_ONE);
|
|
__flush_tlb_single(addr);
|
|
}
|
|
|
|
#define TLB_FLUSH_ALL -1UL
|
|
|
|
/*
|
|
* TLB flushing:
|
|
*
|
|
* - flush_tlb_all() flushes all processes TLBs
|
|
* - flush_tlb_mm(mm) flushes the specified mm context TLB's
|
|
* - flush_tlb_page(vma, vmaddr) flushes one page
|
|
* - flush_tlb_range(vma, start, end) flushes a range of pages
|
|
* - flush_tlb_kernel_range(start, end) flushes a range of kernel pages
|
|
* - flush_tlb_others(cpumask, info) flushes TLBs on other cpus
|
|
*
|
|
* ..but the i386 has somewhat limited tlb flushing capabilities,
|
|
* and page-granular flushes are available only on i486 and up.
|
|
*/
|
|
struct flush_tlb_info {
|
|
/*
|
|
* We support several kinds of flushes.
|
|
*
|
|
* - Fully flush a single mm. .mm will be set, .end will be
|
|
* TLB_FLUSH_ALL, and .new_tlb_gen will be the tlb_gen to
|
|
* which the IPI sender is trying to catch us up.
|
|
*
|
|
* - Partially flush a single mm. .mm will be set, .start and
|
|
* .end will indicate the range, and .new_tlb_gen will be set
|
|
* such that the changes between generation .new_tlb_gen-1 and
|
|
* .new_tlb_gen are entirely contained in the indicated range.
|
|
*
|
|
* - Fully flush all mms whose tlb_gens have been updated. .mm
|
|
* will be NULL, .end will be TLB_FLUSH_ALL, and .new_tlb_gen
|
|
* will be zero.
|
|
*/
|
|
struct mm_struct *mm;
|
|
unsigned long start;
|
|
unsigned long end;
|
|
u64 new_tlb_gen;
|
|
};
|
|
|
|
#define local_flush_tlb() __flush_tlb()
|
|
|
|
#define flush_tlb_mm(mm) flush_tlb_mm_range(mm, 0UL, TLB_FLUSH_ALL, 0UL)
|
|
|
|
#define flush_tlb_range(vma, start, end) \
|
|
flush_tlb_mm_range(vma->vm_mm, start, end, vma->vm_flags)
|
|
|
|
extern void flush_tlb_all(void);
|
|
extern void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
|
|
unsigned long end, unsigned long vmflag);
|
|
extern void flush_tlb_kernel_range(unsigned long start, unsigned long end);
|
|
|
|
static inline void flush_tlb_page(struct vm_area_struct *vma, unsigned long a)
|
|
{
|
|
flush_tlb_mm_range(vma->vm_mm, a, a + PAGE_SIZE, VM_NONE);
|
|
}
|
|
|
|
void native_flush_tlb_others(const struct cpumask *cpumask,
|
|
const struct flush_tlb_info *info);
|
|
|
|
static inline void arch_tlbbatch_add_mm(struct arch_tlbflush_unmap_batch *batch,
|
|
struct mm_struct *mm)
|
|
{
|
|
inc_mm_tlb_gen(mm);
|
|
cpumask_or(&batch->cpumask, &batch->cpumask, mm_cpumask(mm));
|
|
}
|
|
|
|
extern void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch);
|
|
|
|
#ifndef CONFIG_PARAVIRT
|
|
#define flush_tlb_others(mask, info) \
|
|
native_flush_tlb_others(mask, info)
|
|
#endif
|
|
|
|
#endif /* _ASM_X86_TLBFLUSH_H */
|