iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
1aca718e1a840f65b60488433a1f1dd56f37dd73
linux/net
History
Ziyang Xuan aa95efa187 net: qrtr: Fix a refcount bug in qrtr_recvmsg() 
[ Upstream commit 44d8073200 ]

Syzbot reported a bug as following:

refcount_t: addition on 0; use-after-free.
...
RIP: 0010:refcount_warn_saturate+0x17c/0x1f0 lib/refcount.c:25
...
Call Trace:
 <TASK>
 __refcount_add include/linux/refcount.h:199 [inline]
 __refcount_inc include/linux/refcount.h:250 [inline]
 refcount_inc include/linux/refcount.h:267 [inline]
 kref_get include/linux/kref.h:45 [inline]
 qrtr_node_acquire net/qrtr/af_qrtr.c:202 [inline]
 qrtr_node_lookup net/qrtr/af_qrtr.c:398 [inline]
 qrtr_send_resume_tx net/qrtr/af_qrtr.c:1003 [inline]
 qrtr_recvmsg+0x85f/0x990 net/qrtr/af_qrtr.c:1070
 sock_recvmsg_nosec net/socket.c:1017 [inline]
 sock_recvmsg+0xe2/0x160 net/socket.c:1038
 qrtr_ns_worker+0x170/0x1700 net/qrtr/ns.c:688
 process_one_work+0x991/0x15c0 kernel/workqueue.c:2390
 worker_thread+0x669/0x1090 kernel/workqueue.c:2537

It occurs in the concurrent scenario of qrtr_recvmsg() and
qrtr_endpoint_unregister() as following:

	cpu0					cpu1
qrtr_recvmsg				qrtr_endpoint_unregister
qrtr_send_resume_tx			qrtr_node_release
qrtr_node_lookup			mutex_lock(&qrtr_node_lock)
spin_lock_irqsave(&qrtr_nodes_lock, )	refcount_dec_and_test(&node->ref) [node->ref == 0]
radix_tree_lookup [node != NULL]	__qrtr_node_release
qrtr_node_acquire			spin_lock_irqsave(&qrtr_nodes_lock, )
kref_get(&node->ref) [WARNING]		...
					mutex_unlock(&qrtr_node_lock)

Use qrtr_node_lock to protect qrtr_node_lookup() implementation, this
is actually improving the protection of node reference.

Fixes: 0a7e0d0ef0 ("net: qrtr: Migrate node lookup tree to spinlock")
Reported-by: syzbot+a7492efaa5d61b51db23@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=a7492efaa5d61b51db23
Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-04-13 16:55:20 +02:00
..
6lowpan
net: 6lowpan: constify lowpan_nhc structures
2022-06-09 21:53:28 +02:00
9p
net/9p: fix bug in client create for .L
2023-03-22 13:33:54 +01:00
802
mrp: introduce active flags to prevent UAF when applicant uninit
2022-12-31 13:33:02 +01:00
8021q
net: gro: skb_gro_header helper function
2022-08-25 10:33:21 +02:00
appletalk
…
atm
net/atm: fix proc_mpc_write incorrect return value
2022-10-15 11:08:36 +01:00
ax25
ax25: move from strlcpy with unused retval to strscpy
2022-08-22 17:55:50 -07:00
batman-adv
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-09-22 13:02:10 -07:00
bluetooth
Bluetooth: Fix race condition in hci_cmd_sync_clear
2023-03-30 12:49:22 +02:00
bpf
Revert "bpf, test_run: fix &xdp_frame misplacement for LIVE_FRAMES"
2023-03-17 08:50:32 +01:00
bpfilter
…
bridge
netfilter: ebtables: fix table blob use-after-free
2023-03-11 13:55:24 +01:00
caif
net: caif: Fix use-after-free in cfusbl_device_notify()
2023-03-17 08:50:24 +01:00
can
can: j1939: prevent deadlock by moving j1939_sk_errqueue()
2023-04-06 12:10:52 +02:00
ceph
use less confusing names for iov_iter direction initializers
2023-02-09 11:28:04 +01:00
core
net: use indirect calls helpers for sk_exit_memory_pressure()
2023-03-17 08:50:24 +01:00
dcb
…
dccp
dccp/tcp: Avoid negative sk_forward_alloc by ipv6_pinfo.pktoptions.
2023-02-22 12:59:52 +01:00
dns_resolver
…
dsa
net: dsa: tag_brcm: legacy: fix daisy-chained switches
2023-03-30 12:49:09 +02:00
ethernet
net: gro: skb_gro_header helper function
2022-08-25 10:33:21 +02:00
ethtool
net/ethtool/ioctl: return -EOPNOTSUPP if we have no phy stats
2023-01-24 07:24:31 +01:00
hsr
hsr: ratelimit only when errors are printed
2023-04-06 12:10:58 +02:00
ieee802154
net: ieee802154: fix error return code in dgram_bind()
2022-10-07 09:29:17 +02:00
ife
…
ipv4
erspan: do not use skb_mac_header() in ndo_start_xmit()
2023-03-30 12:49:09 +02:00
ipv6
erspan: do not use skb_mac_header() in ndo_start_xmit()
2023-03-30 12:49:09 +02:00
iucv
net/iucv: Fix size of interrupt data
2023-03-22 13:33:50 +01:00
kcm
kcm: close race conditions on sk_receive_queue
2022-11-15 12:42:26 +01:00
key
xfrm: Fix oops in __xfrm_state_delete()
2022-11-22 07:14:55 +01:00
l2tp
l2tp: Avoid possible recursive deadlock in l2tp_tunnel_register()
2023-03-10 09:33:07 +01:00
l3mdev
…
lapb
…
llc
net: rename reference+tracking helpers
2022-06-09 21:52:55 -07:00
mac80211
wifi: mac80211: fix invalid drv_sta_pre_rcu_remove calls for non-uploaded sta
2023-04-13 16:55:19 +02:00
mac802154
mac802154: fix missing INIT_LIST_HEAD in ieee802154_if_add()
2022-12-05 09:53:08 +01:00
mctp
net: mctp: purge receive queues on sk destruction
2023-02-06 08:06:34 +01:00
mpls
net: mpls: fix stale pointer if allocation fails during device rename
2023-02-22 12:59:53 +01:00
mptcp
mptcp: fix UaF in listener shutdown
2023-03-30 12:49:00 +02:00
ncsi
genetlink: start to validate reserved header bytes
2022-08-29 12:47:15 +01:00
netfilter
netfilter: nft_redir: correct value of inet type .maxattrs
2023-03-22 13:33:42 +01:00
netlabel
genetlink: start to validate reserved header bytes
2022-08-29 12:47:15 +01:00
netlink
netlink: annotate data races around sk_state
2023-02-01 08:34:45 +01:00
netrom
netrom: Fix use-after-free caused by accept on already connected socket
2023-02-09 11:28:06 +01:00
nfc
nfc: change order inside nfc_se_io error path
2023-03-17 08:50:17 +01:00
nsh
…
openvswitch
net: openvswitch: fix possible memory leak in ovs_meter_cmd_set()
2023-02-22 12:59:52 +01:00
packet
packet: do not set TP_STATUS_CSUM_VALID on CHECKSUM_COMPLETE
2022-11-29 08:30:18 -08:00
phonet
…
psample
genetlink: start to validate reserved header bytes
2022-08-29 12:47:15 +01:00
qrtr
net: qrtr: Fix a refcount bug in qrtr_recvmsg()
2023-04-13 16:55:20 +02:00
rds
rds: rds_rm_zerocopy_callback() correct order for list_add_tail()
2023-03-10 09:33:02 +01:00
rfkill
…
rose
net/rose: Fix to not accept on connected socket
2023-02-22 12:59:42 +01:00
rxrpc
rxrpc: Fix missing unlock in rxrpc_do_sendmsg()
2022-12-31 13:32:55 +01:00
sched
act_mirred: use the backlog for nested calls to mirred ingress
2023-03-30 12:49:20 +02:00
sctp
sctp: add a refcnt in sctp_stream_priorities to avoid a nested loop
2023-03-11 13:55:26 +01:00
smc
net/smc: fix deadlock triggered by cancel_delayed_work_syn()
2023-03-22 13:33:47 +01:00
strparser
strparser: pad sk_skb_cb to avoid straddling cachelines
2022-07-08 18:38:44 -07:00
sunrpc
SUNRPC: fix shutdown of NFS TCP client socket
2023-04-06 12:10:44 +02:00
switchdev
net: rename reference+tracking helpers
2022-06-09 21:52:55 -07:00
tipc
tipc: fix kernel warning when sending SYN message
2023-02-22 12:59:53 +01:00
tls
net: tls: fix device-offloaded sendpage straddling records
2023-03-17 08:50:26 +01:00
unix
af_unix: fix struct pid leaks in OOB support
2023-03-17 08:50:28 +01:00
vmw_vsock
net: vmw_vsock: vmci: Check memcpy_from_msg()
2022-12-31 13:32:26 +01:00
wireless
wifi: cfg80211: fix MLO connection ownership
2023-03-22 13:33:43 +01:00
x25
net/x25: Fix to not accept on connected socket
2023-02-09 11:28:13 +01:00
xdp
xsk: Add missing overflow check in xdp_umem_reg
2023-03-30 12:49:02 +02:00
xfrm
xfrm: Zero padding when dumping algos and encap
2023-04-06 12:10:37 +02:00
compat.c
use less confusing names for iov_iter direction initializers
2023-02-09 11:28:04 +01:00
devres.c
…
Kconfig
Remove DECnet support from kernel
2022-08-22 14:26:30 +01:00
Kconfig.debug
net: make NET_(DEV|NS)_REFCNT_TRACKER depend on NET
2022-09-20 14:23:56 -07:00
Makefile
Remove DECnet support from kernel
2022-08-22 14:26:30 +01:00
socket.c
net: avoid double iput when sock_alloc_file fails
2023-03-10 09:34:34 +01:00
sysctl_net.c
…