linux/drivers/tty
Takatoshi Akiyama 1be2266392 serial: sh-sci: Fix unlocked access to SCSCR register
The SCSCR register access in sci_break_ctl() is not locked.

sci_start_tx() and sci_set_termios() changes the SCSCR register,
but does not lock sci_port.

Therefore, this patch adds lock during register access.

Also, remove the log output that leads to a double lock.

Some analysis of where locks are not taken is as follows.
It appears that the lock is not taken in:
  - sci_start_tx(), sci_stop_tx()  as this is installed as a callback.
    And all callers of the callback take the lock.
  - start_rx as callers take the lock.
  - stop_rx. this is both installed as a callback and called directly.
    In both cases the caller takes the lock.

Signed-off-by: Takatoshi Akiyama <takatoshi.akiyama.kj@ps.hitachi-solutions.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-04 12:08:53 +01:00
..
hvc powerpc updates for 4.14 2017-09-07 10:15:40 -07:00
ipwireless networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
serdev serdev: fix controller-allocation error handling 2017-10-23 11:25:48 +02:00
serial serial: sh-sci: Fix unlocked access to SCSCR register 2017-11-04 12:08:53 +01:00
vt tty: vt: remove multi-fetch, derive font.height from font.data 2017-10-20 14:06:45 +02:00
amiserial.c tty: amiserial: drop broken alt-speed support 2017-06-13 11:49:58 +02:00
bfin_jtag_comm.c
cyclades.c tty: cyclades: Convert timers to use timer_setup() 2017-11-04 12:01:54 +01:00
ehv_bytechan.c tty: Convert to using %pOF instead of full_name 2017-07-30 07:35:28 -07:00
goldfish.c tty: goldfish: Implement support for kernel 'earlycon' parameter 2017-08-31 18:58:45 +02:00
isicom.c tty: isicom: constify pci_device_id. 2017-07-30 07:35:27 -07:00
Kconfig Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next 2017-09-10 09:57:23 -07:00
Makefile sparc64: vcc: Enable VCC module in linux 2017-08-15 21:33:50 -07:00
metag_da.c tty: metag_da: Convert timers to use timer_setup() 2017-10-20 14:06:46 +02:00
mips_ejtag_fdc.c tty: mips_ejtag_fdc: Convert timers to use timer_setup() 2017-10-20 14:06:46 +02:00
moxa.c tty: moxa: constify pci_device_id. 2017-07-30 07:35:28 -07:00
moxa.h
mxser.c Merge 4.14-rc4 into tty-next 2017-10-09 09:05:05 +02:00
mxser.h
n_gsm.c drivers: tty: n_gsm: use setup_timer() helper. 2017-10-03 20:28:36 +02:00
n_hdlc.c format-security: move static strings to const 2017-05-08 17:15:14 -07:00
n_null.c tty: handle the case where we cannot restore a line discipline 2017-06-03 18:43:46 +09:00
n_r3964.c
n_tracerouter.c
n_tracesink.c
n_tracesink.h
n_tty.c
nozomi.c
pty.c TTY/Serial updates for 4.14-rc1 2017-09-05 10:30:48 -07:00
rocket_int.h
rocket.c tty: rocket: drop broken alt-speed support 2017-06-13 11:49:58 +02:00
rocket.h
synclink_gt.c tty: synclink_gt: constify pci_device_id. 2017-07-30 07:35:28 -07:00
synclink.c tty: synclink: Reuse an existing error handling path 2017-09-18 18:31:48 +02:00
synclinkmp.c tty: synclinkmp: constify pci_device_id. 2017-07-30 07:35:27 -07:00
sysrq.c tty/sysrq: Convert timers to use timer_setup() 2017-10-20 14:06:46 +02:00
tty_audit.c
tty_baudrate.c tty: move baudrate handling code to a file of its own 2017-04-18 18:01:52 +02:00
tty_buffer.c tty: fix tty_ldisc_receive_buf() documentation 2017-11-04 12:08:53 +01:00
tty_io.c Staging/IIO driver updates for 4.14-rc1 2017-09-05 10:36:26 -07:00
tty_ioctl.c tty: move baudrate handling code to a file of its own 2017-04-18 18:01:52 +02:00
tty_jobctrl.c tty: split job control support into a file of its own 2017-04-18 18:01:52 +02:00
tty_ldisc.c TTY/Serial patches for 4.13-rc1 2017-07-03 20:04:16 -07:00
tty_ldsem.c
tty_mutex.c
tty_port.c ttyport: trivial fix for some typo in comments 2017-09-18 18:31:48 +02:00
vcc.c tty: vcc: Convert timers to use timer_setup() 2017-11-04 12:01:54 +01:00