c306171d69
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert these drivers from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
385 lines
8.6 KiB
C
385 lines
8.6 KiB
C
/*
|
|
* B53 register access through memory mapped registers
|
|
*
|
|
* Copyright (C) 2012-2013 Jonas Gorski <jogo@openwrt.org>
|
|
*
|
|
* Permission to use, copy, modify, and/or distribute this software for any
|
|
* purpose with or without fee is hereby granted, provided that the above
|
|
* copyright notice and this permission notice appear in all copies.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
|
|
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*/
|
|
|
|
#include <linux/bits.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/io.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/platform_data/b53.h>
|
|
|
|
#include "b53_priv.h"
|
|
|
|
struct b53_mmap_priv {
|
|
void __iomem *regs;
|
|
};
|
|
|
|
static int b53_mmap_read8(struct b53_device *dev, u8 page, u8 reg, u8 *val)
|
|
{
|
|
struct b53_mmap_priv *priv = dev->priv;
|
|
void __iomem *regs = priv->regs;
|
|
|
|
*val = readb(regs + (page << 8) + reg);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int b53_mmap_read16(struct b53_device *dev, u8 page, u8 reg, u16 *val)
|
|
{
|
|
struct b53_mmap_priv *priv = dev->priv;
|
|
void __iomem *regs = priv->regs;
|
|
|
|
if (WARN_ON(reg % 2))
|
|
return -EINVAL;
|
|
|
|
if (dev->pdata && dev->pdata->big_endian)
|
|
*val = ioread16be(regs + (page << 8) + reg);
|
|
else
|
|
*val = readw(regs + (page << 8) + reg);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int b53_mmap_read32(struct b53_device *dev, u8 page, u8 reg, u32 *val)
|
|
{
|
|
struct b53_mmap_priv *priv = dev->priv;
|
|
void __iomem *regs = priv->regs;
|
|
|
|
if (WARN_ON(reg % 4))
|
|
return -EINVAL;
|
|
|
|
if (dev->pdata && dev->pdata->big_endian)
|
|
*val = ioread32be(regs + (page << 8) + reg);
|
|
else
|
|
*val = readl(regs + (page << 8) + reg);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int b53_mmap_read48(struct b53_device *dev, u8 page, u8 reg, u64 *val)
|
|
{
|
|
struct b53_mmap_priv *priv = dev->priv;
|
|
void __iomem *regs = priv->regs;
|
|
|
|
if (WARN_ON(reg % 2))
|
|
return -EINVAL;
|
|
|
|
if (reg % 4) {
|
|
u16 lo;
|
|
u32 hi;
|
|
|
|
if (dev->pdata && dev->pdata->big_endian) {
|
|
lo = ioread16be(regs + (page << 8) + reg);
|
|
hi = ioread32be(regs + (page << 8) + reg + 2);
|
|
} else {
|
|
lo = readw(regs + (page << 8) + reg);
|
|
hi = readl(regs + (page << 8) + reg + 2);
|
|
}
|
|
|
|
*val = ((u64)hi << 16) | lo;
|
|
} else {
|
|
u32 lo;
|
|
u16 hi;
|
|
|
|
if (dev->pdata && dev->pdata->big_endian) {
|
|
lo = ioread32be(regs + (page << 8) + reg);
|
|
hi = ioread16be(regs + (page << 8) + reg + 4);
|
|
} else {
|
|
lo = readl(regs + (page << 8) + reg);
|
|
hi = readw(regs + (page << 8) + reg + 4);
|
|
}
|
|
|
|
*val = ((u64)hi << 32) | lo;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int b53_mmap_read64(struct b53_device *dev, u8 page, u8 reg, u64 *val)
|
|
{
|
|
struct b53_mmap_priv *priv = dev->priv;
|
|
void __iomem *regs = priv->regs;
|
|
u32 hi, lo;
|
|
|
|
if (WARN_ON(reg % 4))
|
|
return -EINVAL;
|
|
|
|
if (dev->pdata && dev->pdata->big_endian) {
|
|
lo = ioread32be(regs + (page << 8) + reg);
|
|
hi = ioread32be(regs + (page << 8) + reg + 4);
|
|
} else {
|
|
lo = readl(regs + (page << 8) + reg);
|
|
hi = readl(regs + (page << 8) + reg + 4);
|
|
}
|
|
|
|
*val = ((u64)hi << 32) | lo;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int b53_mmap_write8(struct b53_device *dev, u8 page, u8 reg, u8 value)
|
|
{
|
|
struct b53_mmap_priv *priv = dev->priv;
|
|
void __iomem *regs = priv->regs;
|
|
|
|
writeb(value, regs + (page << 8) + reg);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int b53_mmap_write16(struct b53_device *dev, u8 page, u8 reg,
|
|
u16 value)
|
|
{
|
|
struct b53_mmap_priv *priv = dev->priv;
|
|
void __iomem *regs = priv->regs;
|
|
|
|
if (WARN_ON(reg % 2))
|
|
return -EINVAL;
|
|
|
|
if (dev->pdata && dev->pdata->big_endian)
|
|
iowrite16be(value, regs + (page << 8) + reg);
|
|
else
|
|
writew(value, regs + (page << 8) + reg);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int b53_mmap_write32(struct b53_device *dev, u8 page, u8 reg,
|
|
u32 value)
|
|
{
|
|
struct b53_mmap_priv *priv = dev->priv;
|
|
void __iomem *regs = priv->regs;
|
|
|
|
if (WARN_ON(reg % 4))
|
|
return -EINVAL;
|
|
|
|
if (dev->pdata && dev->pdata->big_endian)
|
|
iowrite32be(value, regs + (page << 8) + reg);
|
|
else
|
|
writel(value, regs + (page << 8) + reg);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int b53_mmap_write48(struct b53_device *dev, u8 page, u8 reg,
|
|
u64 value)
|
|
{
|
|
if (WARN_ON(reg % 2))
|
|
return -EINVAL;
|
|
|
|
if (reg % 4) {
|
|
u32 hi = (u32)(value >> 16);
|
|
u16 lo = (u16)value;
|
|
|
|
b53_mmap_write16(dev, page, reg, lo);
|
|
b53_mmap_write32(dev, page, reg + 2, hi);
|
|
} else {
|
|
u16 hi = (u16)(value >> 32);
|
|
u32 lo = (u32)value;
|
|
|
|
b53_mmap_write32(dev, page, reg, lo);
|
|
b53_mmap_write16(dev, page, reg + 4, hi);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int b53_mmap_write64(struct b53_device *dev, u8 page, u8 reg,
|
|
u64 value)
|
|
{
|
|
u32 hi, lo;
|
|
|
|
hi = upper_32_bits(value);
|
|
lo = lower_32_bits(value);
|
|
|
|
if (WARN_ON(reg % 4))
|
|
return -EINVAL;
|
|
|
|
b53_mmap_write32(dev, page, reg, lo);
|
|
b53_mmap_write32(dev, page, reg + 4, hi);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int b53_mmap_phy_read16(struct b53_device *dev, int addr, int reg,
|
|
u16 *value)
|
|
{
|
|
return -EIO;
|
|
}
|
|
|
|
static int b53_mmap_phy_write16(struct b53_device *dev, int addr, int reg,
|
|
u16 value)
|
|
{
|
|
return -EIO;
|
|
}
|
|
|
|
static const struct b53_io_ops b53_mmap_ops = {
|
|
.read8 = b53_mmap_read8,
|
|
.read16 = b53_mmap_read16,
|
|
.read32 = b53_mmap_read32,
|
|
.read48 = b53_mmap_read48,
|
|
.read64 = b53_mmap_read64,
|
|
.write8 = b53_mmap_write8,
|
|
.write16 = b53_mmap_write16,
|
|
.write32 = b53_mmap_write32,
|
|
.write48 = b53_mmap_write48,
|
|
.write64 = b53_mmap_write64,
|
|
.phy_read16 = b53_mmap_phy_read16,
|
|
.phy_write16 = b53_mmap_phy_write16,
|
|
};
|
|
|
|
static int b53_mmap_probe_of(struct platform_device *pdev,
|
|
struct b53_platform_data **ppdata)
|
|
{
|
|
struct device_node *np = pdev->dev.of_node;
|
|
struct device_node *of_ports, *of_port;
|
|
struct device *dev = &pdev->dev;
|
|
struct b53_platform_data *pdata;
|
|
void __iomem *mem;
|
|
|
|
mem = devm_platform_ioremap_resource(pdev, 0);
|
|
if (IS_ERR(mem))
|
|
return PTR_ERR(mem);
|
|
|
|
pdata = devm_kzalloc(dev, sizeof(struct b53_platform_data),
|
|
GFP_KERNEL);
|
|
if (!pdata)
|
|
return -ENOMEM;
|
|
|
|
pdata->regs = mem;
|
|
pdata->chip_id = (u32)(unsigned long)device_get_match_data(dev);
|
|
pdata->big_endian = of_property_read_bool(np, "big-endian");
|
|
|
|
of_ports = of_get_child_by_name(np, "ports");
|
|
if (!of_ports) {
|
|
dev_err(dev, "no ports child node found\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
for_each_available_child_of_node(of_ports, of_port) {
|
|
u32 reg;
|
|
|
|
if (of_property_read_u32(of_port, "reg", ®))
|
|
continue;
|
|
|
|
if (reg < B53_N_PORTS)
|
|
pdata->enabled_ports |= BIT(reg);
|
|
}
|
|
|
|
of_node_put(of_ports);
|
|
*ppdata = pdata;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int b53_mmap_probe(struct platform_device *pdev)
|
|
{
|
|
struct device_node *np = pdev->dev.of_node;
|
|
struct b53_platform_data *pdata = pdev->dev.platform_data;
|
|
struct b53_mmap_priv *priv;
|
|
struct b53_device *dev;
|
|
int ret;
|
|
|
|
if (!pdata && np) {
|
|
ret = b53_mmap_probe_of(pdev, &pdata);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "OF probe error\n");
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
if (!pdata)
|
|
return -EINVAL;
|
|
|
|
priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
|
|
if (!priv)
|
|
return -ENOMEM;
|
|
|
|
priv->regs = pdata->regs;
|
|
|
|
dev = b53_switch_alloc(&pdev->dev, &b53_mmap_ops, priv);
|
|
if (!dev)
|
|
return -ENOMEM;
|
|
|
|
dev->pdata = pdata;
|
|
|
|
platform_set_drvdata(pdev, dev);
|
|
|
|
return b53_switch_register(dev);
|
|
}
|
|
|
|
static void b53_mmap_remove(struct platform_device *pdev)
|
|
{
|
|
struct b53_device *dev = platform_get_drvdata(pdev);
|
|
|
|
if (dev)
|
|
b53_switch_remove(dev);
|
|
}
|
|
|
|
static void b53_mmap_shutdown(struct platform_device *pdev)
|
|
{
|
|
struct b53_device *dev = platform_get_drvdata(pdev);
|
|
|
|
if (dev)
|
|
b53_switch_shutdown(dev);
|
|
|
|
platform_set_drvdata(pdev, NULL);
|
|
}
|
|
|
|
static const struct of_device_id b53_mmap_of_table[] = {
|
|
{
|
|
.compatible = "brcm,bcm3384-switch",
|
|
.data = (void *)BCM63XX_DEVICE_ID,
|
|
}, {
|
|
.compatible = "brcm,bcm6318-switch",
|
|
.data = (void *)BCM63268_DEVICE_ID,
|
|
}, {
|
|
.compatible = "brcm,bcm6328-switch",
|
|
.data = (void *)BCM63XX_DEVICE_ID,
|
|
}, {
|
|
.compatible = "brcm,bcm6362-switch",
|
|
.data = (void *)BCM63XX_DEVICE_ID,
|
|
}, {
|
|
.compatible = "brcm,bcm6368-switch",
|
|
.data = (void *)BCM63XX_DEVICE_ID,
|
|
}, {
|
|
.compatible = "brcm,bcm63268-switch",
|
|
.data = (void *)BCM63268_DEVICE_ID,
|
|
}, {
|
|
.compatible = "brcm,bcm63xx-switch",
|
|
.data = (void *)BCM63XX_DEVICE_ID,
|
|
}, { /* sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, b53_mmap_of_table);
|
|
|
|
static struct platform_driver b53_mmap_driver = {
|
|
.probe = b53_mmap_probe,
|
|
.remove_new = b53_mmap_remove,
|
|
.shutdown = b53_mmap_shutdown,
|
|
.driver = {
|
|
.name = "b53-switch",
|
|
.of_match_table = b53_mmap_of_table,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(b53_mmap_driver);
|
|
MODULE_AUTHOR("Jonas Gorski <jogo@openwrt.org>");
|
|
MODULE_DESCRIPTION("B53 MMAP access driver");
|
|
MODULE_LICENSE("Dual BSD/GPL");
|