Miquel Raynal 1d5f55634c Revert "mtd: rawnand: sharpsl: Fix external use of SW Hamming ECC helper" ... This reverts commit 46fcb57e6b. Before the introduction of the ECC framework infrastructure, many drivers used the ->calculate/correct() Hamming helpers directly. The point of this framework was to avoid this kind of hackish calls and use a proper and generic API but it is true that in certain cases, drivers still need to use these helpers in order to do ECC computations on behalf of their limited hardware. Right after the introduction of the ECC engine core introduction, it was spotted that it was not possible to use the shiny rawnand software ECC helpers so easily because an ECC engine object should have been allocated and initialized first. While this works well in most cases, for these drivers just leveraging the power of a single helper in conjunction with some pretty old and limited hardware, it did not fit. The idea back then was to declare intermediate helpers which would make use of the exported software ECC engine bare functions while keeping the rawnand layer compatibility. As there was already functions with the rawnand_sw_hamming_ prefix it was decided to declare new local helpers for this purpose in each driver needing one. Besides being far from optimal, this design choice was blamed by Linus when he pulled the "fixes" pull request [1] so that is why now it is time to clean this mess up. The implementation of the rawnand_ecc_sw_* helpers has now been enhanced to support both cases, when the ECC object is instantiated and when it is not. This way, we can still use the existing and exported rawnand helpers while avoiding the need for each driver to declare its own helper, thus this fix from [2] can now be safely reverted. [1] https://lore.kernel.org/lkml/CAHk-=wh_ZHF685Fni8V9is17mj=pFisUaZ_0=gq6nbK+ZcyQmg@mail.gmail.com/ [2] https://lore.kernel.org/linux-mtd/20210413161840.345208-1-miquel.raynal@bootlin.com Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20210928221507.199198-6-miquel.raynal@bootlin.com		2021-10-15 12:21:05 +02:00
..
onenand	mtd: onenand: samsung: drop Exynos4 and describe driver in KConfig	2021-09-29 00:35:27 +02:00
raw	Revert "mtd: rawnand: sharpsl: Fix external use of SW Hamming ECC helper"	2021-10-15 12:21:05 +02:00
spi	mtd: spinand: macronix: Add Quad support for serial NAND flash	2021-08-17 10:42:00 +02:00
bbt.c	mtd: nand: bbt: Fix corner case in bad block table handling	2021-05-10 18:20:54 +02:00
core.c	mtd: nand: Add helpers to manage ECC engines and configurations	2020-12-10 22:37:30 +01:00
ecc-sw-bch.c	mtd: nand: ecc-bch: Use the public nsteps field	2021-03-11 09:37:28 +01:00
ecc-sw-hamming.c	mtd: rawnand: Let callers use the bare Hamming helpers	2021-10-15 12:20:59 +02:00
ecc.c	mtd: spinand: Allow the case where there is no ECC engine	2020-12-10 22:37:30 +01:00
Kconfig	mtd: nand: Change dependency between the NAND and ECC cores	2020-12-10 22:37:32 +01:00
Makefile	mtd: nand: ecc-hamming: Move Hamming code to the generic NAND layer	2020-12-10 22:37:29 +01:00